Re: [PATCH v2 00/20] insert command

2012-11-25 Thread Mark Walters
This is series is looking good. I have a few minor issues but no more. There are two parts I don't really know enough about to be certain about: the fsyncing and the sigtrap bit. For fsync: I have some recollection that you have to fsync all subpaths to the root to guarantee that it makes it

Re: [PATCH v2 00/20] insert command

2012-11-25 Thread David Bremner
Peter Wang noval...@gmail.com writes: - shared tag operation parser with notmuch-tag. Sharing tag operations with notmuch-tag is definitely a good idea, but it will also conflict with the changes of the series at id:1353792017-31459-1-git-send-email-da...@tethera.net Although I might be