Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-24 Thread Austin Clements
Quoth David Bremner on Aug 23 at 8:58 pm: Austin Clements amdra...@mit.edu writes: @@ -1048,7 +1164,8 @@ notmuch_database_get_version (notmuch_database_t *notmuch) notmuch_bool_t notmuch_database_needs_upgrade (notmuch_database_t *notmuch) { -return notmuch-needs_upgrade;

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-24 Thread David Bremner
Austin Clements amdra...@mit.edu writes: Quoth David Bremner on Aug 23 at 8:58 pm: Austin Clements amdra...@mit.edu writes: @@ -1048,7 +1164,8 @@ notmuch_database_get_version (notmuch_database_t *notmuch) notmuch_bool_t notmuch_database_needs_upgrade (notmuch_database_t *notmuch)

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread Jani Nikula
On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote: Previously, our database schema was versioned by a single number. Each database schema change had to occur atomically in Notmuch's development history: before some commit, Notmuch used version N, after that commit, it used version

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread David Bremner
Austin Clements amdra...@mit.edu writes: +/* Bit mask of features used by this database. Features are + * named, independent aspects of the database schema. This is a + * bitwise-OR of NOTMUCH_FEATURE_* values (below). */ +unsigned int features; Should we be using a fixed

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread Austin Clements
Quoth Jani Nikula on Aug 23 at 7:02 pm: On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote: Previously, our database schema was versioned by a single number. Each database schema change had to occur atomically in Notmuch's development history: before some commit, Notmuch used

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread Austin Clements
On Sat, 23 Aug 2014, David Bremner da...@tethera.net wrote: Austin Clements amdra...@mit.edu writes: +/* Bit mask of features used by this database. Features are + * named, independent aspects of the database schema. This is a + * bitwise-OR of NOTMUCH_FEATURE_* values

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread David Bremner
Austin Clements amdra...@mit.edu writes: @@ -1048,7 +1164,8 @@ notmuch_database_get_version (notmuch_database_t *notmuch) notmuch_bool_t notmuch_database_needs_upgrade (notmuch_database_t *notmuch) { -return notmuch-needs_upgrade; +return notmuch-mode ==