Re: [notmuch] [PATCH] notmuch-restore.c: only update tags for messages that differ from dump file.

[Carl Worth]

On Tue,  8 Dec 2009 18:07:43 -0400, da...@tethera.net wrote:
 This is posting 3 of the patch. The second version fixed a bug.  This
 version replaces calloc/realloc with talloc equivalents, prettifies
 the comparison function for qsort, reindents, and adds a bunch of
 whitespace.

It's odd that even after reviewing a couple of rounds of this patch, I
then went and forgot about it when I wrote my own version. I could have
saved myself some work otherwise.

Ah well, let me know if you see anything that you think should be
changed in the code that's in place now.

Thanks,

-Carl


pgpnw3z0vjVKL.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [notmuch] [PATCH] notmuch-restore.c: only update tags for messages that differ from dump file.

[Scott Robinson]

Excerpts from david's message of Mon Dec 07 19:14:48 -0800 2009:
 The patch allocates a temporary array to keep track of the current
 list of tags using calloc and grows it as neccesary using realloc.

The codebase has already well established the use of the talloc library. Why
did you break with that?
-- 
Scott Robinson | http://quadhome.com/

Q: Why are my replies five sentences or less?
A: http://five.sentenc.es/
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch