Re: [notmuch] [PATCH 2/2] Build and link against notmuch shared library
On Thu, 11 Mar 2010 14:41:09 -0800 (PST), Ben Gamari wrote: > On Thu, 04 Mar 2010 09:25:45 +0100, "Sebastian Spaeth" > wrote: > > I just tried out this patch to compile notmuch as a shared library and > > while producing lib/libnotmuch.so.1 it fails to find notmuch later: > > Try the version I just posted. It will apply against master and builds on my > machine. Using the updated patch and a stock cworth/master I still got that error. Using the updated patchset that was just posted and builds on your work, it compiled and installed fine (but failed to find libnotmuch.so.1 in /usr/local/lib) I don't think I have a special setup on this box, so I wonder why it did not work for me. spaetz ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [notmuch] [PATCH 2/2] Build and link against notmuch shared library
On Thu, 04 Mar 2010 09:25:45 +0100, "Sebastian Spaeth" wrote: > I just tried out this patch to compile notmuch as a shared library and > while producing lib/libnotmuch.so.1 it fails to find notmuch later: Try the version I just posted. It will apply against master and builds on my machine. > Is more needed than this patch? Also, *I* think it would be nice to > support --static or --shared as options to --configure. But that is a > minor thing, probably. What do others think about this? Would it be useful, counter-productive, or none of the above to allow configuration of the library type? Cheers, - Ben ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [notmuch] [PATCH 2/2] Build and link against notmuch shared library
> notmuch_client_modules = $(notmuch_client_srcs:.c=.o) > -notmuch: $(notmuch_client_modules) lib/notmuch.a > - $(call quiet,CXX,$(LDFLAGS)) $^ $(FINAL_LDFLAGS) -o $@ > +notmuch: $(notmuch_client_modules) lib/libnotmuch.so > + $(call quiet,CC,$(LDFLAGS)) -lnotmuch $(filter-out > lib/libnotmuch.so,$^) $(FINAL_LDFLAGS) -o $@ I just tried out this patch to compile notmuch as a shared library and while producing lib/libnotmuch.so.1 it fails to find notmuch later: CC notmuch /usr/bin/ld: cannot find -lnotmuch Aso it creates libnotmuch.so.1 in lib but seems to try symlinking it in the "compat" dir which fails and produces a dead symlink. CXX lib/libnotmuch.so.1 ln -sf compat/libnotmuch.so.1 compat/libnotmuch.so Is more needed than this patch? Also, *I* think it would be nice to support --static or --shared as options to --configure. But that is a minor thing, probably. Sebastian ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
