Re: First draft of logging functionality.

2010-10-12 Thread Rob Browning
da...@tethera.net writes: > The patches following this message are my first attempt at > implementing atomic logging for notmuch. The idea is that such logs > could be useful in synchronizing notmuch instances. For this to be completely safe, I suspect it may need to be adjusted to do write ahea

Re: First draft of logging functionality.

2010-10-12 Thread David Bremner
On Tue, 12 Oct 2010 13:38:42 +0200, Michal Sojka wrote: > > Why multiple log files? You may have the buffers for message logs in > memory, right? Well, maybe one log for tag operations, one for adding messages, etc... But it is easy enough to mark log entries by what they are. > > Another thi

Re: First draft of logging functionality.

2010-10-12 Thread Michal Sojka
On Tue, 12 Oct 2010, David Bremner wrote: > On Tue, 12 Oct 2010 11:06:17 +0200, Michal Sojka wrote: > > > I'm not sure whether implementing logging facility outside of notmuch > > library is a good thing. If somebody will use a third-party tool (such > > as python bindings) to manipulate his tags

Re: First draft of logging functionality.

2010-10-12 Thread David Bremner
On Tue, 12 Oct 2010 11:06:17 +0200, Michal Sojka wrote: > I'm not sure whether implementing logging facility outside of notmuch > library is a good thing. If somebody will use a third-party tool (such > as python bindings) to manipulate his tags, they won't appear in the > log. Yeah, thanks for

Re: First draft of logging functionality.

2010-10-12 Thread Michal Sojka
On Mon, 11 Oct 2010, da...@tethera.net wrote: > The patches following this message are my first attempt at > implementing atomic logging for notmuch. The idea is that such logs > could be useful in synchronizing notmuch instances. > > Feedback of any kind is welcome. I'm particularly interested i