Re: Last minute fixes to the go bindings
Justus Winter 4win...@informatik.uni-hamburg.de writes: Hi everyone :) this is a small patch series that I'd like to see included in 0.13. pushed to release and master ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: Last minute fixes to the go bindings
Quoting Austin Clements (2012-05-09 20:07:00) LGTM. Quoth Justus Winter on May 09 at 12:23 pm: Hi everyone :) this is a small patch series that I'd like to see included in 0.13. The first patch updates notmuch-addrlookup with respect to Austins recent change of the notmuch_database_open function. This fixes the compilation of the utility. The second patch fixes the values of all the STATUS_* constants. Turns out all of them were set to zero by accident. This isn't a c style enum, golang has the iota operator to do this kind of stuff. This fixes the error handling for all the users of the go bindings. 'Doh! Is it possible to get the status values out of cgo, rather than depending on the list in libnotmuch and the list in Go being in the same order? Yes, it is and I've prepared a patch. But since I'm living in go 1 land here I prepared it on top of my go 1 patchset and I'm thinking of sending it once that one got merged. @David: what do you think about merging this patch set? Justus ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: Last minute fixes to the go bindings
Justus Winter 4win...@informatik.uni-hamburg.de writes: @David: what do you think about merging this patch set? Yeah, unless I am convinced otherwise, I will merge for the next release candidate. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: Last minute fixes to the go bindings
LGTM. Quoth Justus Winter on May 09 at 12:23 pm: Hi everyone :) this is a small patch series that I'd like to see included in 0.13. The first patch updates notmuch-addrlookup with respect to Austins recent change of the notmuch_database_open function. This fixes the compilation of the utility. The second patch fixes the values of all the STATUS_* constants. Turns out all of them were set to zero by accident. This isn't a c style enum, golang has the iota operator to do this kind of stuff. This fixes the error handling for all the users of the go bindings. 'Doh! Is it possible to get the status values out of cgo, rather than depending on the list in libnotmuch and the list in Go being in the same order? The third patch just brings the list of status constants up to date. Cheers, Justus ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
