Re: STYLE and uncrustify

2019-06-11 Thread Tomi Ollila
On Fri, Jun 07 2019, David Bremner wrote: > I'm pondering running uncrustify on all/most of the notmuch codebase, > but I noticed a few things that uncrustify does are either not > documented in STYLE, or maybe contradicted. > > 1) Should block comments start with '*' ? Uncrustify thinks yes, STYL

Re: STYLE and uncrustify

2019-06-10 Thread Daniel Kahn Gillmor
Hi Bremner-- Thanks for doing this kind of cleanup work. Long-term consistency is worth the short-term pain. The main short-term pain comes from dealing with changes that are in-flight. As someone with a couple of series that are in flight, of course i'd prefer that you merge my changes first,