Re: bug in emacs-ui ?
Carl Worth cworth@... writes: On Wed, 22 Jun 2011 08:50:23 +0200, Sebastien Binet seb.binet@... wrote: On Tue, 21 Jun 2011 15:09:20 -0700, Carl Worth cworth@... wrote: Perhaps this is an emacs bug? could be, but, I'm using Debian's emacs 23.3.1 and have not encountered the problem described. I don't see anything related to 'point', 'point-invisible-p' nor 'forward-char' in there: http://patch-tracker.debian.org/package/emacs23/23.3+1-1 Perhaps I was confused. I thought 23.3.1 was a distinct upstream release From 23.3, but maybe not, (emacs version numbers use 1-based indexing perhaps?). anyways... for the moment I'll just live with it... Sorry about that. except if somebody has some insights on how to catch the 'End of buffer' error and add some more protective programming around the 'scroll-up' function ? My emacs lisp skills are primarily restricted to actual experimentation. So if I can replicate the bug, I might be able to find a fix. I'm not very good at doing theoretical fixes with emacs lisp code. I bisected the problem to commit 95ef8da29439f2e79115c36ab4d2a80aef1a1462 (Fix hiding a message while some citations are shown in notmuch-show view). Reverting that fixes the problem for me. (If you don't want to resolve conflicts, also revert 432e091924c1d1d8950a44ca78bc5b9c5ade47e4 first.) I don't have the time just now to try to figure out the problem in that, but perhaps this will help others go forward. Jani ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: bug in emacs-ui ?
On Tue, 28 Jun 2011 21:38:17 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Jani. On Tue, 28 Jun 2011 10:35:48 + (UTC), Jani Nikula j...@nikula.org wrote: Carl Worth cworth@... writes: On Wed, 22 Jun 2011 08:50:23 +0200, Sebastien Binet seb.binet@... wrote: On Tue, 21 Jun 2011 15:09:20 -0700, Carl Worth cworth@... wrote: Perhaps this is an emacs bug? could be, but, I'm using Debian's emacs 23.3.1 and have not encountered the problem described. I don't see anything related to 'point', 'point-invisible-p' nor 'forward-char' in there: http://patch-tracker.debian.org/package/emacs23/23.3+1-1 Perhaps I was confused. I thought 23.3.1 was a distinct upstream release From 23.3, but maybe not, (emacs version numbers use 1-based indexing perhaps?). anyways... for the moment I'll just live with it... Sorry about that. except if somebody has some insights on how to catch the 'End of buffer' error and add some more protective programming around the 'scroll-up' function ? My emacs lisp skills are primarily restricted to actual experimentation. So if I can replicate the bug, I might be able to find a fix. I'm not very good at doing theoretical fixes with emacs lisp code. I bisected the problem to commit 95ef8da29439f2e79115c36ab4d2a80aef1a1462 (Fix hiding a message while some citations are shown in notmuch-show view). Reverting that fixes the problem for me. (If you don't want to resolve conflicts, also revert 432e091924c1d1d8950a44ca78bc5b9c5ade47e4 first.) I don't have the time just now to try to figure out the problem in that, but perhaps this will help others go forward. Thanks for tracking this. I will look into it. I have posted a patch to fix this bug [1]. Regards, Dmitry [1] id:1309312132-14564-2-git-send-email-dmitry.kuroch...@gmail.com Regards, Dmitry Jani ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: bug in emacs-ui ?
On Wed, 22 Jun 2011 08:50:23 +0200, Sebastien Binet seb.bi...@gmail.com wrote: On Tue, 21 Jun 2011 15:09:20 -0700, Carl Worth cwo...@cworth.org wrote: Perhaps this is an emacs bug? could be, but, I'm using Debian's emacs 23.3.1 and have not encountered the problem described. I don't see anything related to 'point', 'point-invisible-p' nor 'forward-char' in there: http://patch-tracker.debian.org/package/emacs23/23.3+1-1 Perhaps I was confused. I thought 23.3.1 was a distinct upstream release From 23.3, but maybe not, (emacs version numbers use 1-based indexing perhaps?). anyways... for the moment I'll just live with it... Sorry about that. except if somebody has some insights on how to catch the 'End of buffer' error and add some more protective programming around the 'scroll-up' function ? My emacs lisp skills are primarily restricted to actual experimentation. So if I can replicate the bug, I might be able to find a fix. I'm not very good at doing theoretical fixes with emacs lisp code. -Carl pgpFoPwpDytML.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: bug in emacs-ui ?
On Mon, 20 Jun 2011 22:41:18 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Non-text part: multipart/signed On Tue, 21 Jun 2011 02:01:17 +0200, Sebastien Binet seb.bi...@gmail.com wrote: and I checked there were no lingering .el files... so... any way to tell which notmuch-emacs-ui I am actually using ? (I am a newbie when comes to hacking lisp) Hey, Sebastien. You can determine the loaded version of a library from within emacs with the follow command: M-x locate-library notmuch which points to the system-wide one. It's also good to know how many notmuch instances are installed on your system. For instance, I have a system-wide installation, a personal installation, the build currently in the source tree, etc. Depending on the options I supply to emacs at startup, I could run a variety of versions. being root and having this great ArchLinux package manager system at my finger tips, I only have one installation of notmuch :) playing a bit more, I cloned your 0.6 branch, cloned the official one, slammed the 0.6/emacs directory on top of the official one, built the official one, installed it and everything worked. I am trying to see which changeset is the source of my problem... -s pgpR8lM2HBb7H.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: bug in emacs-ui ?
hi, On Mon, 20 Jun 2011 22:41:18 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Non-text part: multipart/signed On Tue, 21 Jun 2011 02:01:17 +0200, Sebastien Binet seb.bi...@gmail.com wrote: and I checked there were no lingering .el files... so... any way to tell which notmuch-emacs-ui I am actually using ? (I am a newbie when comes to hacking lisp) Hey, Sebastien. You can determine the loaded version of a library from within emacs with the follow command: M-x locate-library notmuch It's also good to know how many notmuch instances are installed on your system. For instance, I have a system-wide installation, a personal installation, the build currently in the source tree, etc. Depending on the options I supply to emacs at startup, I could run a variety of versions. so, it seems the problem comes from: (defun notmuch-show-advance-and-archive () Advance through thread and archive. (interactive) (let ((end-of-this-message (notmuch-show-message-bottom))) (cond ;; Ideally we would test `end-of-this-message' against the result ;; of `window-end', but that doesn't account for the fact that ;; the end of the message might be hidden, so we have to actually ;; go to the end, walk back over invisible text and then see if ;; point is visible. ((save-excursion (message pt00: %s (point)) (goto-char (- end-of-this-message 1)) (message pt01: %s (point)) (notmuch-show-move-past-invisible-backward) (message msg-end: %s end-of-this-message) (message pt11: %s (point)) ;;(goto-char (- (point) 400)) (message pt12: %s (point)) ( (point) (window-end))) (message point: %s (point)) (message window-end: %s (window-end)) ;; The bottom of this message is not visible - scroll. (scroll-up nil)) ((not (= end-of-this-message (point-max))) ;; This is not the last message - move to the next visible one. (notmuch-show-next-open-message)) where I've added some good ol' print foo debugging. using the message from the openmpi mailing list I sent earlier and pressing tab, I get in the *Messages* buffer: For information about GNU Emacs and the GNU system, type C-h C-a. pt00: 1 pt01: 1392 msg-end: #marker at 1393 in *[Open MPI Announce] Open MPI... pt11: 1392 pt12: 1392 point: 1 window-end: 1113 notmuch-show-advance-and-archive: End of buffer ie: it would seem the notmuch-show-move-past-invisible-backward does *not* move the point up to just before the hidden signature (and does not move it at all.) if I uncomment the goto-char to -400 line, everything's fine. (400 is roughly the length of the hidden signature) well, this is just an educated guess from an emacs-lisp programmer complete newbie. fyi: I am using emacs-23.3 no patch were applied on top of the vanilla sources: http://projects.archlinux.org/svntogit/packages.git/tree/emacs/repos/extra-x86_64/PKGBUILD -s pgpeDHGJJ6NVX.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: bug in emacs-ui ?
On Tue, 21 Jun 2011 21:26:25 +0200, Sebastien Binet seb.bi...@gmail.com wrote: fyi: I am using emacs-23.3 Perhaps this is an emacs bug? I'm using Debian's emacs 23.3.1 and have not encountered the problem described. -Carl -- carl.d.wo...@intel.com pgpJ0G47ZadSE.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: bug in emacs-ui ?
On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet seb.bi...@gmail.com wrote: You didn't try forwarding the email to the list ;) ah! that easy, heh ? Attachment: 1300323326_0.6276.farnsworth,U=250482,FMD5=af1cd994dfcb9286c394d142687ff5a0:2,S (application/octet-stream) Are you sure this is the right message? This message doesn't include any signature section that looks like the one that you posted before. The one you posted in your previous message was: ___ Message sent via/by LCG Savannah http://savannah.cern.ch/ This one is: ___ announce mailing list annou...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/announce Also (unrelated) I notice that the above attached message is not content-type message/rfc822. Specifying the right content type helps receivers handle the messages a little better. jamie. pgp8moO987ORJ.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: bug in emacs-ui ?
On Mon, 20 Jun 2011 11:18:11 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Non-text part: multipart/signed On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet seb.bi...@gmail.com wrote: You didn't try forwarding the email to the list ;) ah! that easy, heh ? Attachment: 1300323326_0.6276.farnsworth,U=250482,FMD5=af1cd994dfcb9286c394d142687ff5a0:2,S (application/octet-stream) Are you sure this is the right message? This message doesn't include any signature section that looks like the one that you posted before. The one you posted in your previous message was: ___ Message sent via/by LCG Savannah http://savannah.cern.ch/ This one is: ___ announce mailing list annou...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/announce it is indeed another message but one which presents the same problem (the other one was from a semi-private mailing list...) Also (unrelated) I notice that the above attached message is not content-type message/rfc822. Specifying the right content type helps receivers handle the messages a little better. duly noted. -s -- # # Dr. Sebastien Binet # Laboratoire de l'Accelerateur Lineaire # Universite Paris-Sud XI # Batiment 200 # 91898 Orsay # pgpGH0OoyYZ7I.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: bug in emacs-ui ?
On Mon, 20 Jun 2011 12:53:37 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Non-text part: multipart/mixed Non-text part: multipart/signed On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet seb.bi...@gmail.com wrote: You didn't try forwarding the email to the list ;) ah! that easy, heh ? Attachment: 1300323326_0.6276.farnsworth,U=250482,FMD5=af1cd994dfcb9286c394d142687ff5a0:2,S (application/octet-stream) Hi, Sebastien. I don't seem to have any problems viewing this message with notmuch emacs. Is it possible that the notmuch emacs code you're running is out-of-sync with your notmuch binary? [...] +1. Stale notmuch binary was indeed the culprit. [..] I think that's a common source of problems like this. Make sure that you're pointed to the version of the notmuch emacs libraries that corresponds to your notmuch binary, and that you've restarted your emacs session. Hopefully that will fix things. jamie. Non-text part: application/pgp-signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch Peace -- Pieter ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: bug in emacs-ui ?
hi, On Mon, Jun 20, 2011 at 9:53 PM, Jameson Graef Rollins jroll...@finestructure.net wrote: On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet seb.bi...@gmail.com wrote: You didn't try forwarding the email to the list ;) ah! that easy, heh ? Attachment: 1300323326_0.6276.farnsworth,U=250482,FMD5=af1cd994dfcb9286c394d142687ff5a0:2,S (application/octet-stream) Hi, Sebastien. I don't seem to have any problems viewing this message with notmuch emacs. Is it possible that the notmuch emacs code you're running is out-of-sync with your notmuch binary? I think that's a common source of problems like this. Make sure that you're pointed to the version of the notmuch emacs libraries that corresponds to your notmuch binary, and that you've restarted your emacs session. Hopefully that will fix things. no joy: $ `which notmuch` --version notmuch 0.5-238-gc39b492 $ pacman -Ql notmuch-git notmuch-git /etc/ notmuch-git /etc/bash_completion.d/ notmuch-git /etc/bash_completion.d/notmuch notmuch-git /usr/ notmuch-git /usr/bin/ notmuch-git /usr/bin/notmuch notmuch-git /usr/include/ notmuch-git /usr/include/notmuch.h notmuch-git /usr/lib/ notmuch-git /usr/lib/libnotmuch.so notmuch-git /usr/lib/libnotmuch.so.1 notmuch-git /usr/lib/libnotmuch.so.1.3.0 notmuch-git /usr/lib/python2.7/ [other python files elided] notmuch-git /usr/share/ notmuch-git /usr/share/emacs/ notmuch-git /usr/share/emacs/site-lisp/ notmuch-git /usr/share/emacs/site-lisp/coolj.el notmuch-git /usr/share/emacs/site-lisp/coolj.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-address.el notmuch-git /usr/share/emacs/site-lisp/notmuch-address.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-crypto.el notmuch-git /usr/share/emacs/site-lisp/notmuch-crypto.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-hello.el notmuch-git /usr/share/emacs/site-lisp/notmuch-hello.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-lib.el notmuch-git /usr/share/emacs/site-lisp/notmuch-lib.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-logo.png notmuch-git /usr/share/emacs/site-lisp/notmuch-maildir-fcc.el notmuch-git /usr/share/emacs/site-lisp/notmuch-maildir-fcc.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-message.el notmuch-git /usr/share/emacs/site-lisp/notmuch-message.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-mua.el notmuch-git /usr/share/emacs/site-lisp/notmuch-mua.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-query.el notmuch-git /usr/share/emacs/site-lisp/notmuch-query.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-show.el notmuch-git /usr/share/emacs/site-lisp/notmuch-show.elc notmuch-git /usr/share/emacs/site-lisp/notmuch-wash.el notmuch-git /usr/share/emacs/site-lisp/notmuch-wash.elc notmuch-git /usr/share/emacs/site-lisp/notmuch.el notmuch-git /usr/share/emacs/site-lisp/notmuch.elc notmuch-git /usr/share/man/ notmuch-git /usr/share/man/man1/ notmuch-git /usr/share/man/man1/notmuch.1.gz notmuch-git /usr/share/vim/ notmuch-git /usr/share/vim/vimfiles/ notmuch-git /usr/share/vim/vimfiles/plugin/ notmuch-git /usr/share/vim/vimfiles/plugin/notmuch.vim notmuch-git /usr/share/vim/vimfiles/syntax/ notmuch-git /usr/share/vim/vimfiles/syntax/notmuch-compose.vim notmuch-git /usr/share/vim/vimfiles/syntax/notmuch-folders.vim notmuch-git /usr/share/vim/vimfiles/syntax/notmuch-git-diff.vim notmuch-git /usr/share/vim/vimfiles/syntax/notmuch-search.vim notmuch-git /usr/share/vim/vimfiles/syntax/notmuch-show.vim notmuch-git /usr/share/zsh/ notmuch-git /usr/share/zsh/functions/ notmuch-git /usr/share/zsh/functions/Completion/ notmuch-git /usr/share/zsh/functions/Completion/Unix/ notmuch-git /usr/share/zsh/functions/Completion/Unix/_notmuch and I checked there were no lingering .el files... so... any way to tell which notmuch-emacs-ui I am actually using ? (I am a newbie when comes to hacking lisp) -s ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
