Re: Speedup for deleting files
Tomi Ollila writes: > > Series LGTM. > > Tomi Series applied to master. ___ notmuch mailing list -- [email protected] To unsubscribe send an email to [email protected]
Re: Speedup for deleting files
On Thu, Jul 20 2023, David Bremner wrote: > Thanks to discussion with Olly Betts and some perf runs, I realized > the current clean up of deleted files from the database is somewhat > wasteful since it modifies the message documents (by deleting the > filename) before in most cases deleting the whole record. While trying > this out, I triggered what seems to be a bug in existing notmuch; the > code checks for the existence of a certain Xapian term after deleting > the document. > > Compared to git master [1], cleaning up 50k of 200k messages now takes > about 44s versus 80. So not quite a 50% improvement, but not bad. I > would expect a larger relative improvement on larger databases. > > [1]: https://notmuchmail.org/perf-test-results/2023-07-18-minkowski/ Series LGTM. Tomi ___ notmuch mailing list -- [email protected] To unsubscribe send an email to [email protected]
Speedup for deleting files
Thanks to discussion with Olly Betts and some perf runs, I realized the current clean up of deleted files from the database is somewhat wasteful since it modifies the message documents (by deleting the filename) before in most cases deleting the whole record. While trying this out, I triggered what seems to be a bug in existing notmuch; the code checks for the existence of a certain Xapian term after deleting the document. Compared to git master [1], cleaning up 50k of 200k messages now takes about 44s versus 80. So not quite a 50% improvement, but not bad. I would expect a larger relative improvement on larger databases. [1]: https://notmuchmail.org/perf-test-results/2023-07-18-minkowski/ ___ notmuch mailing list -- [email protected] To unsubscribe send an email to [email protected]
