Re: WIP fixes for rfc822/attachement display

2021-07-09 Thread Antoine Beaupré
On 2021-07-09 07:23:55, David Bremner wrote:
> Antoine Beaupré  writes:
>
>> On 2021-07-06 12:49:23, David Bremner wrote:
>>> David Bremner  writes:
>>>
 This is not finished/correct yet, but maybe it will save someone else
 some debugging.

 [PATCH 2/3] emacs: don't inline message/rfc822 parts without content

>>>
>>> I have confirmed that thanks to larsi's quick fix, patch 2/3 alone makes
>>> things copacetic in emacs master. I have marked the other two patches as
>>> obsolete, although if people thing this case is important enough, we
>>> could try to work around the issues with pre-28 emacs in a more
>>> careful way.
>>>
>>> Antoine, is this a common annoyance for you, or a rare issue?
>>
>> I actually fumble upon similar errors somewhat frequently, but it's the
>> first time it's reproducible. Typically, it happens under other, more
>> neboulous circumstances and the fix then is to restart emacs (!).
>>
>> Are you saying the fix is to upgrade to emacs 28?
>
> Pretty much. Along with a patch to notmuch, if you care about the
> display of !!! error messages. Of course, Emacs 28 is unreleased
> software, so may have other uncomfortable aspects.

I'm not at a place in my life where I compile my own Emacs. Once a upon
a time, that was a thing, before I found out about binary
distributions. But those days are (fortunately) over. ;)

a.

-- 
A developed country is not a place where the poor have cars. It's
where the rich use public transportation.
- Gustavo Petro 
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: WIP fixes for rfc822/attachement display

2021-07-09 Thread David Bremner
Antoine Beaupré  writes:

> On 2021-07-06 12:49:23, David Bremner wrote:
>> David Bremner  writes:
>>
>>> This is not finished/correct yet, but maybe it will save someone else
>>> some debugging.
>>>
>>> [PATCH 2/3] emacs: don't inline message/rfc822 parts without content
>>>
>>
>> I have confirmed that thanks to larsi's quick fix, patch 2/3 alone makes
>> things copacetic in emacs master. I have marked the other two patches as
>> obsolete, although if people thing this case is important enough, we
>> could try to work around the issues with pre-28 emacs in a more
>> careful way.
>>
>> Antoine, is this a common annoyance for you, or a rare issue?
>
> I actually fumble upon similar errors somewhat frequently, but it's the
> first time it's reproducible. Typically, it happens under other, more
> neboulous circumstances and the fix then is to restart emacs (!).
>
> Are you saying the fix is to upgrade to emacs 28?

Pretty much. Along with a patch to notmuch, if you care about the
display of !!! error messages. Of course, Emacs 28 is unreleased
software, so may have other uncomfortable aspects.
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: WIP fixes for rfc822/attachement display

2021-07-08 Thread Antoine Beaupré
On 2021-07-06 12:49:23, David Bremner wrote:
> David Bremner  writes:
>
>> This is not finished/correct yet, but maybe it will save someone else
>> some debugging.
>>
>> [PATCH 2/3] emacs: don't inline message/rfc822 parts without content
>>
>
> I have confirmed that thanks to larsi's quick fix, patch 2/3 alone makes
> things copacetic in emacs master. I have marked the other two patches as
> obsolete, although if people thing this case is important enough, we
> could try to work around the issues with pre-28 emacs in a more
> careful way.
>
> Antoine, is this a common annoyance for you, or a rare issue?

I actually fumble upon similar errors somewhat frequently, but it's the
first time it's reproducible. Typically, it happens under other, more
neboulous circumstances and the fix then is to restart emacs (!).

Are you saying the fix is to upgrade to emacs 28?

a.

-- 
Ou bien Dieu voudrait supprimer le mal, mais il ne le peut pas
Ou bien Dieu pourrait supprimer le mal, mais il ne le veut pas.
- Sébastien Faure
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: WIP fixes for rfc822/attachement display

2021-07-06 Thread David Bremner
David Bremner  writes:

> This is not finished/correct yet, but maybe it will save someone else
> some debugging.
>
> [PATCH 2/3] emacs: don't inline message/rfc822 parts without content
>

I have confirmed that thanks to larsi's quick fix, patch 2/3 alone makes
things copacetic in emacs master. I have marked the other two patches as
obsolete, although if people thing this case is important enough, we
could try to work around the issues with pre-28 emacs in a more
careful way.

Antoine, is this a common annoyance for you, or a rare issue?

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


WIP fixes for rfc822/attachement display

2021-07-04 Thread David Bremner
This is not finished/correct yet, but maybe it will save someone else
some debugging.

[PATCH 1/3] emacs: forcibly set notmuch-show-mode after delegating

- In particular this resets some variables to default values which
  breaks the indentation test.

[PATCH 2/3] emacs: don't inline message/rfc822 parts without content

- of the three patches, this seems like the most sane. The content
  isn't there, so either the function needs to be rewritten to handle
  re-parsing the blob, or just fail gracefully

[PATCH 3/3] emacs: dynamically bind gnus-newsgroup-charset

- this is very much papering over the symptoms
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org