Re: notmuch-crypto.el: "‘notmuch-show-get-message-id’ is not known to be defined"
On Wednesday, 2020-03-18 at 10:49:14 +01, Örjan Ekeberg wrote: > Daniel Kahn Gillmor writes: > >> When building the current version of notmuch on debian testing/unstable, >> i see the following warning: >> >> ``` >> EMACS emacs/notmuch-crypto.elc >> >> In end of data: >> emacs/notmuch-crypto.el:266:1:Warning: the function >> ‘notmuch-show-get-message-id’ is not known to be defined. >> ``` >> >> No part of the test suite fails so i assume it's not a problem, but >> having spurious warnings makes it harder to notice real warnings in the >> future. >> >> I don't know what the warning means exactly, but maybe someone who is >> better with elisp than i am could take a look at it and try to resolve >> it? > > Adding this line in notmuch-crypto.el solves this: > > (declare-function notmuch-show-get-message-id "notmuch-show" ( bare)) > > As a matter of style, I am not sure where to put it. Normally, these > declarations are put in the beginning of the file; right after the > require-statements. In notmuch-crypto.el, however, the only other > declaration is put just in front of where the function is called. As you say, we normally gather them near to the top of the file. dme. -- My girl Friday, she no square. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: notmuch-crypto.el: "‘notmuch-show-get-message-id’ is not known to be defined"
Daniel Kahn Gillmor writes: > When building the current version of notmuch on debian testing/unstable, > i see the following warning: > > ``` > EMACS emacs/notmuch-crypto.elc > > In end of data: > emacs/notmuch-crypto.el:266:1:Warning: the function > ‘notmuch-show-get-message-id’ is not known to be defined. > ``` > > No part of the test suite fails so i assume it's not a problem, but > having spurious warnings makes it harder to notice real warnings in the > future. > > I don't know what the warning means exactly, but maybe someone who is > better with elisp than i am could take a look at it and try to resolve > it? Adding this line in notmuch-crypto.el solves this: (declare-function notmuch-show-get-message-id "notmuch-show" ( bare)) As a matter of style, I am not sure where to put it. Normally, these declarations are put in the beginning of the file; right after the require-statements. In notmuch-crypto.el, however, the only other declaration is put just in front of where the function is called. /Örjan ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
notmuch-crypto.el: "‘notmuch-show-get-message-id’ is not known to be defined"
When building the current version of notmuch on debian testing/unstable, i see the following warning: ``` EMACS emacs/notmuch-crypto.elc In end of data: emacs/notmuch-crypto.el:266:1:Warning: the function ‘notmuch-show-get-message-id’ is not known to be defined. ``` No part of the test suite fails so i assume it's not a problem, but having spurious warnings makes it harder to notice real warnings in the future. I don't know what the warning means exactly, but maybe someone who is better with elisp than i am could take a look at it and try to resolve it? thanks, --dkg signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
