Re: test suite: FIXED messages are misordered with tests

2020-05-21 Thread Daniel Kahn Gillmor
On Fri 2020-05-22 00:57:14 +0300, Tomi Ollila wrote: > We've accumulated quite a bit of mess during these years to the test > system, which makes it harder to do larger adjustments (and not (yet) > mentioning even larger refactorings...). The last significant refactoring was probably when

Re: test suite: FIXED messages are misordered with tests

2020-05-21 Thread Tomi Ollila
On Thu, May 21 2020, Daniel Kahn Gillmor wrote: > On Thu 2020-05-21 00:16:48 +0300, Tomi Ollila wrote: >> (just tested this latest works) > > Thanks for looking into this, Tomi! > > Do you have a patch to propose? Looked a bit (now). Somewhat complicated to make perfect (enemy of good) change.

Re: test suite: FIXED messages are misordered with tests

2020-05-21 Thread Daniel Kahn Gillmor
On Thu 2020-05-21 00:16:48 +0300, Tomi Ollila wrote: > (just tested this latest works) Thanks for looking into this, Tomi! Do you have a patch to propose? --dkg signature.asc Description: PGP signature ___ notmuch mailing list

Re: test suite: FIXED messages are misordered with tests

2020-05-20 Thread Tomi Ollila
On Thu, May 21 2020, Tomi Ollila wrote: > > the message that prints FIXED, does not execute print_test_description > but the ones that do BROKEN or FAIL does (did not fully check but yes). > > And: > > print_test_description () > { > test -z "$test_description_printed" || return 0

Re: test suite: FIXED messages are misordered with tests

2020-05-20 Thread Tomi Ollila
On Tue, May 12 2020, Daniel Kahn Gillmor wrote: > I'm debugging/diagnosing/trying to clean up some "FIXED" known-broken > tests right now. > > Sometimes, depending on circumstances i can't predict (race > conditions?), I see funny output like: > > ~~~ > Use "make V=1" to see the details for

Re: test suite: FIXED messages are misordered with tests

2020-05-19 Thread Daniel Kahn Gillmor
On Tue 2020-05-12 20:14:07 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: >> >> Clearly, that FIXED should come *after* the "T356-protected-headers:" >> separator. >> > > Can you reproduce this without running the tests in parallel? Yep: I've seen the misordered output when using

Re: test suite: FIXED messages are misordered with tests

2020-05-12 Thread David Bremner
Daniel Kahn Gillmor writes: > > Clearly, that FIXED should come *after* the "T356-protected-headers:" > separator. > Can you reproduce this without running the tests in parallel? d ___ notmuch mailing list notmuch@notmuchmail.org

test suite: FIXED messages are misordered with tests

2020-05-12 Thread Daniel Kahn Gillmor
I'm debugging/diagnosing/trying to clean up some "FIXED" known-broken tests right now. Sometimes, depending on circumstances i can't predict (race conditions?), I see funny output like: ~~~ Use "make V=1" to see the details for passing and known broken tests. INFO: using 2m timeout for tests