[Nouveau] [PATCH] drm/nouveau: Grab runtime PM ref in nv50_mstc_detect()

2018-09-14 Thread Lyude Paul
While we currently grab a runtime PM ref in nouveau's normal connector detection code, we apparently don't do this for MST. This means if we're in a scenario where the GPU is suspended and userspace attempts to do a connector probe on an MSTC connector, the probe will fail entirely due to the DP

[Nouveau] [PATCH] drm: nouveau: use match_string() helper to simplify the code

2018-09-14 Thread zhong jiang
match_string() returns the index of an array for a matching string, which can be used intead of open coded implementation. Signed-off-by: zhong jiang --- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git

Re: [Nouveau] [PATCH 1/2] drm/nouveau: Disable atomic support on a per-device basis

2018-09-14 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 05:02:05PM -0400, Lyude Paul wrote: > Hm, one nitpick here. Since /sys/kernel/debug/dri/*/state creation depends on > the driver supporting atomic, maybe it would be good to make it so that we set > DRIVER_ATOMIC in the driver_stub structure, then disable it per-device >

Re: [Nouveau] [PATCH] drm/nouveau: Don't disable polling in fallback mode

2018-09-14 Thread Martin Peres
On 14/09/2018 10:28, Ben Skeggs wrote: > On Wed, 12 Sep 2018 at 20:59, Takashi Iwai wrote: >> >> When a fan is controlled via linear fallback without cstate, we >> shouldn't stop polling. Otherwise it won't be adjusted again and >> keeps running at an initial crazy pace. > Martin, > > Any

Re: [Nouveau] [PATCH] drm/nouveau/secboot/acr: fix memory leak

2018-09-14 Thread Ben Skeggs
On Fri, 14 Sep 2018 at 07:35, Kees Cook wrote: > > On Fri, Sep 7, 2018 at 8:02 PM, John Hubbard wrote: > > On 8/2/18 12:51 PM, Gustavo A. R. Silva wrote: > >> Hi all, > >> > >> Friendly ping! Who can take this? > >> > >> Thanks > >> -- > >> Gustavo > >> > >> On 07/24/2018 08:27 AM, Gustavo A. R.

Re: [Nouveau] [PATCH 1/2] drm/nouveau: Disable atomic support on a per-device basis

2018-09-14 Thread kbuild test robot
/commits/Ville-Syrjala/drm-nouveau-Disable-atomic-support-on-a-per-device-basis/20180914-111059 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones

Re: [Nouveau] [PATCH 1/2] drm/nouveau: Disable atomic support on a per-device basis

2018-09-14 Thread Daniel Vetter
On Thu, Sep 13, 2018 at 11:02 PM, Lyude Paul wrote: > Hm, one nitpick here. Since /sys/kernel/debug/dri/*/state creation depends on > the driver supporting atomic, maybe it would be good to make it so that we set > DRIVER_ATOMIC in the driver_stub structure, then disable it per-device >

Re: [Nouveau] [PATCH] drm/nouveau: Don't disable polling in fallback mode

2018-09-14 Thread Ben Skeggs
On Wed, 12 Sep 2018 at 20:59, Takashi Iwai wrote: > > When a fan is controlled via linear fallback without cstate, we > shouldn't stop polling. Otherwise it won't be adjusted again and > keeps running at an initial crazy pace. Martin, Any thoughts on this? Ben. > > Fixes: 800efb4c2857