[Nouveau] [PATCH] drm/nouveau/mmu: use struct_size() helper

2019-05-24 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, replace the following form: sizeof(*kind) + sizeof(*kind->data) * mmu->kind_nr; with: struct_size(kind, data, m

Re: [Nouveau] [RFC][PATCH] kernel.h: Add generic roundup_64() macro

2019-05-24 Thread Steven Rostedt
On Fri, 24 May 2019 19:30:45 +0300 Nikolay Borisov wrote: > > Yes I do. I corrected it in my next email. > > > > http://lkml.kernel.org/r/20190523133648.591f9...@gandalf.local.home > > Or perhaps just using is_power_of_2 from include/linux/log2.h ? Even better. Thanks, -- Steve

[Nouveau] [Bug 110748] [NVC1] [optimus] fifo: read fault at 0000000000 engine 00 [PGRAPH] client 00 [] reason 02 [PAGE_NOT_PRESENT]

2019-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110748 --- Comment #3 from Dominik 'Rathann' Mierzejewski --- With mplayer -vo vdpau -vc ffh264vdpau I don't get a corrupted video, but I get the same errors as with mpv --vo=vdpau --hwdec=vdpau kernel-5.0.16-300.fc30.x86_64 libdrm-2.4.98-1.fc30.x86_64

Re: [Nouveau] [RFC][PATCH] kernel.h: Add generic roundup_64() macro

2019-05-24 Thread Steven Rostedt
On Fri, 24 May 2019 16:11:14 +0100 Roger Willcocks wrote: > On 23/05/2019 16:27, Steven Rostedt wrote: > > > > I haven't yet tested this, but what about something like the following: > > > > ...perhaps forget about the constant check, and just force > > the power of two check: > > > >

Re: [Nouveau] [PATCH 2/2] drm/nouveau: remove open-coded drm_invalid_op()

2019-05-24 Thread Emil Velikov
On 2019/05/23, Ben Skeggs wrote: > On Thu, 23 May 2019 at 01:03, Emil Velikov wrote: > > > > From: Emil Velikov > > > > Cc: Ben Skeggs > > Cc: nouveau@lists.freedesktop.org > > Signed-off-by: Emil Velikov > Thanks! > Forgot to mention, any objections if I take this through drm-misc? I'm about

[Nouveau] [Bug 110572] Regularly System Crash: (ca. 1 hour) nouveau 0000:08:00.0: gr: PGRAPH TLB flush idle timeout fail and nouveau 0000:08:00.0: mmu: ce0 mmu invalidate timeout

2019-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110572 --- Comment #16 from Linux Freak --- Created attachment 144339 --> https://bugs.freedesktop.org/attachment.cgi?id=144339&action=edit crash 10 Mai 19 15:13:49 kernel: nouveau :08:00.0: mmu: ce0 mmu invalidate timeout Mai 19 15:13:53 kern