Re: [Nouveau] unstable refresh rate

2019-08-06 Thread Ilia Mirkin
That's OK - nouveau doesn't let you pick bit depth either (yet). It's all 8bpc - higher bpc mode support will come ... eventually. On Tue, Aug 6, 2019 at 5:25 PM James wrote: > > I think I may have updated the tv firmware between when it worked and > when it didn't. > I wonder it it has to do

Re: [Nouveau] unstable refresh rate

2019-08-06 Thread James
I think I may have updated the tv firmware between when it worked and when it didn't. I wonder it it has to do with bit depth. I use lubuntu and it doesn't let me pick the bit depth so I don't know what it using. ___ Nouveau mailing list

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 02:58:58PM -0400, Alex Deucher wrote: > On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote: > > > > On 2019-08-06 13:44, Jason Gunthorpe wrote: > > > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > > >> The option is just used to select HMM mirror

Re: [Nouveau] unstable refresh rate

2019-08-06 Thread James Lockie
On August 6, 2019 1:36:09 p.m. Ilia Mirkin wrote: Can you try something very simple - unplug the cable, and plug it back in, while the TV is on, and set to the HDMI input? I still only get 30Hz. I did just update the tv firmware s9 maybe that is why I can't get it 60Hz anymore. I wish I

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Alex Deucher
On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote: > > On 2019-08-06 13:44, Jason Gunthorpe wrote: > > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > >> The option is just used to select HMM mirror support and has a very > >> confusing help text. Just pull in the HMM

Re: [PATCH 03/15] nouveau: pass struct nouveau_svmm to nouveau_range_fault

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:41PM +0300, Christoph Hellwig wrote: > We'll need the nouveau_svmm structure to improve the function soon. > For now this allows using the svmm->mm reference to unlock the > mmap_sem, and thus the same dereference chain that the caller uses > to lock and unlock it. >

Re: [PATCH 08/15] mm: remove the mask variable in hmm_vma_walk_hugetlb_entry

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:46PM +0300, Christoph Hellwig wrote: > The pagewalk code already passes the value as the hmask parameter. > > Signed-off-by: Christoph Hellwig > mm/hmm.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [Nouveau] [PATCH 11/15] mm: cleanup the hmm_vma_handle_pmd stub

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:49PM +0300, Christoph Hellwig wrote: > Stub out the whole function when CONFIG_TRANSPARENT_HUGEPAGE is not set > to make the function easier to read. > > Signed-off-by: Christoph Hellwig > --- > mm/hmm.c | 18 -- > 1 file changed, 8 insertions(+),

Re: [Nouveau] [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Kuehling, Felix
On 2019-08-06 13:44, Jason Gunthorpe wrote: > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: >> The option is just used to select HMM mirror support and has a very >> confusing help text. Just pull in the HMM mirror code by default >> instead. >> >> Signed-off-by: Christoph

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > The option is just used to select HMM mirror support and has a very > confusing help text. Just pull in the HMM mirror code by default > instead. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/Kconfig

Re: [PATCH 14/15] mm: make HMM_MIRROR an implicit option

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:52PM +0300, Christoph Hellwig wrote: > Make HMM_MIRROR an option that is selected by drivers wanting to use it > instead of a user visible option as it is just a low-level > implementation detail. > > Signed-off-by: Christoph Hellwig > --- >

Re: [Nouveau] unstable refresh rate

2019-08-06 Thread Ilia Mirkin
Can you try something very simple - unplug the cable, and plug it back in, while the TV is on, and set to the HDMI input? That should ensure that the SCDC write can go through at modeset time. You can also force nouveau to avoid any modes that require scrambling by booting with

Re: [Nouveau] unstable refresh rate

2019-08-06 Thread James
I was going to buy a new cable and I came across this description: >Category 2 Certified HDMI wire supports resolutions up to 4Kx2K (UHD) @30 Hz https://www.cnet.com/how-to/what-is-hdmi-2-0b/ HDMI versions compared HDMI VersionMax Resolution Max 4K Frame rate HDCP 2.2HDR

Re: [Nouveau] unstable refresh rate

2019-08-06 Thread James
On 2019-08-06 12:32 p.m., Ilia Mirkin wrote: Hi James, I semi-recently added support for HDMI 2.0 (in 4.20+, so you're good), which is why you got 60Hz in the first place. In order for the high rates to work, something called "scrambling" must be enabled. This is done by 2-party agreement

Re: [Nouveau] unstable refresh rate

2019-08-06 Thread Ilia Mirkin
Hi James, I semi-recently added support for HDMI 2.0 (in 4.20+, so you're good), which is why you got 60Hz in the first place. In order for the high rates to work, something called "scrambling" must be enabled. This is done by 2-party agreement between the sink and the source. The sink will

[Nouveau] unstable refresh rate

2019-08-06 Thread James
I have a Gigabyte GeForce 1050 connected by DVI to a monitor (1920x1200 resolution @ 59.9502 Hz) and a TV via HDMI (3840x2160 @30 Hz). The problem is the TV used to work at 59.9685 Hz but then it started showing "No signal" on the TV. I was changing settings trying to get it to work again and I

[Nouveau] [PATCH 14/15] mm: make HMM_MIRROR an implicit option

2019-08-06 Thread Christoph Hellwig
Make HMM_MIRROR an option that is selected by drivers wanting to use it instead of a user visible option as it is just a low-level implementation detail. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +++- drivers/gpu/drm/nouveau/Kconfig| 4 +++- mm/Kconfig

[PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Christoph Hellwig
The option is just used to select HMM mirror support and has a very confusing help text. Just pull in the HMM mirror code by default instead. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/Kconfig | 2 ++ drivers/gpu/drm/amd/amdgpu/Kconfig | 10 --

[Nouveau] [PATCH 11/15] mm: cleanup the hmm_vma_handle_pmd stub

2019-08-06 Thread Christoph Hellwig
Stub out the whole function when CONFIG_TRANSPARENT_HUGEPAGE is not set to make the function easier to read. Signed-off-by: Christoph Hellwig --- mm/hmm.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index 5e7afe685213..4aa7135f1094

[Nouveau] [PATCH 13/15] mm: allow HMM_MIRROR on all architectures with MMU

2019-08-06 Thread Christoph Hellwig
There isn't really any architecture specific code in this page table walk implementation, so drop the dependencies. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe --- mm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/Kconfig b/mm/Kconfig index

[PATCH 12/15] mm: cleanup the hmm_vma_walk_hugetlb_entry stub

2019-08-06 Thread Christoph Hellwig
Stub out the whole function and assign NULL to the .hugetlb_entry method if CONFIG_HUGETLB_PAGE is not set, as the method won't ever be called in that case. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe --- mm/hmm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 10/15] mm: only define hmm_vma_walk_pud if needed

2019-08-06 Thread Christoph Hellwig
We only need the special pud_entry walker if PUD-sized hugepages and pte mappings are supported, else the common pagewalk code will take care of the iteration. Not implementing this callback reduced the amount of code compiled for non-x86 platforms, and also fixes compile failures with other

[PATCH 08/15] mm: remove the mask variable in hmm_vma_walk_hugetlb_entry

2019-08-06 Thread Christoph Hellwig
The pagewalk code already passes the value as the hmask parameter. Signed-off-by: Christoph Hellwig --- mm/hmm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index f26d6abc4ed2..03d37e102e3b 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -771,19

[PATCH 01/15] amdgpu: remove -EAGAIN handling for hmm_range_fault

2019-08-06 Thread Christoph Hellwig
hmm_range_fault can only return -EAGAIN if called with the HMM_FAULT_ALLOW_RETRY flag, which amdgpu never does. Remove the handling for the -EAGAIN case with its non-standard locking scheme. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe Reviewed-by: Felix Kuehling ---

[PATCH 06/15] mm: remove superflous arguments from hmm_range_register

2019-08-06 Thread Christoph Hellwig
The start, end and page_shift values are all saved in the range structure, so we might as well use that for argument passing. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe Reviewed-by: Felix Kuehling --- Documentation/vm/hmm.rst| 2 +-

[Nouveau] [PATCH 07/15] mm: remove the page_shift member from struct hmm_range

2019-08-06 Thread Christoph Hellwig
All users pass PAGE_SIZE here, and if we wanted to support single entries for huge pages we should really just add a HMM_FAULT_HUGEPAGE flag instead that uses the huge page size instead of having the caller calculate that size once, just for the hmm code to verify it. Signed-off-by: Christoph

[Nouveau] [PATCH 09/15] mm: don't abuse pte_index() in hmm_vma_handle_pmd

2019-08-06 Thread Christoph Hellwig
pte_index is an internal arch helper in various architectures, without consistent semantics. Open code that calculation of a PMD index based on the virtual address instead. Signed-off-by: Christoph Hellwig --- mm/hmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 05/15] mm: remove the unused vma argument to hmm_range_dma_unmap

2019-08-06 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe --- include/linux/hmm.h | 1 - mm/hmm.c| 2 -- 2 files changed, 3 deletions(-) diff --git a/include/linux/hmm.h b/include/linux/hmm.h index 82265118d94a..59be0aa2476d 100644 --- a/include/linux/hmm.h +++

[Nouveau] [PATCH 04/15] mm: remove the pgmap field from struct hmm_vma_walk

2019-08-06 Thread Christoph Hellwig
There is only a single place where the pgmap is passed over a function call, so replace it with local variables in the places where we deal with the pgmap. Signed-off-by: Christoph Hellwig --- mm/hmm.c | 62 1 file changed, 27

[PATCH 03/15] nouveau: pass struct nouveau_svmm to nouveau_range_fault

2019-08-06 Thread Christoph Hellwig
We'll need the nouveau_svmm structure to improve the function soon. For now this allows using the svmm->mm reference to unlock the mmap_sem, and thus the same dereference chain that the caller uses to lock and unlock it. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/nouveau/nouveau_svm.c

[PATCH 02/15] amdgpu: don't initialize range->list in amdgpu_hmm_init_range

2019-08-06 Thread Christoph Hellwig
The list is used to add the range to another list as an entry in the core hmm code, and intended as a private member not exposed to drivers. There is no need to initialize it in a driver. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe Reviewed-by: Felix Kuehling ---

[Nouveau] hmm cleanups, v2

2019-08-06 Thread Christoph Hellwig
Hi Jérôme, Ben, Felix and Jason, below is a series against the hmm tree which cleans up various minor bits and allows HMM_MIRROR to be built on all architectures. Diffstat: 11 files changed, 94 insertions(+), 210 deletions(-) A git tree is also available at:

Re: [Nouveau] [PATCH 2/2] drm/nouveau: remove open-coded drm_invalid_op()

2019-08-06 Thread Emil Velikov
Hi Ben, On Thu, 23 May 2019 at 01:19, Ben Skeggs wrote: > > On Thu, 23 May 2019 at 01:03, Emil Velikov wrote: > > > > From: Emil Velikov > > > > Cc: Ben Skeggs > > Cc: nouveau@lists.freedesktop.org > > Signed-off-by: Emil Velikov > Thanks! > Sadly Dave reverted this, since the thanks wasn't