Re: [Nouveau] [PATCH v11 00/10] Add support for SVM atomics in Nouveau

2021-06-16 Thread Alistair Popple
On Thursday, 17 June 2021 9:35:29 AM AEST Andrew Morton wrote: > On Wed, 16 Jun 2021 20:59:27 +1000 Alistair Popple wrote: > > > This is my series to add support for SVM atomics in Nouveau > > Can we please have a nice [0/n] overview for this patchset? > Sorry, I forgot to include that this

[Nouveau] Update: [PATCH v11 00/10] Add support for SVM atomics in Nouveau

2021-06-16 Thread Alistair Popple
Introduction Some devices have features such as atomic PTE bits that can be used to implement atomic access to system memory. To support atomic operations to a shared virtual memory page such a device needs access to that page which is exclusive of the CPU. This series introduces a

Re: [Nouveau] [PATCH v11 00/10] Add support for SVM atomics in Nouveau

2021-06-16 Thread Andrew Morton
On Wed, 16 Jun 2021 20:59:27 +1000 Alistair Popple wrote: > This is my series to add support for SVM atomics in Nouveau Can we please have a nice [0/n] overview for this patchset? ___ Nouveau mailing list Nouveau@lists.freedesktop.org

[Nouveau] [PATCH v11 10/10] nouveau/svm: Implement atomic SVM access

2021-06-16 Thread Alistair Popple
Some NVIDIA GPUs do not support direct atomic access to system memory via PCIe. Instead this must be emulated by granting the GPU exclusive access to the memory. This is achieved by replacing CPU page table entries with special swap entries that fault on userspace access. The driver then grants

[Nouveau] [PATCH v11 09/10] nouveau/svm: Refactor nouveau_range_fault

2021-06-16 Thread Alistair Popple
Call mmu_interval_notifier_insert() as part of nouveau_range_fault(). This doesn't introduce any functional change but makes it easier for a subsequent patch to alter the behaviour of nouveau_range_fault() to support GPU atomic operations. Signed-off-by: Alistair Popple Reviewed-by: Ben Skeggs

[Nouveau] [PATCH v11 08/10] mm: Selftests for exclusive device memory

2021-06-16 Thread Alistair Popple
Adds some selftests for exclusive device memory. Signed-off-by: Alistair Popple Acked-by: Jason Gunthorpe Tested-by: Ralph Campbell Reviewed-by: Ralph Campbell --- v10: * Squashed a fix from Colin King. Not sure what the right attribution tag for that would be though? --- lib/test_hmm.c

[Nouveau] [PATCH v11 07/10] mm: Device exclusive memory access

2021-06-16 Thread Alistair Popple
Some devices require exclusive write access to shared virtual memory (SVM) ranges to perform atomic operations on that memory. This requires CPU page tables to be updated to deny access whilst atomic operations are occurring. In order to do this introduce a new swap entry type

[Nouveau] [PATCH v11 06/10] mm/memory.c: Allow different return codes for copy_nonpresent_pte()

2021-06-16 Thread Alistair Popple
Currently if copy_nonpresent_pte() returns a non-zero value it is assumed to be a swap entry which requires further processing outside the loop in copy_pte_range() after dropping locks. This prevents other values being returned to signal conditions such as failure which a subsequent change

[Nouveau] [PATCH v11 05/10] mm: Rename migrate_pgmap_owner

2021-06-16 Thread Alistair Popple
MMU notifier ranges have a migrate_pgmap_owner field which is used by drivers to store a pointer. This is subsequently used by the driver callback to filter MMU_NOTIFY_MIGRATE events. Other notifier event types can also benefit from this filtering, so rename the 'migrate_pgmap_owner' field to

[Nouveau] [PATCH v11 04/10] mm/rmap: Split migration into its own function

2021-06-16 Thread Alistair Popple
Migration is currently implemented as a mode of operation for try_to_unmap_one() generally specified by passing the TTU_MIGRATION flag or in the case of splitting a huge anonymous page TTU_SPLIT_FREEZE. However it does not have much in common with the rest of the unmap functionality of

[Nouveau] [PATCH v11 02/10] mm/swapops: Rework swap entry manipulation code

2021-06-16 Thread Alistair Popple
Both migration and device private pages use special swap entries that are manipluated by a range of inline functions. The arguments to these are somewhat inconsitent so rework them to remove flag type arguments and to make the arguments similar for both read and write entry creation.

[Nouveau] [PATCH v11 03/10] mm/rmap: Split try_to_munlock from try_to_unmap

2021-06-16 Thread Alistair Popple
The behaviour of try_to_unmap_one() is difficult to follow because it performs different operations based on a fairly large set of flags used in different combinations. TTU_MUNLOCK is one such flag. However it is exclusively used by try_to_munlock() which specifies no other flags. Therefore

[Nouveau] [PATCH v11 01/10] mm: Remove special swap entry functions

2021-06-16 Thread Alistair Popple
Remove multiple similar inline functions for dealing with different types of special swap entries. Both migration and device private swap entries use the swap offset to store a pfn. Instead of multiple inline functions to obtain a struct page for each swap entry type use a common function

[Nouveau] [PATCH v11 00/10] Add support for SVM atomics in Nouveau

2021-06-16 Thread Alistair Popple
Hi Andrew, This is my series to add support for SVM atomics in Nouveau rebased onto v5.13-rc6-mmots-2021-06-15-20-28. Functionally there are no changes from the previous v10, however some changes were made during the rebase. If anyone would like to see a diff-of-diffs I can post it but my