Re: [Nouveau] [PATCH v7 6/8] PCI/VGA: Introduce is_boot_device function callback to vga_client_register

2023-06-21 Thread Sui Jingfeng
Hi, A nouveau developer(Lyude) from redhat send me a R-B, Thanks for the developers of nouveau project. Please allow me add a link[1] here. [1] https://lore.kernel.org/all/0afadc69f99a36bc9d03ecf54ff25859dbc10e28.ca...@redhat.com/ On 2023/6/13 11:01, Sui Jingfeng wrote: From: Sui

Re: [Nouveau] [PATCH v6 0/8] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-21 Thread Sui Jingfeng
Hi On 2023/6/22 06:11, Lyude Paul wrote: For the nouveau bits: Reviewed-by: Lyude Paul Thanks a lot On Tue, 2023-06-13 at 03:25 +0800, Sui Jingfeng wrote: From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, it's probably wrong if we simply remove the arch guard.

Re: [Nouveau] [PATCH] drm/nouveau/disp: use drm_kms_helper_connector_hotplug_event()

2023-06-21 Thread Simon Ser
Hi Lyude! On Wednesday, June 21st, 2023 at 23:56, Lyude Paul wrote: > > - if (changed) > > + if (changed == 1) > > + drm_kms_helper_connector_hotplug_event(first_changed_connector); > > + else if (changed > 0) > > drm_kms_helper_hotplug_event(dev); > > I'm curious

Re: [Nouveau] [PATCH v6 0/8] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-21 Thread Lyude Paul
For the nouveau bits: Reviewed-by: Lyude Paul On Tue, 2023-06-13 at 03:25 +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The vga_is_firmware_default() function is arch-dependent, it's probably > wrong if we simply remove the arch guard. As the VRAM BAR which contains > firmware

Re: [Nouveau] [PATCH] drm/nouveau/disp: use drm_kms_helper_connector_hotplug_event()

2023-06-21 Thread Lyude Paul
Looks alright! Some comments below On Tue, 2023-06-20 at 18:15 +, Simon Ser wrote: > This adds more information to the hotplug uevent and lets user-space > know that it's about a particular connector only. > > Signed-off-by: Simon Ser > Cc: Ben Skeggs > Cc: Lyude Paul > Cc: David Airlie

Re: [Nouveau] [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-21 Thread Donald Robson
Hi Danilo, One comment below, but otherwise it looks great. Thanks for adding the example! Thanks, Donald On Tue, 2023-06-20 at 02:42 +0200, Danilo Krummrich wrote: > > +/** > + * DOC: Overview > + * > + * The DRM GPU VA Manager, represented by struct drm_gpuva_manager keeps > track > + * of a

Re: [Nouveau] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-21 Thread Sui Jingfeng
Hi, On 2023/6/16 22:34, Alex Deucher wrote: On Fri, Jun 16, 2023 at 10:22 AM Sui Jingfeng wrote: On 2023/6/16 21:41, Alex Deucher wrote: On Fri, Jun 16, 2023 at 3:11 AM Sui Jingfeng wrote: Hi, On 2023/6/16 05:11, Alex Deucher wrote: On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng wrote: