Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Hamza Mahfooz wrote: > > On 8/24/23 08:07, Lee Jones wrote: > > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > > > On Thu, 24 Aug 2023, Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently

Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Maxime Ripard wrote: > Hi, > > On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote: > > On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly

Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Lee Jones wrote: > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > On Thu, 24 Aug 2023, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > > niggly little warnings. > >

Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Jani Nikula wrote: > On Thu, 24 Aug 2023, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > The next question is, how do we keep it W=1 clean

Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Maxime Ripard
On Thu, Aug 24, 2023 at 12:03:20PM +0300, Jani Nikula wrote: > On Thu, 24 Aug 2023, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > The next question is, how do

Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Jani Nikula
On Thu, 24 Aug 2023, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. The next question is, how do we keep it W=1 clean going forward? Most people don't use W=1 because

Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Maxime Ripard
Hi, On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote: > On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Cc:

Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Maxime Ripard
On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Cc: Alex Deucher > Cc: amd-...@lists.freedesktop.org > Cc: Ben Skeggs > Cc:

Re: [Nouveau] [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses

2023-08-24 Thread Karol Herbst
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts > with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst >

Re: [Nouveau] [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse

2023-08-24 Thread Karol Herbst
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment > starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > >

Re: [Nouveau] [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses

2023-08-24 Thread Karol Herbst
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment > starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst >

Re: [Nouveau] [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses

2023-08-24 Thread Karol Herbst
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function > parameter or member 'init' not described in 'init_reserved' > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611:

[Nouveau] [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with

[Nouveau] [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Signed-off-by: Lee Jones --- Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude

[Nouveau] [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was

[Nouveau] [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This

[Nouveau] [PATCH 02/20] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’: drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable] Signed-off-by: Lee

[Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Cc: Alex Deucher Cc: amd-...@lists.freedesktop.org Cc: Ben Skeggs Cc: "Christian König" Cc: Daniel Vetter Cc: Danilo Krummrich Cc: David