Am 19.09.23 um 17:23 schrieb Thomas Hellström:
On 9/19/23 17:16, Danilo Krummrich wrote:
On 9/19/23 14:21, Thomas Hellström wrote:
Hi Christian
On 9/19/23 14:07, Christian König wrote:
Am 13.09.23 um 17:46 schrieb Danilo Krummrich:
On 9/13/23 17:33, Christian König wrote:
Am 13.09.23 um
Hi,
On 2023/8/25 21:18, Deucher, Alexander wrote:
[Public]
-Original Message-
From: amd-gfx On Behalf Of Sui
Jingfeng
Sent: Friday, August 25, 2023 2:27 AM
To: Bjorn Helgaas
Cc: alsa-de...@alsa-project.org; Sui Jingfeng ;
nouveau@lists.freedesktop.org; linux-ker...@vger.kernel.org;
On 9/16/23 16:24, Dan Carpenter wrote:
On Sat, Sep 16, 2023 at 01:41:43AM +0200, Danilo Krummrich wrote:
Hi Dan,
On 9/15/23 14:59, Dan Carpenter wrote:
The u_memcpya() function is supposed to return error pointers on
error. Returning NULL will lead to an Oops.
Fixes: 68132cc6d1bc
From: Ben Skeggs
- nvkm should provide all this info now
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/nouveau_bios.c| 8 +---
drivers/gpu/drm/nouveau/nouveau_display.c | 8
From: Ben Skeggs
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 97 ++-
drivers/gpu/drm/nouveau/dispnv50/disp.h | 2 -
From: Ben Skeggs
- pre-nv5x doesn't use any of this
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
.../gpu/drm/nouveau/nvkm/engine/disp/base.c | 31 +++
From: Ben Skeggs
No need to go poking HW directly, and probably shouldn't on GSP-RM.
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 18 +++---
1 file changed, 3 insertions(+),
From: Ben Skeggs
We've never supported it.
Signed-off-by: Ben Skeggs
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c
From: Ben Skeggs
- removes use of VBIOS data for naming
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 25 -
1 file changed, 9
From: Ben Skeggs
- output info will be used later to determine MST support
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 64 -
1 file changed, 32 insertions(+), 32
From: Ben Skeggs
- pre-nv5x doesn't use any of this, has its own version DRM-side
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
.../gpu/drm/nouveau/nvkm/engine/disp/base.c | 117 +
From: Ben Skeggs
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 32 ---
drivers/gpu/drm/nouveau/dispnv50/head.h | 1 +
From: Ben Skeggs
This is presently unused on HW, we read a bunch of regs and calculate
the watermark during the second supervisor interrupt.
I don't want to change this yet as I need to re-remember how older HW
works exactly, but RM wants this info via RPC.
Signed-off-by: Ben Skeggs
From: Ben Skeggs
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/include/nvif/if0012.h | 11 ++
drivers/gpu/drm/nouveau/include/nvif/outp.h | 1 +
From: Ben Skeggs
- passes DPCD information from DRM to NVKM
- removes NVKM's own sink caps handling
- link still trained from supervisor, more patches to come
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
From: Ben Skeggs
- fixes bug preventing this on SST
- implement for MST
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 13 +++--
drivers/gpu/drm/nouveau/nouveau_dp.c | 15
From: Ben Skeggs
- fixes some issues tearing down modes on tiled displays
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 11 +--
drivers/gpu/drm/nouveau/dispnv50/disp.h | 1 -
2
From: Ben Skeggs
Link training can finally be moved out of the supervisor sequence,
but first we need to split DP modesets into separate disable and
enable sequences to be able to perform link training between them
instead.
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude
From: Ben Skeggs
- moves building of link rates table from NVKM to DRM
- preparing to move link training out of supervisor
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/include/nvif/if0012.h | 13 ++
From: Ben Skeggs
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 32 +--
drivers/gpu/drm/nouveau/include/nvif/if0012.h | 12 +++
From: Ben Skeggs
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/dp.c| 9 +
drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.h | 4
From: Ben Skeggs
This just adds a hook for RM to use, HW paths remain untouched, but
should probably be cleaned up to use this too at some point.
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
From: Ben Skeggs
- was previously part of acquire()
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
drivers/gpu/drm/nouveau/include/nvif/if0012.h| 16 ++--
From: Ben Skeggs
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/include/nvif/if0012.h | 17
drivers/gpu/drm/nouveau/include/nvif/outp.h | 3 +
From: Ben Skeggs
- these shouldn't be necessary now, and are done in acquire()/release()
- preparation for GSP-RM, where we don't control the supervisor
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
From: Ben Skeggs
Prior to this commit, KMS would call release() prior to modeset, and the
second supervisor interrupt would update SOR routing if needed.
Now, KMS will call release() post-modeset and update routing immediately.
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by:
From: Ben Skeggs
- release() is being moved post-modeset, preserve hdmi behaviour for now
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 8
From: Ben Skeggs
- was previously part of acquire()
- preparation for GSP-RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 ++---
drivers/gpu/drm/nouveau/include/nvif/if0012.h |
From: Ben Skeggs
- cleanup before additional changes
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 69 ---
drivers/gpu/drm/nouveau/nouveau_encoder.h | 2 +
2 files
From: Ben Skeggs
- we'll want this info post-UPDATE for later patches
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff
From: Ben Skeggs
- adds tracking for post-UPDATE modeset operations, similar to mst[mo]'s
- audio won't work on RM without this
- we should probably have been doing this anyway
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
From: Ben Skeggs
- use nv_encoder.conn instead, outp->conn never changes
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +---
drivers/gpu/drm/nouveau/nouveau_encoder.h | 1 -
2 files
From: Ben Skeggs
- was previously delayed until second supervisor interrupt
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/disp/uoutp.c |
From: Ben Skeggs
- preparing to move protocol-specific args out of acquire() again
- avoid re-acquiring acquired output, will matter when enforced later
- sor/pior done at same time due to shared tmds/dp handling
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
From: Ben Skeggs
- preparing to move protocol-specific args out of acquire() again
- avoid re-acquiring acquired output, will matter when enforced later
- this one is basically just a rename
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude
Now that we're supporting things like Ada and the GSP, there's situations
where we really need to actually know the display state that we're starting
with when loading the driver in order to prevent breaking GSP expectations.
The first step in doing this is making it so that we can read the
From: Ben Skeggs
- preparing to move protocol-specific args out of acquire() again
- no code changes
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/nvif/outp.c | 106 +-
From: Ben Skeggs
These will be made static later in the patch series, after the code that
uses them has been cleaned up in preparation for GSP-RM support.
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
From: Ben Skeggs
This will check the relevant hotplug pin and skip the DDC probe we
currently do if a display is present.
- preparation for GSP-RM.
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
From: Ben Skeggs
- needed to support TMDS EDID on RM
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/include/nvif/if0012.h | 10 +++
drivers/gpu/drm/nouveau/include/nvif/outp.h | 1 +
From: Ben Skeggs
Fixes some issues when running on top of RM.
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmtu102.c | 2 +-
2
From: Ben Skeggs
Programming -1 (vc_start_slot, if alloc fails) into HW probably isn't
the best idea.
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 +++---
1 file changed, 7
From: Ben Skeggs
- preparation for a bunch of API changes, to make diffs prettier
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/include/nvif/if0012.h | 19 +++
From: Ben Skeggs
Some of these buffers are quite large, and there's no need to preserve
them across suspend.
Mark the contents as lost to speedup suspend/resume.
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
From: Ben Skeggs
Will initially be used to tag some large grctx allocations which don't
need to be saved, to speedup suspend/resume.
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
.../drm/nouveau/include/nvkm/core/memory.h| 1
From: Ben Skeggs
>From Turing, HW will already have handled this and locked-down the
falcon before we get control. So this *should* be a no-op.
Signed-off-by: Ben Skeggs
Reviewed-by: Lyude Paul
Acked-by: Danilo Krummrich
Signed-off-by: Lyude Paul
---
Hey everyone! I'm just going through and rebasing Ben's display patches
so I can push them in just a moment :).
(*the rest of this email can be read in Ben Skegg's voice*)
The primary issue being tackled here is that, for historical reasons (we
didn't know any better / couldn't make it work
On 9/19/23 17:16, Danilo Krummrich wrote:
On 9/19/23 14:21, Thomas Hellström wrote:
Hi Christian
On 9/19/23 14:07, Christian König wrote:
Am 13.09.23 um 17:46 schrieb Danilo Krummrich:
On 9/13/23 17:33, Christian König wrote:
Am 13.09.23 um 17:15 schrieb Danilo Krummrich:
On 9/13/23
On 9/19/23 14:21, Thomas Hellström wrote:
Hi Christian
On 9/19/23 14:07, Christian König wrote:
Am 13.09.23 um 17:46 schrieb Danilo Krummrich:
On 9/13/23 17:33, Christian König wrote:
Am 13.09.23 um 17:15 schrieb Danilo Krummrich:
On 9/13/23 16:26, Christian König wrote:
Am 13.09.23 um
Hi Christian
On 9/19/23 14:07, Christian König wrote:
Am 13.09.23 um 17:46 schrieb Danilo Krummrich:
On 9/13/23 17:33, Christian König wrote:
Am 13.09.23 um 17:15 schrieb Danilo Krummrich:
On 9/13/23 16:26, Christian König wrote:
Am 13.09.23 um 14:16 schrieb Danilo Krummrich:
As mentioned
Am 13.09.23 um 17:46 schrieb Danilo Krummrich:
On 9/13/23 17:33, Christian König wrote:
Am 13.09.23 um 17:15 schrieb Danilo Krummrich:
On 9/13/23 16:26, Christian König wrote:
Am 13.09.23 um 14:16 schrieb Danilo Krummrich:
As mentioned in a different mail thread, the reply is based on the
51 matches
Mail list logo
