Re: [Nouveau] [PATCH] dispnv50: atom: fix an incorrect NULL check on list iterator

On Mon, 28 Mar 2022 at 03:09, Xiaomeng Tong wrote: > > on Sun, 27 Mar 2022 16:59:28 +0100, Emil Velikov wrote: > > On Sun, 27 Mar 2022 at 08:39, Xiaomeng Tong wrote: > > > > > > The bug is here: > > > return encoder; > > > > > &g

Re: [Nouveau] [PATCH] dispnv50: atom: fix an incorrect NULL check on list iterator

On Sun, 27 Mar 2022 at 08:39, Xiaomeng Tong wrote: > > The bug is here: > return encoder; > > The list iterator value 'encoder' will *always* be set and non-NULL > by drm_for_each_encoder_mask(), so it is incorrect to assume that the > iterator value will be NULL if the list is empty or

Re: [Nouveau] [PATCH] drm/nouveau: gr/gk20a: Use firmware version 0

: Thierry Reding Fixes: ef16dc278ec2 ("drm/nouveau/gr/gf100-: select implementation based on available FW") Reviewed-by: Emil Velikov -Emil ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [RFC] Remove AGP support from Radeon/Nouveau/TTM

On Tue, 12 May 2020 at 20:48, Alex Deucher wrote: > > >> > > >> There's some AGP support code in the DRM core. Can some of that declared > > >> as legacy? > > >> > > >> Specifically, what about these AGP-related ioctl calls? Can they be > > >> declared as legacy? It would appear to me that

Re: [Nouveau] [RFC] Remove AGP support from Radeon/Nouveau/TTM

On Mon, 11 May 2020 at 21:43, Dave Airlie wrote: > > On Tue, 12 May 2020 at 06:28, Alex Deucher wrote: > > > > On Mon, May 11, 2020 at 4:22 PM Al Dunsmuir > > wrote: > > > > > > On Monday, May 11, 2020, 1:17:19 PM, "Christian König" wrote: > > > > Hi guys, > > > > > > > Well let's face it AGP

Re: [Nouveau] [PATCH 1/3] drm: Add separate state structure for legacy, non-KMS drivers

Hi Thomas, On Tuesday, 25 February 2020, Thomas Zimmermann wrote: > Non-KMS drivers store state in struct drm_driver. This bloats the > structure for KMS drivers and prevents it from being declared with > 'static const' qualifiers. Moving the non-KMS state into a separate > data structure

Re: [Nouveau] [PATCH 04/12] drm: Nuke mode->vrefresh

be a completely separate patch. This patch is: Reviewed-by: Emil Velikov -Emil ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 2/2] drm/nouveau: remove open-coded drm_invalid_op()

Hi Ben, On Thu, 23 May 2019 at 01:19, Ben Skeggs wrote: > > On Thu, 23 May 2019 at 01:03, Emil Velikov wrote: > > > > From: Emil Velikov > > > > Cc: Ben Skeggs > > Cc: nouveau@lists.freedesktop.org > > Signed-off-by: Emil Velikov > Thanks! > S

Re: [Nouveau] [PATCH v2 5/6] drm/nouveau: utilize subconnector property for DP

dev); > struct nvkm_i2c_aux *aux; > u8 dpcd[8]; > + u8 port_cap[DP_MAX_DOWNSTREAM_PORTS] = {0}; IIRC clang will complain about {0}. How about we make this a {}. Regardless of the above nitpick, the series is: Reviewed-by: Emil Velikov Thanks for the follow-up :-) Emil ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH] drm/nouveau: fix bogus GPL-2 license header

d files, and most > are header files anyways. > All of my glorious 23 patches to nouveau are meant to be under MIT. Acked-by: Emil Velikov > Another change might be to add the SPDX identifier to files *with* > the MIT boilerplate, but I didn't want to do too

Re: [Nouveau] NOUVEAU_LEGACY_CTX_SUPPORT Fan Speed

Some weird interaction with disabling the i2c access, in the following patch perhaps? commit cd68344b283174a9b38e9488d5a929464e1f417c Author: Lyude Paul Date: Tue Apr 9 16:23:30 2019 -0400 drm/nouveau/i2c: Disable i2c bus access after ->fini() On Sun, 16 Jun 2019 at 15:28, Ilia Mirkin

Re: [PATCH 06/59] drm/prime: Actually remove DRIVER_PRIME everywhere

On 2019/06/14, Daniel Vetter wrote: > Split out to make the functional changes stick out more. > Since this patch flew-by, as standalone one (intentionally or not) I'd add, anything vaguely like: "Core users of DRIVER_PRIME were removed from core with prior patches." HTH Emil

Re: [Nouveau] [PATCH 08/13] drm/nouveau: drop DRM_AUTH from DRM_RENDER_ALLOW ioctls

On Mon, 27 May 2019 at 09:19, Emil Velikov wrote: > > From: Emil Velikov > > The authentication can be circumvented, by design, by using the render > node. > > From the driver POV there is no distinction between primary and render > nodes, thus we can drop the token. &

[Nouveau] [PATCH 08/13] drm/nouveau: drop DRM_AUTH from DRM_RENDER_ALLOW ioctls

From: Emil Velikov The authentication can be circumvented, by design, by using the render node. From the driver POV there is no distinction between primary and render nodes, thus we can drop the token. Note: the outstanding DRM_AUTH instance is: - legacy DRI1 ioctl, which is already neutered

Re: [Nouveau] [PATCH 2/2] drm/nouveau: remove open-coded drm_invalid_op()

On 2019/05/23, Ben Skeggs wrote: > On Thu, 23 May 2019 at 01:03, Emil Velikov wrote: > > > > From: Emil Velikov > > > > Cc: Ben Skeggs > > Cc: nouveau@lists.freedesktop.org > > Signed-off-by: Emil Velikov > Thanks! > Forgot to mention, any objectio

[Nouveau] [PATCH 2/2] drm/nouveau: remove open-coded drm_invalid_op()

From: Emil Velikov Cc: Ben Skeggs Cc: nouveau@lists.freedesktop.org Signed-off-by: Emil Velikov --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 6 -- drivers/gpu/drm/nouveau/nouveau_abi16.h | 1 - drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- 3 files changed, 1 insertion(+), 8 deletions

Re: [Nouveau] [Intel-gfx] [PATCH 26/26] drm/: Don't set FBINFO_(FLAG_)DEFAULT

On Thu, 24 Jan 2019 at 17:00, Daniel Vetter wrote: > > It's 0. > I'd add a bit more information here. Feel free to reuse as much/little of the following: Both macros evaluate to 0. At the same time flag is already set to zero since the struct is kzalloc'd in framebuffer_alloc(). As called by

Re: [Nouveau] [PATCH] drm/nouveau: remove redundant null check on array mstm->msto

On 17 August 2017 at 11:37, Colin King wrote: > From: Colin Ian King > > The check to see if mstm->msto is null is redundant because it is > an array and hence can never be null. Remove the redundant check. > > Detected by CoverityScan,

Re: [Nouveau] [Intel-gfx] [PATCH libdrm] drm: Remove create_handle() drm_framebuffer "virtual".

On 10 August 2017 at 20:29, Joe Kniss wrote: > On Wed, Aug 9, 2017 at 4:13 PM, Joe Kniss wrote: >> On Wed, Aug 9, 2017 at 12:14 PM, Noralf Trønnes wrote: >>> >>> Den 09.08.2017 01.42, skrev Joe Kniss: Because all drivers currently

Re: [Nouveau] [PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

rom drm.h to drm_mode.h > - Changed define prefix from DRM_ to DRM_MODE_PROP_ > - Updated uses of the defines to the new prefix > - Removed include from drm_rect.c > - Stopped using the BIT() macro > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> -Emil _

Re: [Nouveau] [PATCH] drm/nouveau/secboot: fix some error handling in 'ls_ucode_img_load_gr'

Hi Christophe, s/fix some error handling in 'ls_ucode_img_load_gr/plug memory leak in ls_ucode_img_load_gr() error path/ On 8 May 2017 at 08:46, Christophe JAILLET wrote: > The last goto looks spurious because it releases less resources than the > previous one. >

Re: [Nouveau] [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

On 23 February 2017 at 17:18, Joe Perches wrote: > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: >> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: >> > There are ~4300 uses of pr_warn and ~250 uses of the older >> > pr_warning in the kernel source

Re: [Nouveau] [v3 PATCH 0/3] Allow ASYNC flip with atomic helpers.

Hi Andrey, Unrelated suggestion: A handy trick - to save yourself a bit of time (and "get it right") you can use `git format-patch -vX ...' [it also works with send-email] to have the version in the subject prefix. Feel free to share it with the team - it seems that many people manually edit the

Re: [Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

On 8 November 2016 at 16:21, Karol Herbst wrote: > 2016-11-08 17:12 GMT+01:00 Arnd Bergmann : >> On Tuesday, November 8, 2016 5:07:01 PM CET Lukas Wunner wrote: >>> On Tue, Nov 08, 2016 at 04:52:49PM +0100, Arnd Bergmann wrote: >>> > The underlying problem is

Re: [Nouveau] [PATCH] gr: fallback to legacy paths during firmware lookup

Hi Alex, On 2 November 2016 at 04:54, Alexandre Courbot wrote: > + /* see if this firmware has a legacy path */ > + if (!strcmp(fwname, "fecs_inst")) > + legacy_fwname = "fuc409c"; > + else if (!strcmp(fwname, "fecs_data")) > +

Re: [Nouveau] [PATCH 1/5] hwdefs: update nvc0_3d, add gm107_texture for new TIC format

On 16 October 2016 at 20:14, Ilia Mirkin wrote: > These are copied directly from the mesa repository. > > Signed-off-by: Ilia Mirkin > --- > src/hwdefs/gm107_texture.xml.h | 365 + > src/hwdefs/nvc0_3d.xml.h | 867 >

Re: [Nouveau] [PATCH 2/2] nouveau: Fix compile error due to bad include

On 18 September 2016 at 11:21, Karol Herbst wrote: > Cought while working on travis-ci integration > > Signed-off-by: Karol Herbst > --- > drm/nouveau/uapi/drm/nouveau_drm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

On 24 August 2016 at 13:11, Martin Peres <martin.pe...@free.fr> wrote: > On 23/08/16 17:43, Emil Velikov wrote: >> >> On 23 August 2016 at 00:42, Martin Peres <martin.pe...@free.fr> wrote: >>> >>> v2: >>> - guard LED framework cal

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

On 23 August 2016 at 00:42, Martin Peres wrote: > v2: > - guard LED framework calls with ifdef CONFIG_LEDS_CLASS > IIRC kernel has the tendency of using static inlines in the headers when CONFIG_foo is not set. Worth using that and removing the ifdef from the source file ?

Re: [Nouveau] [Mesa-dev] nouveau_drv_video.so ?

Hi poma, Seems like you're missed your question. "nouveau_drv_video.so ?" does not mean much I'm afraid :-( On 30 June 2016 at 11:03, poma wrote: > On 30.06.2016 08:27, Xiang, Haihao wrote: >> >> >> Are you using VA-API on X11? libva gets the driver name from

Re: [Nouveau] [PATCH 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

On 30 May 2016 at 12:23, Peter Wu <pe...@lekensteyn.nl> wrote: > On Mon, May 30, 2016 at 11:48:34AM +0100, Emil Velikov wrote: >> On 27 May 2016 at 22:31, Peter Wu <pe...@lekensteyn.nl> wrote: >> > On Fri, May 27, 2016 at 02:01:39PM +0100, Emil Velikov wrote: >>

Re: [Nouveau] [PATCH 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

On 27 May 2016 at 22:31, Peter Wu <pe...@lekensteyn.nl> wrote: > On Fri, May 27, 2016 at 02:01:39PM +0100, Emil Velikov wrote: >> Hi Peter, >> >> On 24 May 2016 at 23:53, Peter Wu <pe...@lekensteyn.nl> wrote: >> > Since "PCI: Add runtime PM support

Re: [Nouveau] [PATCH 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

Hi Peter, On 24 May 2016 at 23:53, Peter Wu wrote: > Since "PCI: Add runtime PM support for PCIe ports", the parent PCIe port > can be runtime-suspended which disables power resources via ACPI. This > is incompatible with DSM, resulting in a GPU device which is still in D3 >

Re: [Nouveau] [PATCH v4] vga_switcheroo: Add helper for deferred probing

On 21 May 2016 at 15:08, Lukas Wunner <lu...@wunner.de> wrote: > Hi Emil, > > On Fri, May 20, 2016 at 12:41:04AM +0100, Emil Velikov wrote: >> On 19 May 2016 at 15:39, Lukas Wunner <lu...@wunner.de> wrote: >> > +bool vga_switcheroo_cli

Re: [Nouveau] [PATCH 1/5] headers_check: don't warn about c++ guards

to not warn about this. > I'm listing the merge commit as introducing the problem, because > there are several patches in this branch that each do this for > one file. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 7c10ddf87472 ("Merge branch 'drm-uapi

[Nouveau] [PATCH 23/24] drm/virgl: add extern C guard for the UAPI header

Cc: Dave Airlie <airl...@redhat.com> Cc: Gerd Hoffmann <kra...@redhat.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/virtgpu_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/virtgpu_drm.h b/include/uapi/drm/v

[Nouveau] [PATCH 15/24] drm/r128: add extern C guard for the UAPI header

Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/r128_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/r128_drm.h b/include/uapi/drm/r128_drm.h index 7a44c65..690e9c6 100644 --- a/include/uapi/drm/r128_drm.h +++ b/include/ua

[Nouveau] [PATCH 12/24] drm/omap: add extern C guard for the UAPI header

Cc: Tomi Valkeinen <tomi.valkei...@ti.com> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/omap_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/omap_drm.h

[Nouveau] [PATCH 17/24] drm/savage: add extern C guard for the UAPI header

Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/savage_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/savage_drm.h b/include/uapi/drm/savage_drm.h index 5741474..0f6edde 100644 --- a/include/uapi/drm/savage_drm.h +++ b/includ

[Nouveau] [PATCH 10/24] drm/nouveau: add extern C guard for the UAPI header

Cc: Ben Skeggs <bske...@redhat.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/nouveau_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/nouveau_drm.h b/include/uapi/drm/nouveau_drm.h index 500d82a..8d2dc05 100644 -

[Nouveau] [PATCH 04/24] drm/etnaviv: add extern C guard for the UAPI header

Cc: Christian Gmeiner <christian.gmei...@gmail.com> Cc: Russell King <rmk+ker...@arm.linux.org.uk> Cc: Lucas Stach <l.st...@pengutronix.de> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/etnaviv_drm.h | 8 1 file changed, 8 insertions(

[Nouveau] [PATCH 11/24] drm/nouveau: drop drm/ prefix from include

Similar to the rest of the DRM UAPI - these are to be imported unmodified into libdrm. In current form that's impossible. Cc: Ben Skeggs <bske...@redhat.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/nouveau_drm.h | 2 +- 1 file changed, 1 ins

[Nouveau] [PATCH 07/24] drm/i915: add extern C guard for the UAPI header

Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/i915_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/i915_drm.h b/include/u

[Nouveau] [PATCH 06/24] drm/i810: add extern C guard for the UAPI header

Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- Daniel, Based on earlier chat that his file has never been used by userspace, should we just move it for internal usage (to include/drm) ? Regards, Emil --- include/uapi/drm/i8

[Nouveau] [PATCH 16/24] drm/radeon: add extern C guard for the UAPI header

Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: Christian König <christian.koe...@amd.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/radeon_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/radeon_drm.h

[Nouveau] [PATCH 21/24] drm/vc4: add extern C guard for the UAPI header

Cc: Eric Anholt <e...@anholt.net> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/vc4_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/vc4_drm.h b/include/uapi/drm/vc4_drm.h index eeb37e3..af12e8a 100644 --- a/incl

[Nouveau] [PATCH 14/24] drm/qxl: remove XXX comment from the UAPI header

One cannot rename the struct at this point, so might as well remove the comment. Cc: Gerd Hoffmann <kra...@redhat.com> Cc: Dave Airlie <airl...@redhat.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/qxl_drm.h | 1 - 1 file changed, 1 delet

[Nouveau] [PATCH 18/24] drm/sis: add extern C guard for the UAPI header

Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/sis_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/sis_drm.h b/include/uapi/drm/sis_drm.h index 374858c..3f7d8ca 100644 --- a/include/uapi/drm/sis_drm.h +++ b/include/uapi/drm/sis

[Nouveau] [PATCH 08/24] drm/mga: add extern C guard for the UAPI header

Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/mga_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/mga_drm.h b/include/uapi/drm/mga_drm.h index fca8170..8c43375 100644 --- a/include/uapi/drm/mga_drm.h +++ b/include/uapi/drm/mga

[Nouveau] [PATCH 19/24] drm/sis: add missing include drm.h for the UAPI header

Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/sis_drm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/drm/sis_drm.h b/include/uapi/drm/sis_drm.h index 3f7d8ca..3e3f7e9 100644 --- a/include/uapi/drm/sis_drm.h +++ b/include/uapi/drm/sis

[Nouveau] [PATCH 22/24] drm/via: add extern C guard for the UAPI header

Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/via_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/via_drm.h b/include/uapi/drm/via_drm.h index fa21ed1..a1e125d 100644 --- a/include/uapi/drm/via_drm.h +++ b/include/uapi/drm/via

[Nouveau] [PATCH 03/24] drm: add extern C guard for the UAPI headers

Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/drm.h| 16 include/uapi/drm/drm_fourcc.h | 8 include/uapi/drm/drm_mode.h | 8 include/uapi/drm/drm_sarea.h | 8 4 files changed, 40 insertions(+) diff

[Nouveau] [PATCH 24/24] drm/vmwgfx: add extern C guard for the UAPI header

Cc: Sinclair Yeh <s...@vmware.com> Cc: Thomas Hellstrom <thellst...@vmware.com> Cc: Brian Paul <bri...@vmware.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/vmwgfx_drm.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include

[Nouveau] [PATCH 09/24] drm/msm: add extern C guard for the UAPI header

Cc: Rob Clark <robdcl...@gmail.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/msm_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/msm_drm.h b/include/uapi/drm/msm_drm.h index 254d3e9..bf19d2c 100644 --- a/incl

[Nouveau] [PATCH 05/24] drm/exynos: add extern C guard for the UAPI header

Cc: Andrzej Hajda <a.ha...@samsung.com> Cc: Inki Dae <inki@samsung.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- Inki, Can we please have someone from the Exynos/Samsung look into the following: - A follow up on patch cbf0aceff85 "drm/exynos: use

[Nouveau] [PATCH 02/24] drm/armada: add extern C guard for the UAPI header

Cc: Russell King <rmk+ker...@arm.linux.org.uk> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/armada_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/armada_drm.h b/include/uapi/drm/armada_drm.h index 6de7f01..72

[Nouveau] [PATCH 20/24] drm/tegra: add extern C guard for the UAPI header

Cc: Erik Faye-Lund <kusmab...@gmail.com> Cc: Thierry Reding <thierry.red...@gmail.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/tegra_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/tegra_drm.h b/include/ua

[Nouveau] [PATCH 13/24] drm/qxl: add extern C guard for the UAPI header

Cc: Gerd Hoffmann <kra...@redhat.com> Cc: Dave Airlie <airl...@redhat.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/qxl_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/qxl_drm.h b/include/uapi/drm/qxl_d

[Nouveau] [PATCH 01/24] drm/amdgpu: add extern C guard for the UAPI header

Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: Christian König <christian.koe...@amd.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- include/uapi/drm/amdgpu_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/drm/amdgpu_drm.h

Re: [Nouveau] nouveau contributor dinner Friday evening before FOSDEM?

Hi Hans, On 28 January 2016 at 12:31, Hans de Goede wrote: > Hi All, > > On 21-01-16 14:09, Hans de Goede wrote: >> >> Hi All, >> >> $subject says it pretty much all. AFAIk quite a few >> nouveau contributors are coming to Fosdem, and I think it >> would be nice to have

Re: [Nouveau] [PATCH 1/5] core: add firmware handling functions

On 25 January 2016 at 02:11, Alexandre Courbot <gnu...@gmail.com> wrote: > On Thu, Jan 21, 2016 at 8:41 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> Hi Alexandre, >> >> On 18 January 2016 at 06:07, Alexandre Courbot <acour...@nvidia.com> wrot

Re: [Nouveau] [PATCH v2 2/5] core: add support for secure boot

On 21 January 2016 at 12:13, Ben Skeggs <skeg...@gmail.com> wrote: > On 01/21/2016 10:09 PM, Emil Velikov wrote: >> Hi Alexandre, >> >> On 18 January 2016 at 06:10, Alexandre Courbot <acour...@nvidia.com> wrote: >> >> [snip] >&g

Re: [Nouveau] [PATCH v2 2/5] core: add support for secure boot

Hi Alexandre, On 18 January 2016 at 06:10, Alexandre Courbot wrote: [snip] > +static const char * > +managed_falcons_names[] = { > + [NVKM_SECBOOT_FALCON_PMU] = "PMU", > + [NVKM_SECBOOT_FALCON_RESERVED] = "", "" perhaps ? we already have one invalid below. > +

Re: [Nouveau] [PATCH 1/5] core: add firmware handling functions

Hi Alexandre, On 18 January 2016 at 06:07, Alexandre Courbot wrote: > Add two functions nvkm_firmware_get() and nvkm_firmware_put() to load a > firmware file and free its resources, respectively. Since firmware files > are becoming a necessity for new GPUs, and their

Re: [Nouveau] [PATCH] bios/fan: hardcode the fan mode to linear

On 4 January 2016 at 14:56, Martin Peres wrote: > On 17/12/15 19:18, Martin Peres wrote: >> On 29/11/15 16:10, Martin Peres wrote: >>> >>> This is an oversight that made use of the trip-point-based fan managenent >>> on >>> cards that never expose those. This led the fan to

Re: [Nouveau] [mesa v3 8/9] nvc0: remove use of deprecated sw class identifier

The commit summary "remove use of deprecated..." is no longer applicable. Feel free to tweak (use nvif provided class name/define ?) before pushing. -Emil ___ Nouveau mailing list Nouveau@lists.freedesktop.org

Re: [Nouveau] [mesa v3 1/9] nouveau: bump required libdrm version to 2.4.66

Hi Ben, When "we're feeling bored" ideas in 13/14 of the libdrm-nouveau lot. That aside with the minor comment in 8/9 both series are Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> Hats off for this series (and the crazy drm nouveau evolu

Re: [Nouveau] [mesa v3 8/9] nvc0: remove use of deprecated sw class identifier

On 18 December 2015 at 15:24, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > On 12/18/2015 11:19 AM, Emil Velikov wrote: >> >> The commit summary "remove use of deprecated..." is no longer >> applicable. Feel free to tweak (use nvif provided class name/de

Re: [Nouveau] [libdrm v3 13/14] nouveau: clean up nouveau.h, noting deprecated members/functions

Hi Ben, A couple of side notes, not really anything we should do at this point. On 16 December 2015 at 23:21, Ben Skeggs wrote: > From: Ben Skeggs > > Signed-off-by: Ben Skeggs > --- > nouveau/nouveau.h | 227 >

Re: [Nouveau] [PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v4)

On 15 December 2015 at 11:11, poma wrote: > > Apparently not reached @stable (stable: 4.3.3 2015-12-15), > so here's one more time. > It has reached 4.4-rcX and will get picked by the stable maintainer (Greg?) in due time. Meanwhile you can ask your distro maintainers

Re: [Nouveau] [PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v4)

On 15 December 2015 at 15:01, poma <pomidorabelis...@gmail.com> wrote: > On 15.12.2015 12:21, Emil Velikov wrote: >> On 15 December 2015 at 11:11, poma <pomidorabelis...@gmail.com> wrote: >> >>> >>> Apparently not reached @stable (stable: 4

Re: [Nouveau] [mesa v2 8/9] nvc0: remove allocation of unused sw class

On 8 December 2015 at 14:56, Samuel Pitoiset wrote: > NACK. > > This patches breaks MP performance counters on Fermi/Kepler because they > actually use software methods to configure multiplexers. Global perf > counters will also use software methods to init, sample and

Re: [Nouveau] [RFC PATCH 4/5] subdev/clk: print the base clocks

On 2 December 2015 at 12:21, Karol Herbst wrote: >> Pierre Moreau hat am 2. Dezember 2015 um 02:34 >> geschrieben: >> >> Hi, >> >> On 05:42 PM - Dec 01 2015, Karol Herbst wrote: >> > this is just a nice thing to know and there is no harm in printing

Re: [Nouveau] [RFC PATCH 5/5] clk: allow boosting only when NvBoost is set

On 2 December 2015 at 12:24, Karol Herbst wrote: >> Pierre Moreau hat am 2. Dezember 2015 um 02:26 >> geschrieben: >> You only listed values 0, 1, 2 in the commit message, so what is -1 for? >> Disabling nvboost is already taken care by 0, so it's

Re: [Nouveau] [libdrm 01/13] nouveau: move more abi16-specific logic into abi16.c

Hi Ben, On 26 November 2015 at 07:13, Ben Skeggs wrote: > From: Ben Skeggs > > Signed-off-by: Ben Skeggs > --- > nouveau/abi16.c | 62 > ++- > nouveau/nouveau.c | 56

Re: [Nouveau] [mesa 7/9] nv50: fix g98+ vdec class allocation

On 26 November 2015 at 07:15, Ben Skeggs wrote: > +static const struct nouveau_mclass > +nv98_decoder_msvld[] = { > + { 0x88b1, -1 }, > + { 0x86b1, -1 }, > + { 0x85b1, -1 }, > + {} > +}; > + > +static const struct nouveau_mclass > +nv98_decoder_mspdec[] = { > + {

Re: [Nouveau] [libdrm 06/13] nouveau: introduce object to represent the kernel client

On 26 November 2015 at 07:14, Ben Skeggs wrote: > --- a/nouveau/nouveau.c > +++ b/nouveau/nouveau.c > +int > +nouveau_drm_new(int fd, struct nouveau_drm **pdrm) > +{ > + struct nouveau_drm *drm; > + drmVersionPtr ver; > + > +#ifdef DEBUG > +

Re: [Nouveau] [libdrm 07/13] nouveau: stack legacy nouveau_device on top of nouveau_drm

On 26 November 2015 at 07:14, Ben Skeggs wrote: > --- a/nouveau/nouveau.c > +++ b/nouveau/nouveau.c > + nvdev->base.lib_version = drm->lib_version; On top of last patch "do we need lib_version" there has been no ddx and mesa users that I can see. Do we want to carry keep

Re: [Nouveau] [libdrm 05/13] nouveau: add interfaces to query information about supported classes

On 26 November 2015 at 07:14, Ben Skeggs wrote: > From: Ben Skeggs > > This will expose functionality supported by newer kernel interfaces. > > Current userspace uses the chipset to determine which classes are likely > exposed, which generally works pretty

Re: [Nouveau] [libdrm 09/13] nouveau: import and install a selection of nvif headers from the kernel

On 26 November 2015 at 07:14, Ben Skeggs wrote: > From: Ben Skeggs > --- a/nouveau/Makefile.am > +++ b/nouveau/Makefile.am > @@ -14,9 +14,18 @@ libdrm_nouveau_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@ > > libdrm_nouveau_la_SOURCES =

Re: [Nouveau] [libdrm 08/13] nouveau: make use of nouveau_drm::fd instead of nouveau_device::fd

On 26 November 2015 at 07:14, Ben Skeggs wrote: > From: Ben Skeggs > > The latter is deprecated, and will not be valid for newer clients. > Mention (or split) the removal of nouveau_object_find ? Afaics it has never been used in mesa + ddx. -Emil

Re: [Nouveau] [PATCH v2] pmu: use nvkm_msec instead of do while

On 14 November 2015 at 19:51, Karol Herbst wrote: > I hit this while loop in an error state of the gpu > > v2: unlock mutex only if reply == true > > Signed-off-by: Karol Herbst > --- > drm/nouveau/nvkm/subdev/pmu/base.c | 11 +-- > 1 file

Re: [Nouveau] llvm TGSI backend (WIP) questions

On 13 November 2015 at 14:38, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Fri, Nov 13, 2015 at 9:25 AM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> Hello Hans, >> >> Not to muddy the waters or anything, have you thought about the NIR >> integr

Re: [Nouveau] llvm TGSI backend (WIP) questions

Hello Hans, Not to muddy the waters or anything, have you thought about the NIR integration that Rob was thinking about ? I'm pretty sure he'll be happy to have extra people helping him out. Cheers, Emil ___ Nouveau mailing list

[Nouveau] [PATCH libdrm 15/17] nouveau: use designated initializers

Cc: nouveau@lists.freedesktop.org Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- nouveau/abi16.c | 13 ++--- nouveau/nouveau.c | 6 +++--- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/nouveau/abi16.c b/nouveau/abi16.c index 4ca0bfb..59bc436 100644

Re: [Nouveau] [PATCH 2/2] Add Option DRI to allow selection of maximum DRI level. (v2)

level to make it consistent with the same option in the released Intel-ddx. v2: Use fixed up Bool return type of nouveau_present_init(). Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com Cc: Ilia Mirkin imir...@alum.mit.edu Cc: Emil Velikov emil.l.veli...@gmail.com Cc: Martin

[Nouveau] [PATCH] configure: remove unneeded AC_SUBST statements

The variables are already set/substituted by the PKG_CHECK_MODULES macro. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 4 1 file changed, 4 deletions(-) diff --git a/configure.ac b/configure.ac index 03563c1..6048c5a 100644 --- a/configure.ac +++ b/configure.ac

[Nouveau] [PATCH] dri3: remove spurious {f,}stat calls

... and use drmGetNodeTypeFromFd where possible. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/nouveau_dri2.c | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c index ce6f53e..d3cce4e 100644

Re: [Nouveau] [PATCH] avoid build fail without COMPOSITE

On 15 July 2015 at 14:12, Emil Velikov emil.l.veli...@gmail.com wrote: Upon closer look it seem that I was a bit off - the ati/intel ddx does not set off_x/y to zero when built without composite*. ... in copy_region2, they do so when working with video - XvAdaptorPtr::ddPutImage

Re: [Nouveau] [PATCH] avoid build fail without COMPOSITE

= GetScratchGC(pDraw-depth, pScreen); Now I sort of assume that pDraw-x == pWin-origin.x. But... who knows. -ilia On Tue, Jul 14, 2015 at 5:46 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 14 July 2015 at 22:17, Ilia Mirkin imir...@alum.mit.edu wrote: --- src/nouveau_dri2.c | 15

Re: [Nouveau] [PATCH] avoid build fail without COMPOSITE

On 14 July 2015 at 22:17, Ilia Mirkin imir...@alum.mit.edu wrote: --- src/nouveau_dri2.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c index f22e319..4398559 100644 --- a/src/nouveau_dri2.c +++

Re: [Nouveau] [PATCH 1/2] nouveau/compiler: fix trivial compiler warnings

On 8 July 2015 at 20:34, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Mh i'm not aware of me ever changed the nouveau_compiler. But i'm happy to see this made you laugh, so it has something positive at least... :/ Story time: This particular compiler warning has been brought up

Re: [Nouveau] [PATCH] Add Option DRI3 to allow to disable DRI3 under EXA.

the version numbers :) On Sat, Jul 4, 2015 at 2:23 PM, Emil Velikov emil.l.veli...@gmail.com wrote: That would be great, as long as it does only that and does not go into the drivername territory. As the said driver ;-) A driver name to use can be provided instead of simple boolean value, which

Re: [Nouveau] [PATCH] Add Option DRI3 to allow to disable DRI3 under EXA.

That would be great, as long as it does only that and does not go into the drivername territory. As the said driver ;-) A driver name to use can be provided instead of simple boolean value, which will be passed to the GL implementation for it to load the appropriate backend. -Emil On 4 July

Re: [Nouveau] [PATCH v2] nouveau: add coherent BO attribute

On 26/05/15 19:06, Martin Peres wrote: On 26/05/2015 16:23, Alexandre Courbot wrote: On Sun, May 24, 2015 at 3:26 PM, Maarten Lankhorst maar...@mblankhorst.nl wrote: Op 23-05-15 om 08:45 schreef Alexandre Courbot: On Fri, May 22, 2015 at 3:23 AM, Martin Peres martin.pe...@free.fr wrote: On

Re: [Nouveau] [PATCH v2 1/4] Add atomic_inc_return to atomics.

On 26/02/15 10:54, Maarten Lankhorst wrote: Signed-off-by: Maarten Lankhorst maarten.lankho...@ubuntu.com Hmm atomic differences between the different platforms are fun. Bring on C11 atomics :-P But seriously, feel free to add acked-by for patches 1 2, and tested-by for the whole series.

Re: [Nouveau] [PATCH 1/2] nouveau: make nouveau importing global buffers completely thread-safe, with tests

On 25 February 2015 at 21:59, Maarten Lankhorst maarten.lankho...@canonical.com wrote: On 25-02-15 15:14, Emil Velikov wrote: On 24 February 2015 at 09:01, Maarten Lankhorst maarten.lankho...@ubuntu.com wrote: ... +static const char default_device[] = /dev/dri/renderD128; + Reuse the defines

Re: [Nouveau] [PATCH 2/2] nouveau: Do not add most bo's to the global bo list.

On 24 February 2015 at 09:01, Maarten Lankhorst maarten.lankho...@ubuntu.com wrote: Only add wrapped bo's and bo's that have been exported through flink or dma-buf. This avoids a lock in the common case, and decreases traversal needed for importing a dma-buf or flink. Signed-off-by:

Re: [Nouveau] [PATCH 1/2] nouveau: make nouveau importing global buffers completely thread-safe, with tests

On 24 February 2015 at 09:01, Maarten Lankhorst maarten.lankho...@ubuntu.com wrote: While I've closed off most races in a previous patch, a small race still existed where importing then unreffing cound cause an invalid bo. Add a test for this case. Racing sequence fixed: - thread 1

Re: [Nouveau] [PATCH 2/2] nouveau: Do not add most bo's to the global bo list.

AM, Maarten Lankhorst maarten.lankho...@ubuntu.com wrote: Op 25-02-15 om 15:11 schreef Emil Velikov: On 24 February 2015 at 09:01, Maarten Lankhorst maarten.lankho...@ubuntu.com wrote: Only add wrapped bo's and bo's that have been exported through flink or dma-buf. This avoids a lock

  1   2   3   >