[Nouveau] Proposal for allowing more Nouveau contributors to merge patches

2021-08-06 Thread Karol Herbst
Hey everybody, so, here is a proposal of what we could change in order to allow patches to land faster, more reliably and to increase the overall bus factor in terms of nouveau kernel maintenance. But let's start with the current situation: At the moment contributors have to send patches to the

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 20

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > playing around a little bit with this, I think the original "select >

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > playing around a little bit with this, I think the original "select > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix o

[Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
playing around a little bit with this, I think the original "select BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of drivers selecting and others depending on it. We could of course convert everything over to depend, and break those cycling dependency issues with this. Anyway

Re: [Nouveau] [PATCH 06/38] x86/mmiotrace: Replace deprecated CPU-hotplug functions.

2021-08-03 Thread Karol Herbst
functions with the official version. > The behavior remains unchanged. > > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Borislav Petkov

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-27 Thread Karol Herbst
On Thu, Jul 22, 2021 at 5:10 AM Ratchanan Srirattanamet wrote: > > The call site of nouveau_dsm_pci_probe() uses single set of output > variables for all invocations. So, we must not write anything to them > until we think this is an NVIDIA device of interest. Otherwise, if we > are called with an

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 4:05 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 2:52 PM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > In the past this only led to compilation issues. Also the small amount of > > extra .text shouldn't really matter compared to the ent

[Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-23 Thread Karol Herbst
ri-de...@lists.freedesktop.org Fixes: 6eca310e8924 ("drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau") Signed-off-by: Karol Herbst --- drivers/gpu/drm/nouveau/Kbuild | 2 +- drivers/gpu/drm/nouveau/Kconfig | 13 ++- drivers/gpu/drm/nouveau/

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 8:40 PM Arnd Bergmann wrote: > > On Fri, Jul 23, 2021 at 6:34 PM Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > > > On Fri, Jul 23, 2021 at 5:1

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: > >> > >> On 7/23/21 2:15 AM, Arnd Bergmann wrote: > >>> From: Arnd Bergmann > >>> &g

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: > > On 7/23/21 2:15 AM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When the backlight support is disabled, the driver fails to build: > > > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function > > 'nv50_sor_atomic_disable': > > driv

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 12:10 PM Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 11:24 AM Daniel Vetter wrote: > > > > On Fri, Jul 23, 2021 at 11:15 AM Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > When the ba

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 11:24 AM Daniel Vetter wrote: > > On Fri, Jul 23, 2021 at 11:15 AM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > When the backlight support is disabled, the driver fails to build: > > > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function > > 'nv50_sor_atomi

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
On Thu, Jul 22, 2021 at 9:54 PM Karol Herbst wrote: > > On Thu, Jul 22, 2021 at 9:49 PM Ratchanan Srirattanamet > wrote: > > > > Hello, > > > > เมื่อ 22/7/64 เวลา 23:36 Karol Herbst เขียนว่า: > > > hey, thanks for the patch. But I am a bit confused

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
On Thu, Jul 22, 2021 at 9:49 PM Ratchanan Srirattanamet wrote: > > Hello, > > เมื่อ 22/7/64 เวลา 23:36 Karol Herbst เขียนว่า: > > hey, thanks for the patch. But I am a bit confused on why that patch > > actually helps. It should only be called for nvidia GPUs, but are we &

Re: [Nouveau] nouveau broken again on Riva TNT2 in 5.14.0-rc2

2021-07-22 Thread Karol Herbst
hey thanks for the report. This is a known issue and the fix is pending in drm-mist-fixes and should land in 5.14 soonish. On Thu, Jul 22, 2021 at 9:29 PM Ondrej Zary wrote: > > Hello, > nouveau is broken again: > > [ 58.795794] BUG: kernel NULL pointer dereference, address: 017c > [ 58.

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
hey, thanks for the patch. But I am a bit confused on why that patch actually helps. It should only be called for nvidia GPUs, but are we ending up checking it for AMD GPUs as well? Mind posting the output of lspci -tvnn? On Thu, Jul 22, 2021 at 5:10 AM Ratchanan Srirattanamet wrote: > > The cal

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

2021-07-21 Thread Karol Herbst
actually.. it was already found in this thread: https://lore.kernel.org/lkml/YOC4uekpD7iA3xPi@Red/T/ fixes incoming. On Wed, Jul 21, 2021 at 3:13 PM Karol Herbst wrote: > > fyi: I am able to reproduce it on my machine and will figure out > what's wrong. Thanks! > > On Mon, J

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

2021-07-21 Thread Karol Herbst
fyi: I am able to reproduce it on my machine and will figure out what's wrong. Thanks! On Mon, Jul 19, 2021 at 10:53 PM Sid Boyce wrote: > > Also sent this to kernel mailing list. > > I saw an earlier kernel mailing list post (week 8 - 15 July) that so far > hasn't made it into 5.14-rc. > > > GPU

Re: [Nouveau] [PATCH] include/uapi/drm: fix spelling mistakes in header files

2021-07-12 Thread Karol Herbst
hen. > As long as it doesn't touch code I don't see why not. Just in case: Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH] remove unused varialble "struct device *dev"

2021-06-23 Thread Karol Herbst
On Tue, Jun 22, 2021 at 5:14 PM Cai Huoqing wrote: > > fix the warning- variable 'dev' set but not used > the patch title needs a prefix to indicate which subsystem it belongs to. Check git log for examples. With that fixed: Reviewed-by: Karol Herbst > Sign

Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang

2021-06-01 Thread Karol Herbst
all three nouveau patches are Reviewed-by: Karol Herbst and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva wrote: &

Re: [Nouveau] [PATCH 11/34] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static

2021-05-26 Thread Karol Herbst
t; spin_unlock_irqrestore(&mc->lock, flags); > } > > -void > +static void > tu102_mc_intr_mask(struct nvkm_mc *base, u32 mask, u32 intr) > { > struct tu102_mc *mc = tu102_mc(base); > -- > 2.31.1 > > _

Re: [Nouveau] [PATCH] nouveau/gem: fix user-after-free in nouveau_gem_new

2021-05-17 Thread Karol Herbst
On Mon, May 17, 2021 at 11:17 AM Thierry Reding wrote: > > On Mon, May 17, 2021 at 10:56:29AM +0200, Thierry Reding wrote: > > On Tue, May 11, 2021 at 06:35:53PM +0200, Karol Herbst wrote: > > > If ttm_bo_init fails it will already call ttm_bo_put, so we don't h

Re: [Nouveau] [PATCH] nouveau/gem: fix user-after-free in nouveau_gem_new

2021-05-13 Thread Karol Herbst
On Thu, May 13, 2021 at 5:25 PM Jeremy Cline wrote: > > On Tue, May 11, 2021 at 06:35:53PM +0200, Karol Herbst wrote: > > If ttm_bo_init fails it will already call ttm_bo_put, so we don't have to > > do it

[Nouveau] [PATCH] nouveau/gem: fix user-after-free in nouveau_gem_new

2021-05-11 Thread Karol Herbst
rm/nouveau: Initialize GEM object before TTM object" Cc: Thierry Reding Signed-off-by: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index c88cbb85f10

Re: [Nouveau] Bug system problems

2021-04-22 Thread Karol Herbst
I've notified the gitlab admins, but maybe you can use the social login (google, github, twitter, etc..) for the moment or would that require the confirmation email as well? On Thu, Apr 22, 2021 at 3:44 PM o1bigtenor wrote: > > Greetings > > In the process of setting up an account at the https://

Re: [Nouveau] [bug report] drm/nouveau/hwmon: Remove old code, add .write/.read operations

2021-04-21 Thread Karol Herbst
On Wed, Apr 21, 2021 at 3:57 PM Dan Carpenter wrote: > > Hello Oscar Salvador, > > The patch bfb96e4c344e: "drm/nouveau/hwmon: Remove old code, add > .write/.read operations" from May 18, 2017, leads to the following > static checker warning: > > drivers/gpu/drm/nouveau/nouveau_hwmon.c:507 nou

Re: [Nouveau] [PATCH 13/40] drm/nouveau/dispnv50/disp: Include header containing our prototypes

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/disp.c:2599:1: warning: no previous > prototype for ‘nv50_display_create’ [-Wmissing-prototypes] > > Cc: Be

Re: [Nouveau] [PATCH 14/40] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * > file mga_ioc32.c > > Cc: Ben Skeggs > Cc: David Airlie &

Re: [Nouveau] [PATCH 16/40] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or > member 'filp' not described in 'nouveau_compat_ioc

Re: [Nouveau] [PATCH 15/40] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function

2021-04-19 Thread Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_svm.c: In function ‘nouveau_pfns_map’: > drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ‘ret’ set but > not used [-Wunused-but-set-variable]

Re: [Nouveau] [PATCH 12/40] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following build error: > > drivers/gpu/drm/nouveau/dispnv50/disp.c:2530:1: error: conflicting types for > ‘nv50_display_fini’ > In file included from drivers/gpu/drm/nouveau/

Re: [Nouveau] [PATCH 11/40] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous > prototype for ‘headc57d_olut’ [-Wmissing-prototypes] > > Cc: Be

Re: [Nouveau] [PATCH 10/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void

2021-04-19 Thread Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_cleanup’: > drivers/gpu/drm/nouveau/dispnv50/disp.c:1357:6: warning: variable ‘ret’ set > but not used [-Wunused-but-set-vari

Re: [Nouveau] [PATCH 09/40] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or > member 'crtc' not described in 'nv_crtc_mode_set_re

Re: [Nouveau] [PATCH 07/40] drm/nouveau/nouveau_bo: Remove unused variables 'dev'

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’: > drivers/gpu/drm/nouveau/nouveau_bo.c:1228:17: warning: variable ‘

Re: [Nouveau] [PATCH 05/40] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function > parameter or member 'speedo' not described in 'gk20a_vo

Re: [Nouveau] [PATCH 06/40] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:992: warning: Function > parameter or member 'gr' not described in 'gf100_gr_wait_

Re: [Nouveau] [PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret'

2021-04-19 Thread Karol Herbst
On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/disp.c:1381:6: warning: variable ‘ret’ set > but not used [-Wunused-but-set-variable] > not a big fan of just ignoring return codes, I'd rather see it handl

Re: [Nouveau] [PATCH 01/40] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function > parameter or member 'init' not described in 'init_reserv

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Karol Herbst
On Tue, Apr 13, 2021 at 1:17 PM Roy Spliet wrote: > > Op 13-04-2021 om 10:48 schreef Karol Herbst: > > On Tue, Apr 13, 2021 at 10:24 AM Roy Spliet wrote: > >> > >> Op 13-04-2021 om 01:10 schreef Karol Herbst: > >>> On Mon, Apr 12, 2021 at 9:36 PM Ro

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Karol Herbst
On Tue, Apr 13, 2021 at 10:24 AM Roy Spliet wrote: > > Op 13-04-2021 om 01:10 schreef Karol Herbst: > > On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: > >> > >> Hello Aaron, > >> > >> Thanks for your insights. A follow-up query and some observ

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Karol Herbst
On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: > > Hello Aaron, > > Thanks for your insights. A follow-up query and some observations in-line. > > Op 12-04-2021 om 20:06 schreef Aaron Plattner: > > On 4/10/21 1:48 PM, Roy Spliet wrote: > >> Op 10-04-2021 om 20:23 schreef Lukas Wunner: > >>> On

Re: [Nouveau] SLI support for nv44

2021-03-30 Thread Karol Herbst
On Tue, Mar 30, 2021 at 8:28 AM wrote: > > Hi, > I am currently the happy owner of a nforce 4 - SLI with two 7100gs graphics > cards setup. > Since I've read on your features matrix that such a setup is rather uncommon > among developers, I would like to help you implementing SLI for old GeForce

Re: [Nouveau] [PATCH 14/19] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-03-19 Thread Karol Herbst
ize != 1024) > -- > 2.27.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 17/19] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-03-19 Thread Karol Herbst
; * > * 32-bit ioctl compatibility routines for the MGA DRM. > -- > 2.27.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > Reviewed-by: Karol Herbst

Re: [Nouveau] [PATCH 12/19] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers

2021-03-19 Thread Karol Herbst
m_framebuffer *old_fb) > return ret; > } > > -/** > +/* > * Sets up registers for the given mode/adjusted_mode pair. > * > * The clocks, CRTCs and outputs attached to this CRTC must be off. > -- > 2.27.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 19/19] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-03-19 Thread Karol Herbst
e "nouveau_ioctl.h" > > -/** > +/* > * Called whenever a 32-bit process running under a 64-bit kernel > * performs an ioctl on /dev/dri/card. > * > -- > 2.27.0 > > _______ > dri-devel mailing list > dri-de..

Re: [Nouveau] [PATCH 10/19] drm/nouveau/nouveau_bo: Remove unused variables 'dev'

2021-03-19 Thread Karol Herbst
; TTM_PAGE_FLAG_SG); > > if (slave) > return; > > drm = nouveau_bdev(bdev); > - dev = drm->dev->dev; > > return ttm_pool_free(&drm->ttm.bdev.pool, ttm); > } > -- > 2.27.0 > > ___

Re: [Nouveau] [PATCH 15/19] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions

2021-03-19 Thread Karol Herbst
gt; _______ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 09/19] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header

2021-03-19 Thread Karol Herbst
t; > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 05/19] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers

2021-03-19 Thread Karol Herbst
c0) > */ > static inline int > @@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const > struct cvb_coef *coef) > return mv; > } > > -/** > +/* > * cvb_t_mv = > * ((c2 * speedo / s_sc

Re: [Nouveau] [PATCH 01/19] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

2021-03-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Mar 19, 2021 at 9:24 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function > parameter or member 'init' not described in 'init_reserv

Re: [Nouveau] That dispnv50 patch blew up my laptop AGAIN as now it's in the LTS kernel

2021-03-15 Thread Karol Herbst
On Sun, Mar 14, 2021 at 11:04 PM wrote: > > https://forum.artixlinux.org/index.php/topic,2083.msg14006.html#msg14006 > https://forum.artixlinux.org/index.php/topic,2383.new.html#new > > It is going to blow up many more now, the freeze bug may take days, weeks or > months to appear, now with this

Re: [Nouveau] Request for information and/or assistance

2021-03-08 Thread Karol Herbst
On Thu, Mar 4, 2021 at 3:21 AM o1bigtenor wrote: > > Greetings > > Running debian testing, 2 nvidia gpus (GP107 and GF110) and 5 monitors > (1 - 3840x2160 and 2 1920x1080 on the GP107 and 2 - 1920x1080 on the > GF110) using one screen (7680x3000). > > I would still like to modify some things but c

Re: [Nouveau] How to reverse engineer a PCI-Express driver under Linux ?

2021-03-03 Thread Karol Herbst
On Wed, Mar 3, 2021 at 11:07 AM Tomek LECOCQ wrote: > Hello, > > I’ve already asked this on the Kernel Newbies mail list, but as developing > nouveau seems to be kind of similar to what I want to achieve, I thought it > would be a good idea to ask it here as well. > > I have a PCI-Express video c

Re: [Nouveau] [PATCH v3] drm/gpu/nouveau/dispnv50: Restore pushing of all data.

2021-01-27 Thread Karol Herbst
Reviewed-by: Karol Herbst On Thu, Jan 21, 2021 at 3:28 PM Bastian Beranek wrote: > > Commit f844eb485eb056ad3b67e49f95cbc6c685a73db4 introduced a regression for > NV50, which lead to visual artifacts, tearing and eventual crashes. > > In the changes of f844eb485eb056ad3b67e49f9

Re: [Nouveau] [PATCH v2] drm/gpu/nouveau/dispnv50: Restore pushing of all data.

2021-01-21 Thread Karol Herbst
ohh, at first I thought this was a resend, but it's in a different file :) On Thu, Jan 21, 2021 at 12:11 PM Bastian Beranek wrote: > > Commit f844eb485eb056ad3b67e49f95cbc6c685a73db4 introduced a regression for > NV50, which lead to visual artifacts, tearing and eventual crashes. > > In the chang

Re: [Nouveau] nouveau regression post v5.8, still present in v5.10

2021-01-21 Thread Karol Herbst
fyi, there is a patch which solves a maybe related issue on your GPU, mind giving it a try before we dig further? https://gitlab.freedesktop.org/drm/nouveau/-/issues/14#note_767791 On Thu, Jan 21, 2021 at 3:33 AM Jamie Heilman wrote: > > Karol Herbst wrote: > > On Wed, Jan 6, 202

[Nouveau] [PATCH] drm/nouveau/svm: fail NOUVEAU_SVM_INIT ioctl on unsupported devices

2021-01-18 Thread Karol Herbst
Fixes a crash when trying to create a channel on e.g. Turing GPUs when NOUVEAU_SVM_INIT was called before. Fixes: eeaf06ac1a558 ("drm/nouveau/svm: initial support for shared virtual memory") Signed-off-by: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_svm.c | 4 1 file

Re: [Nouveau] [PATCH] tracing: remove definition of DEBUG

2021-01-18 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Jan 15, 2021 at 11:51 PM wrote: > > From: Tom Rix > > Defining DEBUG should only be done in development. > So remove DEBUG. > > Signed-off-by: Tom Rix > --- > kernel/trace/trace_mmiotrace.c | 2 -- > 1 file changed, 2 deleti

Re: [Nouveau] nouveau regression post v5.8, still present in v5.10

2021-01-06 Thread Karol Herbst
On Wed, Jan 6, 2021 at 4:25 AM Jamie Heilman wrote: > > Jamie Heilman wrote: > > Jamie Heilman wrote: > > > Karol Herbst wrote: > > > > do you think you'd be able to do a kernel bisect in order to pinpoint > > > > the actual commit causing it? Tha

Re: [Nouveau] 5.9.11 still hanging 2mn at each boot and looping on nvidia-gpu 0000:01:00.3: PME# enabled (Quadro RTX 4000 Mobile)

2021-01-04 Thread Karol Herbst
mhh, that PCI config stuff should really not happen all the time, but it also doesn't appear to. The other thing I really don't know is, how well the runpm works with tools like TLP if there isn't only an audio device, but also the USB stuff and all the subdevices have to be turned off all the time

Re: [Nouveau] nouveau regression post v5.8, still present in v5.10

2021-01-04 Thread Karol Herbst
do you think you'd be able to do a kernel bisect in order to pinpoint the actual commit causing it? Thanks On Sun, Dec 27, 2020 at 8:16 PM Jamie Heilman wrote: > > Something between v5.8 and v5.9 has resulted in periodically losing video. > Unfortunately, I can't reliably reproduce it, it seems t

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-01-04 Thread Karol Herbst
On Tue, Dec 22, 2020 at 3:50 AM Kai-Heng Feng wrote: > > On Tue, Dec 22, 2020 at 1:56 AM Ilia Mirkin wrote: > > > > On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng > > wrote: > > > > > > [+Cc nouveau] > > > > > > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai wrote: > > > [snip] > > > > > Quite po

Re: [Nouveau] Xorg evoc

2021-01-04 Thread Karol Herbst
uhm.. good question, but I think so. Might be best to ask on the xorg ML as well On Mon, Dec 21, 2020 at 2:10 PM Nikunj goyal wrote: > > Hi everyone, > I was surfing the web and i came across this program endless summer of code > by Xorg and wanted to ask if it is still active? > Thanks > > Rega

Re: [Nouveau] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-29 Thread Karol Herbst
On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote: > > Hi Miguel, > > On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda > wrote: > > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > > To make the intent clear, you have to first be certain that you > > > understand the intent; otherwise

[Nouveau] [PATCH] drm/nouveau/kms: handle mDP connectors

2020-11-27 Thread Karol Herbst
documentation. Cc: sta...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: Ben Skeggs Reported-by: Mark Pearson Tested-by: Mark Pearson Signed-off-by: Karol Herbst --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/conn.h | 1 + drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + 2

Re: [Nouveau] [PATCH] drm/nouveau: make sure ret is initialized in nouveau_ttm_io_mem_reserve

2020-11-26 Thread Karol Herbst
Reviewed-by: Karol Herbst On Thu, Nov 26, 2020 at 2:11 PM Christian König wrote: > > This wasn't initialized for pre NV50 hardware. > > Signed-off-by: Christian König > Reported-and-Tested-by: Mark Hounschell > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +- >

Re: [Nouveau] [PATCH] drm/nouveau: bail out of nouveau_channel_new if channel init fails

2020-11-15 Thread Karol Herbst
On Sun, Nov 15, 2020 at 6:43 PM Salvatore Bonaccorso wrote: > > Hi, > > On Fri, Aug 28, 2020 at 11:28:46AM +0200, Frantisek Hrbata wrote: > > Unprivileged user can crash kernel by using DRM_IOCTL_NOUVEAU_CHANNEL_ALLOC > > ioctl. This was reported by trinity[1] fuzzer. > > > > [ 71.073906] nouvea

Re: [Nouveau] [PATCH 2/3] drm/nouveau: manage nouveau_drm lifetime with devres

2020-11-06 Thread Karol Herbst
On Fri, Nov 6, 2020 at 3:17 AM Jeremy Cline wrote: > > Make use of the devm_drm_dev_alloc() API to bind the lifetime of > nouveau_drm structure to the drm_device. This is important because a > reference to nouveau_drm is accessible from drm_device, which is > provided to a number of DRM layer call

Re: [Nouveau] [PATCH 0/5] Improve Robust Channel (RC) recovery for Turing

2020-10-30 Thread Karol Herbst
On Fri, Oct 30, 2020 at 3:37 AM Alistair Popple wrote: > > This is an initial series of patches to improve channel recovery on Turing > GPUs > with the goal of improving reliability enough to eventually enable SVM for > Turing. It's likely follow up patches will be required to fully address > pr

Re: [Nouveau] nouveau broken on Riva TNT2 in 5.9.0-rc8: GPU not supported on big-endian

2020-10-28 Thread Karol Herbst
I sent a patch to the mailing list and wanted to have some review on that from at least Ben, but no idea if Ben already picked it and if it's good enough for sending it to stable yet. ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.f

Re: [Nouveau] [PATCH RFC] drm/nouveau: fix memory leak in nvkm_iccsense_oneinit

2020-10-15 Thread Karol Herbst
On Thu, Oct 15, 2020 at 6:32 PM Karol Herbst wrote: > > Ben, I think this is like the 5th patch tackling this issue, I think > we should merge one of those. > maybe I just confused that with reports, but it seems to turn up quite a bit and maybe I should have pushed more of it as wel

Re: [Nouveau] [PATCH RFC] drm/nouveau: fix memory leak in nvkm_iccsense_oneinit

2020-10-15 Thread Karol Herbst
Ben, I think this is like the 5th patch tackling this issue, I think we should merge one of those. On Thu, Oct 15, 2020 at 6:23 AM Keita Suzuki wrote: > > struct pw_rail_t is allocated as an array in function nvios_iccsense_parse, > and stored to a struct member of local variable. However, the ar

Re: [Nouveau] [PATCH] drm/nouveau/device: fix changing endianess code to work on older GPUs

2020-10-13 Thread Karol Herbst
On Tue, Oct 13, 2020 at 3:55 PM Ilia Mirkin wrote: > > On Tue, Oct 13, 2020 at 8:01 AM Karol Herbst wrote: > > > > With this we try to detect if the endianess switch works and assume LE if > > not. Suggested by Ben. > > > > Fixes: 51c05340e407 ("drm/nouv

Re: [Nouveau] [PATCH] drm/nouveau/device: fix changing endianess code to work on older GPUs

2020-10-13 Thread Karol Herbst
ehh.. messed up sending it against the other thread, but mind testing this patch and verify it fixes your issue? Thanks. On Tue, Oct 13, 2020 at 2:01 PM Karol Herbst wrote: > > With this we try to detect if the endianess switch works and assume LE if > not. Suggested by Ben.

[Nouveau] [PATCH] drm/nouveau/device: fix changing endianess code to work on older GPUs

2020-10-13 Thread Karol Herbst
With this we try to detect if the endianess switch works and assume LE if not. Suggested by Ben. Fixes: 51c05340e407 ("drm/nouveau/device: detect if changing endianness failed") --- .../gpu/drm/nouveau/nvkm/engine/device/base.c | 39 --- 1 file changed, 26 insertions(+), 13 deleti

Re: [Nouveau] nouveau broken on Riva TNT2 in 5.9.0-rc8: GPU not supported on big-endian

2020-10-09 Thread Karol Herbst
On Sat, Oct 10, 2020 at 12:23 AM Ilia Mirkin wrote: > > On Fri, Oct 9, 2020 at 5:54 PM Karol Herbst wrote: > > > > On Fri, Oct 9, 2020 at 11:35 PM Ondrej Zary wrote: > > > > > > Hello, > > > I'm testing 5.9.0-rc8 and found that Riva TNT2 stopped

Re: [Nouveau] nouveau broken on Riva TNT2 in 5.9.0-rc8: GPU not supported on big-endian

2020-10-09 Thread Karol Herbst
On Fri, Oct 9, 2020 at 11:35 PM Ondrej Zary wrote: > > Hello, > I'm testing 5.9.0-rc8 and found that Riva TNT2 stopped working: > [0.00] Linux version 5.9.0-rc8+ (zary@gsql) (gcc (Debian 8.3.0-6) > 8.3.0, GNU ld (GNU Binutils for Debian) 2.31.1) #326 SMP Fri Oct 9 22:31:40 > CEST 2020 >

[Nouveau] [RFC] fifo: only reboot engines if they have a ref

2020-10-07 Thread Karol Herbst
liar fixes? Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/engine/fifo/gk104.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drm/nouveau/nvkm/engine/fifo/gk104.c b/drm/nouveau/nvkm/engine/fifo/gk104.c index 441483325..669153fba 100644 --- a/drm/nouveau/nvkm/engine/

[Nouveau] [RFC] gem: fix "refcount_t: underflow; use-after-free"

2020-10-06 Thread Karol Herbst
we can't use nouveau_bo_ref here as no ttm object was allocated and nouveau_bo_ref mainly deals with that. Simply deallocate the object. Signed-off-by: Karol Herbst --- drm/nouveau/nouveau_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drm/nouveau/nouveau_ge

Re: [Nouveau] [PATCH] device: return error for unknown chipsets

2020-10-06 Thread Karol Herbst
On Tue, Oct 6, 2020 at 7:53 PM Jeremy Cline wrote: > > On Tue, Oct 06, 2020 at 06:46:35PM +0200, Karol Herbst wrote: > > On Tue, Oct 6, 2020 at 6:43 PM dann frazier > > wrote: > > > > > > On Mon, Oct 05, 2020 at 03:52:30PM +0200, Karol Herbst wrote: > >

Re: [Nouveau] [PATCH] device: return error for unknown chipsets

2020-10-06 Thread Karol Herbst
On Tue, Oct 6, 2020 at 6:43 PM dann frazier wrote: > > On Mon, Oct 05, 2020 at 03:52:30PM +0200, Karol Herbst wrote: > > Previously the code relied on device->pri to be NULL and to fail probing > > later. We really should just return an error inside nvkm_device_ctor for

[Nouveau] [PATCH] device: return error for unknown chipsets

2020-10-05 Thread Karol Herbst
Previously the code relied on device->pri to be NULL and to fail probing later. We really should just return an error inside nvkm_device_ctor for unsupported GPUs. Fixes: 24d5ff40a732 ("drm/nouveau/device: rework mmio mapping code to get rid of second map") Signed-off-by: Karol Her

Re: [Nouveau] Nouveau wiki migration

2020-10-01 Thread Karol Herbst
On Thu, Oct 1, 2020 at 7:53 PM Sam Ravnborg wrote: > > Hi Karol. > > On Thu, Oct 01, 2020 at 01:36:52PM +0200, Karol Herbst wrote: > > On Fri, Sep 25, 2020 at 11:27 PM Karol Herbst wrote: > > > > > > Hi everybody, > > > > > > I think it'

Re: [Nouveau] Nouveau wiki migration

2020-10-01 Thread Karol Herbst
On Fri, Sep 25, 2020 at 11:27 PM Karol Herbst wrote: > > Hi everybody, > > I think it's time to finally move our wiki from the old infrastructure > over to gitlab pages. > > This comes with several benefits: > * full control through git over the ikiwiki pipeline (s

[Nouveau] Nouveau wiki migration

2020-09-25 Thread Karol Herbst
Hi everybody, I think it's time to finally move our wiki from the old infrastructure over to gitlab pages. This comes with several benefits: * full control through git over the ikiwiki pipeline (setup files, plugins, system packages, ...) * random users are able to create MRs against the wiki as

Re: [Nouveau] [RFC] Documentation: nouveau: Introduce some nouveau documentation

2020-09-24 Thread Karol Herbst
On Thu, Sep 24, 2020 at 8:18 PM Jeremy Cline wrote: > > On Thu, Sep 24, 2020 at 07:26:01PM +0200, Karol Herbst wrote: > > On Thu, Sep 24, 2020 at 6:03 PM Jeremy Cline wrote: > > > > > > On Wed, Sep 23, 2020 at 11:36:54PM +0200, Karol Herbst wrote: > > > &g

Re: [Nouveau] [RFC] Documentation: nouveau: Introduce some nouveau documentation

2020-09-24 Thread Karol Herbst
On Thu, Sep 24, 2020 at 7:26 PM Karol Herbst wrote: > > On Thu, Sep 24, 2020 at 6:03 PM Jeremy Cline wrote: > > > > On Wed, Sep 23, 2020 at 11:36:54PM +0200, Karol Herbst wrote: > > > On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline wrote: > > > > > >

Re: [Nouveau] [RFC] Documentation: nouveau: Introduce some nouveau documentation

2020-09-24 Thread Karol Herbst
On Thu, Sep 24, 2020 at 6:03 PM Jeremy Cline wrote: > > On Wed, Sep 23, 2020 at 11:36:54PM +0200, Karol Herbst wrote: > > On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline wrote: > > > > > > On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: > > > &

Re: [Nouveau] [RFC] Documentation: nouveau: Introduce some nouveau documentation

2020-09-24 Thread Karol Herbst
On Thu, Sep 24, 2020 at 3:06 PM Roy Spliet wrote: > > > Op 23-09-2020 om 22:36 schreef Karol Herbst: > > On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline wrote: > >> > >> On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: > >>> On Fri

Re: [Nouveau] [RFC] Documentation: nouveau: Introduce some nouveau documentation

2020-09-23 Thread Karol Herbst
On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline wrote: > > On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: > > On Fri, Sep 11, 2020 at 6:21 PM Jeremy Cline wrote: > > > > > yeah, I think overall this file is a good idea and being able to get a > >

Re: [Nouveau] [RFC] Documentation: nouveau: Introduce some nouveau documentation

2020-09-23 Thread Karol Herbst
On Fri, Sep 11, 2020 at 6:21 PM Jeremy Cline wrote: > > Other gpu drivers have some driver-specific documentation, so it would > nice if nouveau did as well. > > This adds a bare-bones ReStructured Text document with sections for > module parameter documentation, an overview of the driver architec

Re: [Nouveau] [PATCH v2 1/2] drm/nouveau: return temperatures in temp_get() via parameter

2020-09-17 Thread Karol Herbst
On Thu, Sep 17, 2020 at 4:11 PM Jeremy Cline wrote: > > On Wed, Sep 16, 2020 at 10:03:22PM +0200, Karol Herbst wrote: > > On Wed, Sep 16, 2020 at 10:01 PM Karol Herbst wrote: > > > > > > On Wed, Sep 16, 2020 at 9:47 PM Jeremy Cline wrote: > > > >

<    1   2   3   4   5   6   7   8   9   10   >