This patch replaces the symbolic permissions with the numeric ones.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 10 +-
1 file changed, 5 insertions(+), 5 deleti
or pwm_min/max attrs.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 34 -
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/d
to make easier the review of all patches.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 163
1 file changed, 163 insertions(+)
diff --git a
This patch removes old code related to the old api and transforms the
functions for the new api. It also adds the .write and .read operations.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu
This is a preparation for the next patches. It just adds the sensors with
their possible configurable settings and then fills the struct
hwmon_channel_info
with all this information.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe..
ister function with the
new one hwmon_device_register_with_info.
It also does some cleanup.
Oscar Salvador (5):
nouveau/hwmon: Add config for all sensors and their settings
nouveau/hwmon: Add nouveau_hwmon_ops structure with
.is_visible/.read_string
nouveau/hwmon: Remove old code, add .write/.read ope
Hi Ben,
I'll fix the warnings.
Thanks for the time
Regards
Oscar Salvador
On 17 May 2017 at 01:06, Ben Skeggs <skeg...@gmail.com> wrote:
> On 05/17/2017 07:18 AM, Oscar Salvador wrote:
>>
>> This v7 fixes removes dummy functions which only had a return and moves
>>
This patch removes old code related to the old api and transforms the
functions for the new api. It also adds the .write and .read operations.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu
_register_with_info.
It also does some cleanup.
Oscar Salvador (5):
nouveau/hwmon: Add config for all sensors and their settings
nouveau/hwmon: Add nouveau_hwmon_ops structure with
.is_visible/.read_string
nouveau/hwmon: Remove old code, add .write/.read operations
nouveau/hwmon: expos
This patch replaces the symbolic permissions with the numeric ones.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 10 +-
1 file changed, 5 insertions(+), 5 deleti
This is a preparation for the next patches. It just adds the sensors with
their possible configurable settings and then fills the struct
hwmon_channel_info
with all this information.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe..
or pwm_min/max attrs.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/d
to make easier the review of all patches.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 163
1 file changed, 163 insertions(+)
diff --git a
or pwm_min/max attrs.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/d
This patch replaces the symbolic permissions with the numeric ones.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 10 +-
1 file changed, 5 insertions(+), 5 deleti
to make easier the review of all patches.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 163
1 file changed, 163 insertions(+)
diff --git a
This patch removes old code related to the old api and transforms the
functions for the new api. It also adds the .write and .read operations.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe...@free.fr>
---
drivers/gpu
nouveau_temp_write
This patchseries replaces the deprecated hwmon_device_register function with the
new one hwmon_device_register_with_info.
It also does some cleanup.
Oscar Salvador (5):
nouveau/hwmon: Add config for all sensors and their settings
nouveau/hwmon: Add nouveau_hwmon_ops struc
This is a preparation for the next patches. It just adds the sensors with
their possible configurable settings and then fills the struct
hwmon_channel_info
with all this information.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
Reviewed-by: Martin Peres <martin.pe..
This patch creates a special group attributes for attrs like "*auto_point*".
We check if we have support for them, and if we do, we gather them all in
an attribute_group's structure which is the parameter regarding special groups
of hwmon_device_register_with_info.
Signed-off-by: Osca
This patch removes old code related to the old api and transforms the
functions for the new api. It also adds the .write and .read operations.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 722 +++-
This patch replaces the symbolic permissions with the numeric ones,
and adds me to the authors too.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/d
This is a preparation for the next patches. It just adds the sensors with
their possible configurable settings and then fills the struct
hwmon_channel_info
with all this information.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.
to make easier the review of all patches.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 170
1 file changed, 170 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
b/drivers/g
to struct attribute. Kbuild complains.
v4 -> v5:
* Drops a check for attr_set in "nouveau_temp_is_visible".
This patchseries replaces the deprecated hwmon_device_register function with the
new one hwmon_device_register_with_info.
It also does some cleanup.
Oscar Salvador (5)
This patch removes old code related to the old api and transforms the
functions for the new api. It also adds the .write and .read operations.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 722 +++-
This patch replaces the symbolic permissions with the numeric ones,
and adds me to the authors too.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/d
This patch creates a special group attributes for attrs like "*auto_point*".
We check if we have support for them, and if we do, we gather them all in
an attribute_group's structure which is the parameter regarding special groups
of hwmon_device_register_with_info.
Signed-off-by: Osca
to make easier the review of all patches.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 171
1 file changed, 171 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
b/drivers/g
This is a preparation for the next patches. It just adds the sensors with
their possible configurable settings and then fills the struct
hwmon_channel_info
with all this information.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.
e cleanup.
Oscar Salvador (5):
nouveau_hwmon: Add config for all sensors and their settings
nouveau_hwmon: Add nouveau_hwmon_ops structure with
.is_visible/.read_string
nouveau_hwmon: Remove old code, add .write/.read operations
nouveau_hwmon: Add support for auto_point attributes
nouv
s like *_auto_point*.
5/ Cleanup: Change permissions to numeric and add me to the author
Oscar Salvador (5):
nouveau_hwmon: Add config for all sensors and their settings
nouveau_hwmon: Add nouveau_hwmon_ops structure with
.is_visible/.read_string
nouveau_hwmon: Remove old code, add .write
This patch creates a special group attributes for attrs like "*auto_point*".
We check if we have support for them, and if we do, we gather them all in
an attribute_group's structure which is the parameter regarding special groups
of hwmon_device_register_with_info.
Signed-off-by: Osca
This patch replaces the symbolic permissions with the numeric ones,
and adds me to the authors too.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/d
This patch removes old code related to the old api and transforms the
functions for the new api. It also adds the .write and .read operations.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 722 +++-
to make easier the review of all patches.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 171
1 file changed, 171 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
b/drivers/g
This is a preparation for the next patches. It just adds the sensors with
their possible configurable settings and then fills the struct
hwmon_channel_info
with all this information.
Signed-off-by: Oscar Salvador <osalvador.vilard...@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.
I got what you meant. I"ll fix it
El dia 20/04/2017 08:47, "Oscar Salvador" <osalvador.vilard...@gmail.com>
va escriure:
> Hi Karol,
>
> I don't get what you mean with return due to fallthrough. I mean, I
> know what is it, but I don't see how I can do it
if (iccsense->power_w_crit)
return 0444;
default:
return 0;
}
Could you drop me a hint?
On 18 April 2017 at 09:56, Karol Herbst <karolher...@gmail.com> wrote:
> 2017-04-17 9:47 GMT+02:00 Oscar Salvador <osalvador.vilard...@gmai
-developer-s-certificate-of-origin
>
> On Mon, Apr 17, 2017 at 3:47 AM, Oscar Salvador
> <osalvador.vilard...@gmail.com> wrote:
>> This is a preparation for the next patches. It just adds the sensors with
>> their possible configurable settings and then fills the st
This patch creates a special group attributes for attrs like "*auto_point*".
We check if we have support for them, and if we do, we gather them all in
an attribute_group's structure which is the parameter regarding special groups
of hwmon_device_register_with_info.
---
This is a preparation for the next patches. It just adds the sensors with
their possible configurable settings and then fills the struct
hwmon_channel_info
with all this information.
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 72 +
1 file changed, 72
/nouveau_hwmon.c
index 655ae11..99e2a3a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
@@ -1,5 +1,6 @@
/*
- * Copyright 2010 Red Hat Inc.
+ * Copyright 2010 Red Hat Inc. (Ben Skeggs)
+ * Copyright 2017 Oscar Salvador
*
* Permission is hereby
support for special attributes like *_auto_point*.
5/ Cleanup: Change permissions to numeric and add me to the author
Oscar Salvador (5):
nouveau_hwmon: Add config for all sensors and their settings
nouveau_hwmon: Add nouveau_hwmon_ops structure with
.is_visible/.read_string
nouveau_hwmon
This patch removes old code related to the old api and transforms the
functions for the new api. It also adds the .write and .read operations.
Since we don't want to support changing hwmon_temp_* values, this patch
deletes all write-functions for these attributes too.
---
This patch introduces the nouveau_hwmon_ops structure, sets up
.is_visible and .read_string operations and adds all the functions
for these operations.
This is also a preparation for the next patches, where most of the
work is being done.
This code doesn't interacture with the old one.
It's just
her...@gmail.com> wrote:
> 2017-04-13 11:08 GMT+02:00 Oscar Salvador <osalvador.vilard...@gmail.com>:
>> This patch introduces the structure "struct hwmon_ops" and sets up the
>> ".visible" operation.
>> Is also a preparation for the next patch where al
y to review like this. And it isn't bisectable.
If there are clean ups here, please do it in a seperate patch. I
highly doubt that it all has to be done within one single big patch.
2017-04-11 18:54 GMT+02:00 Oscar Salvador <osalvador.vilard...@gmail.com>:
> Hi,
>
> this patch replace
This patch introduces the structure "struct hwmon_ops" and sets up the
".visible" operation.
Is also a preparation for the next patch.
--- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12
19:18:09.638073562 +0200
+++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-12
@@
/*
- * Copyright 2010 Red Hat Inc.
+ * Copyright 2010 Red Hat Inc. (Ben Skeggs)
+ * Copyright 2017 Oscar Salvador
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
@@ -
This patch creates special group attributes for special attrs like
"*auto_point*".
We check if we need them, and if we do, we set them up in special_groups
structure, that then
we pass to hwmon_device_register_with_info.
--- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-13
Here is where most of the work is being done.
We are replacing the old API with the new one, that means changing the
functions layout and remove unnecessary code.
We also set up the other operations:
.read
.write
.read_string
--- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-13
This patch introduces the structure "struct hwmon_ops" and sets up the
".visible" operation.
Is also a preparation for the next patch where all work is being done.
--- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12
19:22:29.070573187 +0200
+++
Hi again,
I've split the patches as Karol Herbst suggested.
I hope now it's fine.
This series of patches introduce the new hwmon_device_register_with_info
and gets rid of the old hwmon_device_register.
This patch adds the default sensors with their possible config values.
Just to prepare for
/drm/nouveau/nouveau_hwmon.c 2017-04-11
18:45:41.918688215 +0200
@@ -1,5 +1,6 @@
/*
- * Copyright 2010 Red Hat Inc.
+ * Copyright 2010 Red Hat Inc. (Ben Skeggs)
+ * Copyright 2017 Oscar Salvador
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy
55 matches
Mail list logo
