Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2024-01-04 Thread Randy Dunlap
On 1/2/24 19:10, Randy Dunlap wrote: > Hi Vegard, > > On 12/25/23 09:08, Randy Dunlap wrote: >> >> >> On 12/25/23 00:30, Vegard Nossum wrote: >>> >>> On 25/12/2023 08:40, Randy Dunlap wrote: >>>> I do see one thing that I don't l

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2024-01-02 Thread Randy Dunlap
Hi Vegard, On 12/25/23 09:08, Randy Dunlap wrote: > > > On 12/25/23 00:30, Vegard Nossum wrote: >> >> On 25/12/2023 08:40, Randy Dunlap wrote: >>> I do see one thing that I don't like in the generated html output. >>> It's not a pr

[PATCH 2/4] drm/nouveau: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
ed whenever a 32-bit process running under a 64(). Prototype was for nouveau_compat_ioctl() instead Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouveau@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- dri

[PATCH 1/4] drm/nouveau/disp: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
e/adjusted_mode pair. crtc.c:629: warning: missing initial short description on line: * Sets up registers for the given mode/adjusted_mode pair. Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouveau@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxim

[PATCH 4/4] drm/nouveau/volt/gk20a: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
62: warning: missing initial short description on line: * cvb_t_mv = Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouveau@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk

[PATCH 3/4] drm/nouveau/gr/gf100: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
le if it is disabled by the gf100.c:1044: warning: missing initial short description on line: * Wait until GR goes idle. GR is considered idle if it is disabled by the Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouveau@lists.freedesktop.org Cc: Maarten L

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2023-12-25 Thread Randy Dunlap
On 12/25/23 00:30, Vegard Nossum wrote: > > On 25/12/2023 08:40, Randy Dunlap wrote: >> I do see one thing that I don't like in the generated html output. >> It's not a problem with this patch. >> The #defines for DRM_NOUVEAU_VM_BIND_OP_MAP etc. have a ';' at

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2023-12-24 Thread Randy Dunlap
it cleaner if the #defines appeared between the kerneldoc > for the member and the member itself (which is something other DRM- > related UAPI docs do). > > - The %IDENTIFIER kerneldoc syntax is intended for "constants", and is > more appropriate in this context than

[PATCH] drm/nouveau/bios/init: drop kernel-doc notation

2023-12-18 Thread Randy Dunlap
init_done() instead Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: dri-de...@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm

Re: [Nouveau] [PATCH] drm/nouveau: fix kernel-doc warning

2023-10-08 Thread Randy Dunlap
Hi, On 10/8/23 00:06, Bragatheswaran Manickavel wrote: > Identified below document warning in latest linux-next. > ./include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand > * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX: on line 49 - I thought it was a doc line > > Also, on running checkpatch.pl to

[Nouveau] [PATCH v2] drm/nouveau: exec: fix ioctl kernel-doc warning

2023-10-08 Thread Randy Dunlap
and format the comment more like a kernel-doc comment for consistency. Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam") Signed-off-by: Randy Dunlap Cc: Dave Airlie Cc: Danilo Krummrich Cc: Karol Herbst Cc: Lyude Paul Cc: dri-de...@lists.freedes

[Nouveau] [PATCH] drm/nouveau: exec: fix ioctl kernel-doc warning

2023-10-06 Thread Randy Dunlap
include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX on line 49 - I thought it was a doc line Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam") Signed-off-by: Randy Dunlap Cc: Dave Airlie Cc: Danilo Krummrich

Re: [Nouveau] [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
On 3/17/22 08:47, Amit Shah wrote: > On Wed, 2022-03-16 at 12:20 -0700, Randy Dunlap wrote: >> Eliminate anonymous module_init() and module_exit(), which can lead to >> confusion or ambiguity when reading System.map, crashes/oops/bugs, >> or an initcall_debug log. >>

[Nouveau] [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: 4fe74b1cb051 ("[SCSI] virtio-scsi: SCSI driver for QEMU based virtual machines") Signed-off-by: Randy Dunlap Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Paolo Bonzini Cc: Stefan Hajnoczi Cc: "James E.J. Bottomley"

Re: [Nouveau] [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
On 3/16/22 20:29, Ira Weiny wrote: > On Wed, Mar 16, 2022 at 12:20:07PM -0700, Randy Dunlap wrote: >> Eliminate anonymous module_init() and module_exit(), which can lead to >> confusion or ambiguity when reading System.map, crashes/oops/bugs, >> or an initcall_debug

[Nouveau] [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: f587de0e2feb ("[NETFILTER]: nf_conntrack/nf_nat: add H.323 helper port") Signed-off-by: Randy Dunlap Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc: netfilter-de...@vger.kernel.org Cc: coret...@netfilter.org Cc: "

[Nouveau] [PATCH 7/9] usb: usbip: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: 80fd9cd52de6 ("usbip: vudc: Add VUDC main file") Signed-off-by: Randy Dunlap Cc: Krzysztof Opasiak Cc: Igor Kotrasinski Cc: Greg Kroah-Hartman Cc: Valentina Manea Cc: Shuah Khan Cc: Shuah Khan Cc: linux-...@vger.kernel.org --- drivers

[Nouveau] [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters") Signed-off-by: Randy Dunlap Cc: Eli Cohen Cc: Saeed Mahameed Cc: net...@vger.kernel.org Cc: Leon Romanovsky Cc: linux-r...@vger.kernel.org --- drivers/net/ethernet/mel

[Nouveau] [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: e467cde23818 ("Block driver using virtio.") Signed-off-by: Randy Dunlap Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Paolo Bonzini Cc: Stefan Hajnoczi Cc: virtualizat...@lists.linux-foundation.org Cc: Jens Axboe Cc: linux-b

[Nouveau] [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
There are a number of drivers that use "module_init(init)" and "module_exit(exit)", which are anonymous names and can lead to confusion or ambiguity when reading System.map, crashes/oops/bugs, or an initcall_debug log. Give each of these init and exit functions unique driver-specific names to

[Nouveau] [PATCH 8/9] x86/crypto: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
hould be static") Fixes: 8280daad436e ("crypto: twofish - add 3-way parallel x86_64 assembler implemention") Signed-off-by: Randy Dunlap Cc: Jussi Kivilinna Cc: Joachim Fritschi Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-cry...@vger.kernel.org Cc: x...@kern

[Nouveau] [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: 31610434bc35 ("Virtio console driver") Fixes: 7177876fea83 ("virtio: console: Add ability to remove module") Signed-off-by: Randy Dunlap Cc: Amit Shah Cc: virtualizat...@lists.linux-foundation.org Cc: Arnd Bergmann Cc

[Nouveau] [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: 8b7d89d02ef3 ("x86: mmiotrace - trace memory mapped IO") Signed-off-by: Randy Dunlap Cc: Thomas Gleixner Cc: Steven Rostedt Cc: Ingo Molnar Cc: Karol Herbst Cc: Pekka Paalanen Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc

Re: [Nouveau] [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
On 3/17/22 08:49, Pablo Neira Ayuso wrote: > On Wed, Mar 16, 2022 at 12:20:05PM -0700, Randy Dunlap wrote: >> Eliminate anonymous module_init() and module_exit(), which can lead to >> confusion or ambiguity when reading System.map, crashes/oops/bugs, >> or an initcall_debug

[Nouveau] [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit

2022-03-27 Thread Randy Dunlap
init+0x0/0x9a returned 0 after 74 usecs Fixes: bd25a14edb75 ("usb: gadget: legacy/serial: allow dynamic removal") Fixes: 7bb5ea54be47 ("usb gadget serial: use composite gadget framework") Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Randy Dunlap Cc: Felipe

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Randy Dunlap
On 7/23/21 8:15 AM, Karol Herbst wrote: > On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: >> >> On 7/23/21 2:15 AM, Arnd Bergmann wrote: >>> From: Arnd Bergmann >>> >>> When the backlight support is disabled, the driver fails to build: >&

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Randy Dunlap
On 7/23/21 2:15 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > When the backlight support is disabled, the driver fails to build: > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function > 'nv50_sor_atomic_disable': > drivers/gpu/drm/nouveau/dispnv50/disp.c:1665:59: error: 'struct >

[Nouveau] [PATCH -next] drm: nouveau: fix disp.c build when NOUVEAU_BACKLIGHT is not enabled

2021-07-14 Thread Randy Dunlap
disp.c:1662:22: warning: unused variable ‘drm’ [-Wunused-variable] struct nouveau_drm *drm = nouveau_drm(nv_encoder->base.base.dev); ^~~ Fixes: 6eca310e8924 ("drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau") Signed-off-by: Randy Dunlap

Re: [Nouveau] linux-next: Tree for Jun 10 (drivers/gpu/drm/nouveau/dispnv50/disp.c)

2021-06-10 Thread Randy Dunlap
On 6/10/21 2:48 AM, Stephen Rothwell wrote: Hi all, Changes since 20210609: on x86_64: ../drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_sor_atomic_disable’: ../drivers/gpu/drm/nouveau/dispnv50/disp.c:1665:52: error: ‘struct nouveau_connector’ has no member named ‘backlight’

Re: [Nouveau] [PATCH] drm/nouveau/bios/init: A typo fix

2021-03-24 Thread Randy Dunlap
On 3/23/21 11:34 PM, Bhaskar Chowdhury wrote: > > s/conditon/condition/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

Re: [Nouveau] [PATCH 01/30] drm/dp: Rewrap kdocs for struct drm_dp_aux

2021-02-19 Thread Randy Dunlap
On 2/19/21 1:52 PM, Lyude Paul wrote: > Since we're about to be adding some more fields and update this > documentation, let's rewrap it to the new column limit of 100 beforehand. > No actual doc or functional changes are made here. > The preferred column limit is still 80. For some (exceptional)

Re: [Nouveau] [PATCH 02/30] drm/dp: Fixup kernel docs for struct drm_dp_aux

2021-02-19 Thread Randy Dunlap
nt values with % so they're formatted > correctly > > Signed-off-by: Lyude Paul Acked-by: Randy Dunlap Thanks. > --- > include/drm/drm_dp_helper.h | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > -- ~Randy _

Re: [Nouveau] [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE

2020-05-08 Thread Randy Dunlap
^ > kernel/resource.c:1654:48: error: use of undeclared identifier > 'MAX_PHYSMEM_BITS' > > Add a dependency for Nouveau to avoid broken randconfig builds. > > Fixes: d2c63df2242e ("mm/hmm: make CONFIG_DEVICE_PRIVATE into a select") > Signed-off-by: Arnd Bergmann

Re: [Nouveau] mmotm 2020-01-21-13-28 uploaded (nouveau)

2020-01-23 Thread Randy Dunlap
pointer from integer without a cast [-Wint-conversion] spec = dev_iommu_fwspec_get(device->dev); ^ ../drivers/gpu/drm/nouveau/nvkm/subdev/ltc/gp10b.c:39:17: error: ‘struct iommu_fwspec’ has no member named ‘ids’ u32 sid = spec->ids[0] & 0x; ^~ Full randcon

[Nouveau] [PATCH] MAINTAINERS: nouveau mailing list is moderated

2020-01-17 Thread Randy Dunlap
From: Randy Dunlap Mark the nouveau@ mailing list as moderated for non-subscribers. Signed-off-by: Randy Dunlap --- MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200116.orig/MAINTAINERS +++ linux-next-20200116/MAINTAINERS @@ -5315,7 +5315,7 @@ F

Re: [Nouveau] linux-next: Tree for Jan 16 (drivers/gpu/drm/nouveau/nvkm/subdev/ltc/gp10b.c)

2020-01-17 Thread Randy Dunlap
-conversion] spec = dev_iommu_fwspec_get(device->dev); ^ ../drivers/gpu/drm/nouveau/nvkm/subdev/ltc/gp10b.c:39:17: error: ‘struct iommu_fwspec’ has no member named ‘ids’ u32 sid = spec->ids[0] & 0x; ^~ Full randconfig file is attached. -- ~Randy Reported-by