Re: [Nouveau] [PATCH] drm/nouveau/nvkm: do not use assignment in if condition

2023-07-13 Thread Karol Herbst
On Mon, Jul 10, 2023 at 9:23 AM wrote: > > Assignments in if condition are less readable and error-prone. Fixes > also checkpatch warning: > > ERROR: do not use assignment in if condition > > Signed-off-by:Ran Sun > --- > drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++- > 1 file

[Nouveau] [PATCH] drm/nouveau/nvkm: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by:Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Nouveau] [PATCH] drm/nouveau/nvkm: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git