Re: [Nouveau] [PATCH] drm/nouveau/pm: Prevent overflow in nouveau_perf_init()

2011-06-18 Thread Emil Velikov
On Fri, 2011-06-17 at 10:14 +1000, Ben Skeggs wrote: On Thu, 2011-06-16 at 23:40 +0100, Emil Velikov wrote: On Thu, 16 Jun 2011 04:43:59 +0100, Ben Skeggs skeg...@gmail.com wrote: On Sat, 2011-06-11 at 13:30 +0100, Emil Velikov wrote: While parsing the perf table, there is no check if

Re: [Nouveau] [PATCH] drm/nouveau/pm: Prevent overflow in nouveau_perf_init()

2011-06-11 Thread Martin Peres
Le 11/06/2011 14:30, Emil Velikov a écrit : + if (entries NOUVEAU_PM_MAX_LEVEL) { + NV_DEBUG(dev, perf table has too many entries - buggy vbios?\n); + entries = NOUVEAU_PM_MAX_LEVEL; + } + I would suggest using NV_ERROR or INFO. How will we get buggy