Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-27 Thread Karol Herbst
On Thu, Jul 22, 2021 at 5:10 AM Ratchanan Srirattanamet wrote: > > The call site of nouveau_dsm_pci_probe() uses single set of output > variables for all invocations. So, we must not write anything to them > until we think this is an NVIDIA device of interest. Otherwise, if we > are called with

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
On Thu, Jul 22, 2021 at 9:54 PM Karol Herbst wrote: > > On Thu, Jul 22, 2021 at 9:49 PM Ratchanan Srirattanamet > wrote: > > > > Hello, > > > > เมื่อ 22/7/64 เวลา 23:36 Karol Herbst เขียนว่า: > > > hey, thanks for the patch. But I am a bit confused on why that patch > > > actually helps. It

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
On Thu, Jul 22, 2021 at 9:49 PM Ratchanan Srirattanamet wrote: > > Hello, > > เมื่อ 22/7/64 เวลา 23:36 Karol Herbst เขียนว่า: > > hey, thanks for the patch. But I am a bit confused on why that patch > > actually helps. It should only be called for nvidia GPUs, but are we > > ending up checking it

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Ratchanan Srirattanamet
Hello, เมื่อ 22/7/64 เวลา 23:36 Karol Herbst เขียนว่า: hey, thanks for the patch. But I am a bit confused on why that patch actually helps. It should only be called for nvidia GPUs, but are we ending up checking it for AMD GPUs as well? This is the call site of nouveau_dsm_pci_probe() in

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
hey, thanks for the patch. But I am a bit confused on why that patch actually helps. It should only be called for nvidia GPUs, but are we ending up checking it for AMD GPUs as well? Mind posting the output of lspci -tvnn? On Thu, Jul 22, 2021 at 5:10 AM Ratchanan Srirattanamet wrote: > > The

[Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-21 Thread Ratchanan Srirattanamet
The call site of nouveau_dsm_pci_probe() uses single set of output variables for all invocations. So, we must not write anything to them until we think this is an NVIDIA device of interest. Otherwise, if we are called with another device after the NVIDIA device, we'll clober the result of the