Re: [Nouveau] [PATCH 03/32] therm: Split return code and value in nvkm_get_temp

2017-11-22 Thread Karol Herbst
On Wed, Nov 22, 2017 at 9:29 AM, Martin Peres wrote: > On 22/11/17 03:42, Karol Herbst wrote: >> On Wed, Nov 22, 2017 at 1:32 AM, Martin Peres wrote: >>> On 17/11/17 02:04, Karol Herbst wrote: The current hwmon code doesn't check if the returned

Re: [Nouveau] [PATCH 03/32] therm: Split return code and value in nvkm_get_temp

2017-11-22 Thread Martin Peres
On 22/11/17 03:42, Karol Herbst wrote: > On Wed, Nov 22, 2017 at 1:32 AM, Martin Peres wrote: >> On 17/11/17 02:04, Karol Herbst wrote: >>> The current hwmon code doesn't check if the returned value was actually an >>> error. >>> >>> Since Kepler temperature sensors are able

Re: [Nouveau] [PATCH 03/32] therm: Split return code and value in nvkm_get_temp

2017-11-21 Thread Karol Herbst
On Wed, Nov 22, 2017 at 1:32 AM, Martin Peres wrote: > On 17/11/17 02:04, Karol Herbst wrote: >> The current hwmon code doesn't check if the returned value was actually an >> error. >> >> Since Kepler temperature sensors are able to report negative values. Those >> negative

Re: [Nouveau] [PATCH 03/32] therm: Split return code and value in nvkm_get_temp

2017-11-21 Thread Martin Peres
On 17/11/17 02:04, Karol Herbst wrote: > The current hwmon code doesn't check if the returned value was actually an > error. > > Since Kepler temperature sensors are able to report negative values. Those > negative values are not for error reporting, but rather when you buried > your GPU in snow

[Nouveau] [PATCH 03/32] therm: Split return code and value in nvkm_get_temp

2017-11-16 Thread Karol Herbst
The current hwmon code doesn't check if the returned value was actually an error. Since Kepler temperature sensors are able to report negative values. Those negative values are not for error reporting, but rather when you buried your GPU in snow somewhere in Antarctica and still want a valid