[Nouveau] [PATCH 2/2] nv04-nv40: don't attempt to do 32-bit shifts

2015-05-19 Thread Ilia Mirkin
A 32-bit shift is a no-op, which will also make the new planemask get or'd with ~0, thus negating the usefulness of the subsequent planemask != ~0 check. Only do this if it's a less-than-32-bit per pixel format, in which case it will have the desired effect of setting the high bits.

Re: [Nouveau] [PATCH 2/2] nv04-nv40: don't attempt to do 32-bit shifts

2015-05-19 Thread Martin Peres
On 19/05/15 23:28, Ilia Mirkin wrote: A 32-bit shift is a no-op, which will also make the new planemask get or'd with ~0, thus negating the usefulness of the subsequent planemask != ~0 check. Only do this if it's a less-than-32-bit per pixel format, in which case it will have the desired effect

Re: [Nouveau] [PATCH 2/2] nv04-nv40: don't attempt to do 32-bit shifts

2015-05-19 Thread Ilia Mirkin
On Tue, May 19, 2015 at 4:35 PM, Martin Peres martin.pe...@free.fr wrote: On 19/05/15 23:28, Ilia Mirkin wrote: A 32-bit shift is a no-op, which will also make the new planemask get or'd with ~0, thus negating the usefulness of the subsequent planemask != ~0 check. Only do this if it's a