Re: [Nouveau] [PATCH 2/4] drm/plane: Allocate planes with drm_universal_plane_alloc()

2022-09-20 Thread Javier Martinez Canillas
On 9/16/22 13:41, Thomas Zimmermann wrote: [...] >> >>> + * @dev: DRM device >>> + * @type: the type of the struct which contains struct _plane >>> + * @member: the name of the _plane within @type >>> + * @possible_crtcs: bitmask of possible CRTCs >>> + * @funcs: callbacks for the new plane >>>

Re: [Nouveau] [PATCH 2/4] drm/plane: Allocate planes with drm_universal_plane_alloc()

2022-09-20 Thread Javier Martinez Canillas
On 9/9/22 12:59, Thomas Zimmermann wrote: > Provide drm_univeral_plane_alloc(), which allocated an initializes a > plane. Code for non-atomic drivers uses this pattern. Convert it to > the new function. The modeset helpers contain a quirk for handling their > color formats differently. Set the

Re: [Nouveau] [PATCH 2/4] drm/plane: Allocate planes with drm_universal_plane_alloc()

2022-09-19 Thread Laurent Pinchart
Hi Thomas, On Fri, Sep 16, 2022 at 01:31:25PM +0200, Thomas Zimmermann wrote: > Am 16.09.22 um 13:06 schrieb Laurent Pinchart: > > On Fri, Sep 09, 2022 at 12:59:45PM +0200, Thomas Zimmermann wrote: > >> Provide drm_univeral_plane_alloc(), which allocated an initializes a > >> plane. Code for

Re: [Nouveau] [PATCH 2/4] drm/plane: Allocate planes with drm_universal_plane_alloc()

2022-09-16 Thread Thomas Zimmermann
Hi Am 16.09.22 um 13:22 schrieb Javier Martinez Canillas: On 9/9/22 12:59, Thomas Zimmermann wrote: Provide drm_univeral_plane_alloc(), which allocated an initializes a plane. Code for non-atomic drivers uses this pattern. Convert it to the new function. The modeset helpers contain a quirk for

Re: [Nouveau] [PATCH 2/4] drm/plane: Allocate planes with drm_universal_plane_alloc()

2022-09-16 Thread Thomas Zimmermann
Hi Am 16.09.22 um 13:06 schrieb Laurent Pinchart: Hi Thomas, Thank you for the patch. On Fri, Sep 09, 2022 at 12:59:45PM +0200, Thomas Zimmermann wrote: Provide drm_univeral_plane_alloc(), which allocated an initializes a plane. Code for non-atomic drivers uses this pattern. Convert it to

Re: [Nouveau] [PATCH 2/4] drm/plane: Allocate planes with drm_universal_plane_alloc()

2022-09-16 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Sep 09, 2022 at 12:59:45PM +0200, Thomas Zimmermann wrote: > Provide drm_univeral_plane_alloc(), which allocated an initializes a > plane. Code for non-atomic drivers uses this pattern. Convert it to > the new function. The modeset helpers contain a

[Nouveau] [PATCH 2/4] drm/plane: Allocate planes with drm_universal_plane_alloc()

2022-09-09 Thread Thomas Zimmermann
Provide drm_univeral_plane_alloc(), which allocated an initializes a plane. Code for non-atomic drivers uses this pattern. Convert it to the new function. The modeset helpers contain a quirk for handling their color formats differently. Set the flag outside plane allocation. The new function is