Re: [Nouveau] [PATCH v2] nouveau/dispnv50: add cursor pitch check

2021-02-05 Thread Simon Ser
On Friday, February 5th, 2021 at 10:50 PM, Ilia Mirkin wrote: > > return head->func->curs_format(head, asyw, asyh); > > While you're at it, maybe give this one some love too? Sure, although this would be a driver bug because DRM core already checks the format. curs_format has WARN_ON when it

Re: [Nouveau] [PATCH v2] nouveau/dispnv50: add cursor pitch check

2021-02-05 Thread Ilia Mirkin
On Fri, Feb 5, 2021 at 4:00 PM Simon Ser wrote: > > The hardware needs a FB which is packed. Add checks to make sure > this is the case. > > While at it, add debug logs for the existing checks. This allows > user-space to more easily figure out why a configuration is > rejected. > > v2: > - Use

Re: [Nouveau] [PATCH v2] nouveau/dispnv50: add cursor pitch check

2021-02-05 Thread Lyude Paul
On Fri, 2021-02-05 at 22:00 +0100, Simon Ser wrote: > The hardware needs a FB which is packed. Add checks to make sure > this is the case. > > While at it, add debug logs for the existing checks. This allows > user-space to more easily figure out why a configuration is > rejected. > > v2: > -

[Nouveau] [PATCH v2] nouveau/dispnv50: add cursor pitch check

2021-02-05 Thread Simon Ser
The hardware needs a FB which is packed. Add checks to make sure this is the case. While at it, add debug logs for the existing checks. This allows user-space to more easily figure out why a configuration is rejected. v2: - Use drm_format_info instead of hardcoding bytes-per-pixel (Ilia) -