Re: [Nouveau] [PATCH v3] nouveau/dispnv50: add cursor pitch check

2021-02-05 Thread Simon Ser
On Friday, February 5th, 2021 at 11:36 PM, Ilia Mirkin wrote: > > --- a/drivers/gpu/drm/nouveau/dispnv50/curs507a.c > > +++ b/drivers/gpu/drm/nouveau/dispnv50/curs507a.c > > @@ -30,6 +30,7 @@ > > > > #include > > #include > > +#include > > Why is this needed? This is needed for the

Re: [Nouveau] [PATCH v3] nouveau/dispnv50: add cursor pitch check

2021-02-05 Thread Lyude Paul
On Fri, 2021-02-05 at 17:36 -0500, Ilia Mirkin wrote: > On Fri, Feb 5, 2021 at 5:24 PM Simon Ser wrote: > > > > The hardware needs a FB which is packed. Add checks to make sure > > this is the case. > > > > While at it, add debug logs for the existing checks. This allows > > user-space to more

Re: [Nouveau] [PATCH v3] nouveau/dispnv50: add cursor pitch check

2021-02-05 Thread Ilia Mirkin
On Fri, Feb 5, 2021 at 5:24 PM Simon Ser wrote: > > The hardware needs a FB which is packed. Add checks to make sure > this is the case. > > While at it, add debug logs for the existing checks. This allows > user-space to more easily figure out why a configuration is > rejected. > > v2: > - Use

[Nouveau] [PATCH v3] nouveau/dispnv50: add cursor pitch check

2021-02-05 Thread Simon Ser
The hardware needs a FB which is packed. Add checks to make sure this is the case. While at it, add debug logs for the existing checks. This allows user-space to more easily figure out why a configuration is rejected. v2: - Use drm_format_info instead of hardcoding bytes-per-pixel (Ilia) -