Re: [Nouveau] [RFC PATCH 5/5] clk: allow boosting only when NvBoost is set

2015-12-02 Thread Emil Velikov
On 2 December 2015 at 12:24, Karol Herbst wrote: >> Pierre Moreau hat am 2. Dezember 2015 um 02:26 >> geschrieben: >> You only listed values 0, 1, 2 in the commit message, so what is -1 for? >> Disabling nvboost is already taken care by 0, so it's something else. runpm >> uses it for auto mode,

Re: [Nouveau] [RFC PATCH 5/5] clk: allow boosting only when NvBoost is set

2015-12-02 Thread Karol Herbst
> Pierre Moreau hat am 2. Dezember 2015 um 02:26 > geschrieben: > > Hi Karol, > > I have some comments below. > > On 05:42 PM - Dec 01 2015, Karol Herbst wrote: > > 0: disable boosting (cap to base clock from the vbios) > > 1: boost only to boost clock from the vbios > > 2: boost to max clock a

Re: [Nouveau] [RFC PATCH 5/5] clk: allow boosting only when NvBoost is set

2015-12-01 Thread Pierre Moreau
Hi Karol, I have some comments below. On 05:42 PM - Dec 01 2015, Karol Herbst wrote: > 0: disable boosting (cap to base clock from the vbios) > 1: boost only to boost clock from the vbios > 2: boost to max clock available > --- > drm/nouveau/include/nvkm/subdev/clk.h | 10 +- > drm/nouve

[Nouveau] [RFC PATCH 5/5] clk: allow boosting only when NvBoost is set

2015-12-01 Thread Karol Herbst
0: disable boosting (cap to base clock from the vbios) 1: boost only to boost clock from the vbios 2: boost to max clock available --- drm/nouveau/include/nvkm/subdev/clk.h | 10 +- drm/nouveau/nvkm/subdev/clk/base.c| 17 - drm/nouveau/nvkm/subdev/clk/gf100.c | 2 +-