Re: [Nouveau] Off-by-one or bad BIOS image? Apple eMac 800 GeForce 2MX

2022-01-20 Thread Ilia Mirkin
t; Subject: Re: [Nouveau] Off-by-one or bad BIOS image? Apple eMac 800 GeForce > 2MX > > > > This stuff is always so confusing. Let's think this through if > > bios size is 4, and we're trying to read a 4-byte thing starting at > > address 0, that _ought_ to work, I th

Re: [Nouveau] Off-by-one or bad BIOS image? Apple eMac 800 GeForce 2MX

2022-01-20 Thread Ilia Mirkin
This stuff is always so confusing. Let's think this through if bios size is 4, and we're trying to read a 4-byte thing starting at address 0, that _ought_ to work, I think. So in my strawman case, bios->size == 4, and size == 4. So we should only error if size > bios->size, not if they're ==.