Re: [Nouveau] [PATCH] drm/nouveau: sched: fix leaking memory of timedout job

2023-09-18 Thread Dave Airlie
On Sun, 17 Sept 2023 at 02:28, Danilo Krummrich wrote: > > Always stop and re-start the scheduler in order to let the scheduler > free up the timedout job in case it got signaled. In case of exec jobs > the job type specific callback will take care to signal all fences and > tear down the

Re: [Nouveau] [PATCH] drm/nouveau: sched: fix leaking memory of timedout job

2023-09-18 Thread Danilo Krummrich
On 9/19/23 00:19, Lyude Paul wrote: BTW - Would you like me to review work like this? I'm totally happy to do that, although I'm not terribly familiar with these parts of nouveau/drm (but I'm always willing to learn, and would like to know more about these areas anyway :) Of course, that's

Re: [Nouveau] [PATCH] drm/nouveau: sched: fix leaking memory of timedout job

2023-09-18 Thread Lyude Paul
BTW - Would you like me to review work like this? I'm totally happy to do that, although I'm not terribly familiar with these parts of nouveau/drm (but I'm always willing to learn, and would like to know more about these areas anyway :) …if the answer is yes, this patch looks fine to me so far -