Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-08 Thread Thierry Reding
On Thu, Jan 08, 2015 at 11:32:06AM +0200, Peter De Schrijver wrote: And specify the dependencies between domains in DT? I think the dependencies could be in the driver. Of course the power domains are per-SoC data, so really shouldn't be in the DTS either (the data is all implied by

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-08 Thread Thierry Reding
On Thu, Jan 08, 2015 at 11:39:57AM +0200, Peter De Schrijver wrote: And specify the dependencies between domains in DT? I think the dependencies could be in the driver. Of course the power domains are per-SoC data, so really shouldn't be in the DTS either (the data is all implied by

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-08 Thread Peter De Schrijver
On Thu, Jan 08, 2015 at 12:41:54PM +0100, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Jan 08, 2015 at 11:32:06AM +0200, Peter De Schrijver wrote: And specify the dependencies between domains in DT? I think the dependencies could be in the driver. Of course the power

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-08 Thread Thierry Reding
On Thu, Jan 08, 2015 at 12:25:18PM +0800, Vince Hsu wrote: On 01/07/2015 10:48 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Wed, Jan 07, 2015 at 10:28:29PM +0800, Vince Hsu wrote: On 04:08:52PM Jan 07, Peter De Schrijver wrote: On Wed, Jan 07, 2015 at 02:27:10PM +0100,

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-08 Thread Peter De Schrijver
And specify the dependencies between domains in DT? I think the dependencies could be in the driver. Of course the power domains are per-SoC data, so really shouldn't be in the DTS either (the data is all implied by the compatible value) but there's no good way to get at the clocks and

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-08 Thread Peter De Schrijver
And specify the dependencies between domains in DT? I think the dependencies could be in the driver. Of course the power domains are per-SoC data, so really shouldn't be in the DTS either (the data is all implied by the compatible value) but there's no good way to The clock references

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Peter De Schrijver
On Mon, Jan 05, 2015 at 04:09:33PM +0100, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Dec 25, 2014 at 10:28:08AM +0800, Vince Hsu wrote: On 12/24/2014 09:16 PM, Lucas Stach wrote: Am Dienstag, den 23.12.2014, 18:39 +0800 schrieb Vince Hsu: The Tegra124 and later Tegra

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Vince Hsu
On 01/07/2015 06:19 PM, Peter De Schrijver wrote: On Mon, Jan 05, 2015 at 04:09:33PM +0100, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Dec 25, 2014 at 10:28:08AM +0800, Vince Hsu wrote: On 12/24/2014 09:16 PM, Lucas Stach wrote: Am Dienstag, den 23.12.2014, 18:39 +0800

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Vince Hsu
On 01/07/2015 10:48 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Wed, Jan 07, 2015 at 10:28:29PM +0800, Vince Hsu wrote: On 04:08:52PM Jan 07, Peter De Schrijver wrote: On Wed, Jan 07, 2015 at 02:27:10PM +0100, Thierry Reding wrote: Yeah. I plan to have the information of

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Vince Hsu
On 01/07/2015 11:12 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Wed, Jan 07, 2015 at 10:19:52PM +0800, Vince Hsu wrote: On 04:12:54PM Jan 07, Peter De Schrijver wrote: On Wed, Jan 07, 2015 at 06:49:27PM +0800, Vince Hsu wrote: On 01/07/2015 06:19 PM, Peter De Schrijver

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Thierry Reding
On Wed, Jan 07, 2015 at 06:49:27PM +0800, Vince Hsu wrote: On 01/07/2015 06:19 PM, Peter De Schrijver wrote: On Mon, Jan 05, 2015 at 04:09:33PM +0100, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Dec 25, 2014 at 10:28:08AM +0800, Vince Hsu wrote: On 12/24/2014 09:16 PM,

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Peter De Schrijver
On Wed, Jan 07, 2015 at 06:49:27PM +0800, Vince Hsu wrote: On 01/07/2015 06:19 PM, Peter De Schrijver wrote: On Mon, Jan 05, 2015 at 04:09:33PM +0100, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Dec 25, 2014 at 10:28:08AM +0800, Vince Hsu wrote: On 12/24/2014 09:16 PM,

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Vince Hsu
On 04:12:54PM Jan 07, Peter De Schrijver wrote: On Wed, Jan 07, 2015 at 06:49:27PM +0800, Vince Hsu wrote: On 01/07/2015 06:19 PM, Peter De Schrijver wrote: On Mon, Jan 05, 2015 at 04:09:33PM +0100, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Dec 25, 2014 at

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Thierry Reding
On Wed, Jan 07, 2015 at 10:19:52PM +0800, Vince Hsu wrote: On 04:12:54PM Jan 07, Peter De Schrijver wrote: On Wed, Jan 07, 2015 at 06:49:27PM +0800, Vince Hsu wrote: On 01/07/2015 06:19 PM, Peter De Schrijver wrote: On Mon, Jan 05, 2015 at 04:09:33PM +0100, Thierry Reding wrote: *

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Peter De Schrijver
On Wed, Jan 07, 2015 at 02:27:10PM +0100, Thierry Reding wrote: Yeah. I plan to have the information of all the clock client of the partitions and the memory clients be defined statically in c source, e.g. pmc-tegra124.c. All modules can declare which domain they belong to in DT. One

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Vince Hsu
On 04:08:52PM Jan 07, Peter De Schrijver wrote: On Wed, Jan 07, 2015 at 02:27:10PM +0100, Thierry Reding wrote: Yeah. I plan to have the information of all the clock client of the partitions and the memory clients be defined statically in c source, e.g. pmc-tegra124.c. All modules

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-07 Thread Thierry Reding
On Wed, Jan 07, 2015 at 10:28:29PM +0800, Vince Hsu wrote: On 04:08:52PM Jan 07, Peter De Schrijver wrote: On Wed, Jan 07, 2015 at 02:27:10PM +0100, Thierry Reding wrote: Yeah. I plan to have the information of all the clock client of the partitions and the memory clients be

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-06 Thread Thierry Reding
On Tue, Jan 06, 2015 at 10:11:41AM +0800, Vince Hsu wrote: On 01/05/2015 11:09 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Dec 25, 2014 at 10:28:08AM +0800, Vince Hsu wrote: On 12/24/2014 09:16 PM, Lucas Stach wrote: Am Dienstag, den 23.12.2014, 18:39 +0800 schrieb

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-06 Thread Thierry Reding
On Tue, Jan 06, 2015 at 08:03:03PM +0800, Vince Hsu wrote: On 01/06/2015 07:15 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Tue, Jan 06, 2015 at 10:11:41AM +0800, Vince Hsu wrote: On 01/05/2015 11:09 PM, Thierry Reding wrote: Old Signed by an unknown key On Thu, Dec 25, 2014

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-06 Thread Vince Hsu
On 01/06/2015 07:15 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Tue, Jan 06, 2015 at 10:11:41AM +0800, Vince Hsu wrote: On 01/05/2015 11:09 PM, Thierry Reding wrote: Old Signed by an unknown key On Thu, Dec 25, 2014 at 10:28:08AM +0800, Vince Hsu wrote: On 12/24/2014 09:16

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-06 Thread Vince Hsu
On 02:29:32PM Jan 06, Thierry Reding wrote: * PGP Signed by an unknown key On Tue, Jan 06, 2015 at 08:03:03PM +0800, Vince Hsu wrote: On 01/06/2015 07:15 PM, Thierry Reding wrote: Old Signed by an unknown key On Tue, Jan 06, 2015 at 10:11:41AM +0800, Vince Hsu wrote: On 01/05/2015

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-05 Thread Vince Hsu
On 01/05/2015 11:09 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Dec 25, 2014 at 10:28:08AM +0800, Vince Hsu wrote: On 12/24/2014 09:16 PM, Lucas Stach wrote: Am Dienstag, den 23.12.2014, 18:39 +0800 schrieb Vince Hsu: The Tegra124 and later Tegra SoCs have a sepatate

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2015-01-04 Thread Vince Hsu
On 12/31/2014 12:42 AM, Lucas Stach wrote: Am Montag, den 29.12.2014, 10:49 +0800 schrieb Vince Hsu: [...] That's a read fence to assure the post of the previous writes through Tegra interconnect. (copy-paster from

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2014-12-30 Thread Lucas Stach
Am Montag, den 29.12.2014, 10:49 +0800 schrieb Vince Hsu: [...] That's a read fence to assure the post of the previous writes through Tegra interconnect. (copy-paster from https://android.googlesource.com/kernel/tegra.git/+/28b107dcb3aa122de8e94e48af548140d519298f) I see what it does,

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2014-12-28 Thread Vince Hsu
On 12/26/2014 04:34 AM, Lucas Stach wrote: Am Donnerstag, den 25.12.2014, 10:28 +0800 schrieb Vince Hsu: On 12/24/2014 09:16 PM, Lucas Stach wrote: Am Dienstag, den 23.12.2014, 18:39 +0800 schrieb Vince Hsu: The Tegra124 and later Tegra SoCs have a sepatate rail gating register to

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2014-12-25 Thread Lucas Stach
Am Donnerstag, den 25.12.2014, 10:28 +0800 schrieb Vince Hsu: On 12/24/2014 09:16 PM, Lucas Stach wrote: Am Dienstag, den 23.12.2014, 18:39 +0800 schrieb Vince Hsu: The Tegra124 and later Tegra SoCs have a sepatate rail gating register to enable/disable the clamp. The original function

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2014-12-24 Thread Lucas Stach
Am Dienstag, den 23.12.2014, 18:39 +0800 schrieb Vince Hsu: The Tegra124 and later Tegra SoCs have a sepatate rail gating register to enable/disable the clamp. The original function tegra_powergate_remove_clamping() is not sufficient for the enable function. So add a new function which is

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2014-12-24 Thread Dmitry Osipenko
I think ARM: tegra: is wrong prefix for this patch and soc: tegra: should be used instead to show that it belongs to SoC driver, not arch code. -- Dmitry ___ Nouveau mailing list Nouveau@lists.freedesktop.org

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2014-12-24 Thread Vince Hsu
On 12/24/2014 09:52 PM, Dmitry Osipenko wrote: I think ARM: tegra: is wrong prefix for this patch and soc: tegra: should be used instead to show that it belongs to SoC driver, not arch code. Indeed. Will fix in v2. Thanks, Vince ___ Nouveau mailing

Re: [Nouveau] [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

2014-12-24 Thread Vince Hsu
On 12/24/2014 09:16 PM, Lucas Stach wrote: Am Dienstag, den 23.12.2014, 18:39 +0800 schrieb Vince Hsu: The Tegra124 and later Tegra SoCs have a sepatate rail gating register to enable/disable the clamp. The original function tegra_powergate_remove_clamping() is not sufficient for the enable