Re: [Nouveau] NVAC "No Signal"

2016-10-19 Thread Ben Skeggs


On 10/20/2016 03:58 AM, Pierre Moreau wrote:
> Hello,
> 
> On 07:37 pm - Oct 19 2016, poma wrote:
>> On 19.10.2016 17:03, Karol Herbst wrote:
>>
>>> You don't get why I try to say. We have to actually find out when to
>>> apply this workaround, not to create some silly whitelist/blacklist.
>>> It's the last option, we never want to actually use.
>>>
>>
>> Well if you do not say, who can understand!? :)
>> Besides, you can mock with "silly" whitelist/blacklist", however there is 
>> nothing wrong with the method as such, it is used practically everywhere.
>>
>>> And even if we would have to create such lists, who tells us, that if
>>> affects every GPU with your device id? Usually quirks are applied
>>> depending on the sub-vendor-id and sub-device-id if actually required.
>>>
>>> In the end we need something like this: If byte X in table Y is set in
>>> the vbios or if bits A-B in reg Z in the MMIO space are set to
>>> whatever, we have to apply that workaround.
>>>
>>> In the end we should also wait until Ben replies, because he might
>>> know the exact reasons why this workaround was actually needed.
I'd like to see a mmiotrace of the NVIDIA binary driver on a system
where this WAR breaks things.  I applied it to all the GPUs that NVIDIA
told me required it.

Ben.

>>>
>>
>> If you eager to leave it broken even more than three months that have 
>> already been passed since the original commit ...
>>
>>> We might have a GPU with the same chipset like yours and we might be
>>> able to verify the issue
>>>
>>
>> Ah, I see.
>> You do not have confidence in my test results, good to know.
> 
> Testing on another GPU with the same chipset does not mean he does not trust
> your results. For example, my laptop (which also has an NVAC) has been
> triggering the no-signal message on external monitors way before Ben’s patch
> landed, but only for some adapters. I haven’t tried Ben’s patch yet, nor 
> yours,
> but I will certainly do it, and see what effect each of them has.
> 
> Regards,
> Pierre
> 
>>
>> Oh! Carol
>>
>>
>> ___
>> Nouveau mailing list
>> Nouveau@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/nouveau
>>
>>
>> ___
>> Nouveau mailing list
>> Nouveau@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/nouveau



signature.asc
Description: OpenPGP digital signature
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau


Re: [Nouveau] [PATCH 5/5] recognize and accelerate GM20x

2016-10-19 Thread Martin Peres

On 18/10/16 12:19, Alexandre Courbot wrote:

On Mon, Oct 17, 2016 at 6:47 PM, Samuel Pitoiset
 wrote:

This requires at least a quick test. :-)

Acked-by: Samuel Pitoiset 


On 10/16/2016 09:14 PM, Ilia Mirkin wrote:

Signed-off-by: Ilia Mirkin 
---

Untested. I don't have the hardware.

Tested on GM206, working great so far!

The series:
Tested-by: Alexandre Courbot 

What about the glyph issues you reported? Fixed by a new version?

Martin
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau


Re: [Nouveau] NVAC "No Signal"

2016-10-19 Thread Karol Herbst
2016-10-19 16:47 GMT+02:00 poma :
> On 18.10.2016 16:02, Karol Herbst wrote:
>> well, I just don't want that this fix breaks the same thing for other
>> users, that's why I am asking.
>>
>
> Affected device ID:
> https://github.com/skeggsb/nouveau/blob/master/drm/nouveau/nvkm/engine/device/pci.c#L1229
> can it be excluded from device->chipset case 0xac ?
>
> Care to create a patch?
> I'll test it.
>
>

You don't get why I try to say. We have to actually find out when to
apply this workaround, not to create some silly whitelist/blacklist.
It's the last option, we never want to actually use.

And even if we would have to create such lists, who tells us, that if
affects every GPU with your device id? Usually quirks are applied
depending on the sub-vendor-id and sub-device-id if actually required.

In the end we need something like this: If byte X in table Y is set in
the vbios or if bits A-B in reg Z in the MMIO space are set to
whatever, we have to apply that workaround.

In the end we should also wait until Ben replies, because he might
know the exact reasons why this workaround was actually needed.

We might have a GPU with the same chipset like yours and we might be
able to verify the issue
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau


Re: [Nouveau] NVAC "No Signal"

2016-10-19 Thread poma
On 18.10.2016 16:02, Karol Herbst wrote:
> well, I just don't want that this fix breaks the same thing for other
> users, that's why I am asking.
> 

Affected device ID:
https://github.com/skeggsb/nouveau/blob/master/drm/nouveau/nvkm/engine/device/pci.c#L1229
can it be excluded from device->chipset case 0xac ?

Care to create a patch?
I'll test it.


___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau


Re: [Nouveau] NVAC "No Signal"

2016-10-19 Thread poma
On 19.10.2016 17:03, Karol Herbst wrote:

> You don't get why I try to say. We have to actually find out when to
> apply this workaround, not to create some silly whitelist/blacklist.
> It's the last option, we never want to actually use.
> 

Well if you do not say, who can understand!? :)
Besides, you can mock with "silly" whitelist/blacklist", however there is 
nothing wrong with the method as such, it is used practically everywhere.

> And even if we would have to create such lists, who tells us, that if
> affects every GPU with your device id? Usually quirks are applied
> depending on the sub-vendor-id and sub-device-id if actually required.
> 
> In the end we need something like this: If byte X in table Y is set in
> the vbios or if bits A-B in reg Z in the MMIO space are set to
> whatever, we have to apply that workaround.
> 
> In the end we should also wait until Ben replies, because he might
> know the exact reasons why this workaround was actually needed.
> 

If you eager to leave it broken even more than three months that have already 
been passed since the original commit ...

> We might have a GPU with the same chipset like yours and we might be
> able to verify the issue
> 

Ah, I see.
You do not have confidence in my test results, good to know.

Oh! Carol


___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau


Re: [Nouveau] NVAC "No Signal"

2016-10-19 Thread Pierre Moreau
Hello,

On 07:37 pm - Oct 19 2016, poma wrote:
> On 19.10.2016 17:03, Karol Herbst wrote:
> 
> > You don't get why I try to say. We have to actually find out when to
> > apply this workaround, not to create some silly whitelist/blacklist.
> > It's the last option, we never want to actually use.
> > 
> 
> Well if you do not say, who can understand!? :)
> Besides, you can mock with "silly" whitelist/blacklist", however there is 
> nothing wrong with the method as such, it is used practically everywhere.
> 
> > And even if we would have to create such lists, who tells us, that if
> > affects every GPU with your device id? Usually quirks are applied
> > depending on the sub-vendor-id and sub-device-id if actually required.
> > 
> > In the end we need something like this: If byte X in table Y is set in
> > the vbios or if bits A-B in reg Z in the MMIO space are set to
> > whatever, we have to apply that workaround.
> > 
> > In the end we should also wait until Ben replies, because he might
> > know the exact reasons why this workaround was actually needed.
> > 
> 
> If you eager to leave it broken even more than three months that have already 
> been passed since the original commit ...
> 
> > We might have a GPU with the same chipset like yours and we might be
> > able to verify the issue
> > 
> 
> Ah, I see.
> You do not have confidence in my test results, good to know.

Testing on another GPU with the same chipset does not mean he does not trust
your results. For example, my laptop (which also has an NVAC) has been
triggering the no-signal message on external monitors way before Ben’s patch
landed, but only for some adapters. I haven’t tried Ben’s patch yet, nor yours,
but I will certainly do it, and see what effect each of them has.

Regards,
Pierre

> 
> Oh! Carol
> 
> 
> ___
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau


signature.asc
Description: PGP signature
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau