Hi Ben,
On Thu, 23 May 2019 at 01:19, Ben Skeggs wrote:
>
> On Thu, 23 May 2019 at 01:03, Emil Velikov wrote:
> >
> > From: Emil Velikov
> >
> > Cc: Ben Skeggs
> > Cc: nouveau@lists.freedesktop.org
> > Signed-off-by: Emil Velikov
> Thanks!
>
Sadly Dave reverted this, since the thanks wasn't s
Hi Jérôme, Ben, Felix and Jason,
below is a series against the hmm tree which cleans up various minor
bits and allows HMM_MIRROR to be built on all architectures.
Diffstat:
11 files changed, 94 insertions(+), 210 deletions(-)
A git tree is also available at:
git://git.infradead.org/us
The list is used to add the range to another list as an entry in the
core hmm code, and intended as a private member not exposed to drivers.
There is no need to initialize it in a driver.
Signed-off-by: Christoph Hellwig
Reviewed-by: Jason Gunthorpe
Reviewed-by: Felix Kuehling
---
drivers/gpu/
We'll need the nouveau_svmm structure to improve the function soon.
For now this allows using the svmm->mm reference to unlock the
mmap_sem, and thus the same dereference chain that the caller uses
to lock and unlock it.
Signed-off-by: Christoph Hellwig
---
drivers/gpu/drm/nouveau/nouveau_svm.c
There is only a single place where the pgmap is passed over a function
call, so replace it with local variables in the places where we deal
with the pgmap.
Signed-off-by: Christoph Hellwig
---
mm/hmm.c | 62
1 file changed, 27 insertions(+
Signed-off-by: Christoph Hellwig
Reviewed-by: Jason Gunthorpe
---
include/linux/hmm.h | 1 -
mm/hmm.c| 2 --
2 files changed, 3 deletions(-)
diff --git a/include/linux/hmm.h b/include/linux/hmm.h
index 82265118d94a..59be0aa2476d 100644
--- a/include/linux/hmm.h
+++ b/include/linux/h
The start, end and page_shift values are all saved in the range
structure, so we might as well use that for argument passing.
Signed-off-by: Christoph Hellwig
Reviewed-by: Jason Gunthorpe
Reviewed-by: Felix Kuehling
---
Documentation/vm/hmm.rst| 2 +-
drivers/gpu/drm/amd/amdgp
All users pass PAGE_SIZE here, and if we wanted to support single
entries for huge pages we should really just add a HMM_FAULT_HUGEPAGE
flag instead that uses the huge page size instead of having the
caller calculate that size once, just for the hmm code to verify it.
Signed-off-by: Christoph Hell
pte_index is an internal arch helper in various architectures,
without consistent semantics. Open code that calculation of a PMD
index based on the virtual address instead.
Signed-off-by: Christoph Hellwig
---
mm/hmm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/hmm.c
The pagewalk code already passes the value as the hmask parameter.
Signed-off-by: Christoph Hellwig
---
mm/hmm.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/mm/hmm.c b/mm/hmm.c
index f26d6abc4ed2..03d37e102e3b 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -771,19 +771,16
hmm_range_fault can only return -EAGAIN if called with the
HMM_FAULT_ALLOW_RETRY flag, which amdgpu never does. Remove the
handling for the -EAGAIN case with its non-standard locking scheme.
Signed-off-by: Christoph Hellwig
Reviewed-by: Jason Gunthorpe
Reviewed-by: Felix Kuehling
---
drivers/
There isn't really any architecture specific code in this page table
walk implementation, so drop the dependencies.
Signed-off-by: Christoph Hellwig
Reviewed-by: Jason Gunthorpe
---
mm/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/Kconfig b/mm/Kconfig
index 56
Stub out the whole function when CONFIG_TRANSPARENT_HUGEPAGE is not set
to make the function easier to read.
Signed-off-by: Christoph Hellwig
---
mm/hmm.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/mm/hmm.c b/mm/hmm.c
index 5e7afe685213..4aa7135f1094
Stub out the whole function and assign NULL to the .hugetlb_entry method
if CONFIG_HUGETLB_PAGE is not set, as the method won't ever be called in
that case.
Signed-off-by: Christoph Hellwig
Reviewed-by: Jason Gunthorpe
---
mm/hmm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
We only need the special pud_entry walker if PUD-sized hugepages and
pte mappings are supported, else the common pagewalk code will take
care of the iteration. Not implementing this callback reduced the
amount of code compiled for non-x86 platforms, and also fixes compile
failures with other archi
Make HMM_MIRROR an option that is selected by drivers wanting to use it
instead of a user visible option as it is just a low-level
implementation detail.
Signed-off-by: Christoph Hellwig
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +++-
drivers/gpu/drm/nouveau/Kconfig| 4 +++-
mm/Kconfig
The option is just used to select HMM mirror support and has a very
confusing help text. Just pull in the HMM mirror code by default
instead.
Signed-off-by: Christoph Hellwig
---
drivers/gpu/drm/Kconfig | 2 ++
drivers/gpu/drm/amd/amdgpu/Kconfig | 10 --
drivers/gp
I have a Gigabyte GeForce 1050 connected by DVI to a monitor (1920x1200
resolution @ 59.9502 Hz) and a TV via HDMI (3840x2160 @30 Hz).
The problem is the TV used to work at 59.9685 Hz but then it started
showing "No signal" on the TV.
I was changing settings trying to get it to work again and I
Hi James,
I semi-recently added support for HDMI 2.0 (in 4.20+, so you're good),
which is why you got 60Hz in the first place. In order for the high
rates to work, something called "scrambling" must be enabled. This is
done by 2-party agreement between the sink and the source. The sink
will inform
On 2019-08-06 12:32 p.m., Ilia Mirkin wrote:
Hi James,
I semi-recently added support for HDMI 2.0 (in 4.20+, so you're good),
which is why you got 60Hz in the first place. In order for the high
rates to work, something called "scrambling" must be enabled. This is
done by 2-party agreement betwee
I was going to buy a new cable and I came across this description:
>Category 2 Certified HDMI wire supports resolutions up to 4Kx2K (UHD)
@30 Hz
https://www.cnet.com/how-to/what-is-hdmi-2-0b/
HDMI versions compared
HDMI VersionMax Resolution Max 4K Frame rate HDCP 2.2HDR
Can you try something very simple - unplug the cable, and plug it back
in, while the TV is on, and set to the HDMI input? That should ensure
that the SCDC write can go through at modeset time.
You can also force nouveau to avoid any modes that require scrambling
by booting with nouveau.hdmimhz=340
On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote:
> The option is just used to select HMM mirror support and has a very
> confusing help text. Just pull in the HMM mirror code by default
> instead.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/gpu/drm/Kconfig
On Tue, Aug 06, 2019 at 07:05:52PM +0300, Christoph Hellwig wrote:
> Make HMM_MIRROR an option that is selected by drivers wanting to use it
> instead of a user visible option as it is just a low-level
> implementation detail.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/gpu/drm/amd/amdg
On 2019-08-06 13:44, Jason Gunthorpe wrote:
> On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote:
>> The option is just used to select HMM mirror support and has a very
>> confusing help text. Just pull in the HMM mirror code by default
>> instead.
>>
>> Signed-off-by: Christoph Hel
On Tue, Aug 06, 2019 at 07:05:49PM +0300, Christoph Hellwig wrote:
> Stub out the whole function when CONFIG_TRANSPARENT_HUGEPAGE is not set
> to make the function easier to read.
>
> Signed-off-by: Christoph Hellwig
> ---
> mm/hmm.c | 18 --
> 1 file changed, 8 insertions(+), 10
On Tue, Aug 06, 2019 at 07:05:46PM +0300, Christoph Hellwig wrote:
> The pagewalk code already passes the value as the hmask parameter.
>
> Signed-off-by: Christoph Hellwig
> mm/hmm.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Jason Gunthorpe
Jason
On Tue, Aug 06, 2019 at 07:05:41PM +0300, Christoph Hellwig wrote:
> We'll need the nouveau_svmm structure to improve the function soon.
> For now this allows using the svmm->mm reference to unlock the
> mmap_sem, and thus the same dereference chain that the caller uses
> to lock and unlock it.
>
On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote:
>
> On 2019-08-06 13:44, Jason Gunthorpe wrote:
> > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote:
> >> The option is just used to select HMM mirror support and has a very
> >> confusing help text. Just pull in the HMM mirr
On August 6, 2019 1:36:09 p.m. Ilia Mirkin wrote:
Can you try something very simple - unplug the cable, and plug it back
in, while the TV is on, and set to the HDMI input?
I still only get 30Hz.
I did just update the tv firmware s9 maybe that is why I can't get it 60Hz
anymore.
I wish I kept
On Tue, Aug 06, 2019 at 02:58:58PM -0400, Alex Deucher wrote:
> On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote:
> >
> > On 2019-08-06 13:44, Jason Gunthorpe wrote:
> > > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote:
> > >> The option is just used to select HMM mirror sup
I think I may have updated the tv firmware between when it worked and
when it didn't.
I wonder it it has to do with bit depth.
I use lubuntu and it doesn't let me pick the bit depth so I don't know
what it using.
___
Nouveau mailing list
Nouveau@list
That's OK - nouveau doesn't let you pick bit depth either (yet). It's
all 8bpc - higher bpc mode support will come ... eventually.
On Tue, Aug 6, 2019 at 5:25 PM James wrote:
>
> I think I may have updated the tv firmware between when it worked and
> when it didn't.
> I wonder it it has to do wit
Am 06.08.19 um 22:03 schrieb Jason Gunthorpe:
> On Tue, Aug 06, 2019 at 02:58:58PM -0400, Alex Deucher wrote:
>> On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix
>> wrote:
>>> On 2019-08-06 13:44, Jason Gunthorpe wrote:
On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote:
> T
34 matches
Mail list logo