On Sun, Oct 8, 2017 at 8:40 PM, Pierre Moreau wrote:
> Looking good. It would be nice to have some defines/enums for the different
> modes. Some comments about t0, t1 and t2 would be nice. I saw you are using t0
> in patch 16, but I have no idea why use t0 rather than t1 or t2.
>
I think I will r
On Sun, Oct 8, 2017 at 8:36 PM, Pierre Moreau wrote:
> On 2017-09-15 — 17:11, Karol Herbst wrote:
>> v2: use min_t
>>
>> Signed-off-by: Karol Herbst
>> ---
>> drm/nouveau/include/nvkm/subdev/clk.h | 2 ++
>> drm/nouveau/nvkm/subdev/clk/base.c| 42
>> +++
>>
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> v2: make message about relaxed throttling an info
> rework reporting about current clk state
>
> Signed-off-by: Karol Herbst
> ---
> drm/nouveau/include/nvkm/subdev/clk.h | 1 +
> drm/nouveau/nvkm/subdev/clk/base.c
Looking good. It would be nice to have some defines/enums for the different
modes. Some comments about t0, t1 and t2 would be nice. I saw you are using t0
in patch 16, but I have no idea why use t0 rather than t1 or t2.
Otherwise,
Acked-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote
On 2017-09-15 — 17:11, Karol Herbst wrote:
> v2: use min_t
>
> Signed-off-by: Karol Herbst
> ---
> drm/nouveau/include/nvkm/subdev/clk.h | 2 ++
> drm/nouveau/nvkm/subdev/clk/base.c| 42
> +++
> 2 files changed, 44 insertions(+)
>
> diff --git a/drm/nouveau
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> Depending on the temperature, cstates might become unreachable or the maped
> voltage of a cstate changes. We want to adjust to that.
>
> Signed-off-by: Karol Herbst
> Reviewed-by: Martin Peres
> ---
> drm/nouveau/nvkm/su
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> The idea is to clear out the saved state, because after a resume we can't
> know what the GPU is clocked to. The reclock is triggered by the call to
> nvkm_clk_update later in nvkm_clk_init.
>
> v2: convert to C style commen
On Sun, Oct 8, 2017 at 4:23 PM, Pierre Moreau wrote:
> On 2017-09-15 — 17:11, Karol Herbst wrote:
>> This makes the code easier, because we can compare the id with
>> pstate->pstate and saves us from the trouble of iterating over the pstates
>> to match the index.
>
> I don’t remember whether I ha
On 2017-09-15 — 17:11, Karol Herbst wrote:
> This makes the code easier, because we can compare the id with
> pstate->pstate and saves us from the trouble of iterating over the pstates
> to match the index.
I don’t remember whether I have already done this comment before, but I am not
sure where
On Sun, Oct 8, 2017 at 1:47 PM, Pierre Moreau wrote:
> The patch seems fine but I found it super confusing that sometimes `pstate` is
> a pointer (for example `clk->pstate`), sometimes it is an int (for example
> `args->v0.pstate`).
>
yeah I still plan to clean the names up when I find some time
On Sun, Oct 8, 2017 at 12:41 PM, Pierre Moreau wrote:
> On 2017-09-15 — 17:11, Karol Herbst wrote:
>> This function will be used to update the current clock state.
>>
>> This will happen for various reasons:
>> * Temperature changes
>> * User changes clocking state
>> * Load changes
>>
>> v2
Acked-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> Later we will have situations where the expected and the current state
> isn't the same.
>
> Signed-off-by: Karol Herbst
> Reviewed-by: Martin Peres
> ---
> drm/nouveau/include/nvkm/subdev/clk.h | 2 ++
> drm/nouveau/nvkm/s
The patch seems fine but I found it super confusing that sometimes `pstate` is
a pointer (for example `clk->pstate`), sometimes it is an int (for example
`args->v0.pstate`).
On 2017-09-15 — 17:11, Karol Herbst wrote:
> We will access the current cstate at least every second and this saves us
> som
This patch could be applied before patch 04, that way patch 04 does not need to
update a function (`nvkm_clk_dstate()`) that will be removed in the next patch.
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> We won't need it now, because we will adjust the clocks dependin
On Sun, Oct 8, 2017 at 12:29 PM, Pierre Moreau wrote:
> On 2017-09-15 — 17:11, Karol Herbst wrote:
>> While my gpu was powered off, hwmon returned 0.6V as the current voltage.
>> If nvkm_rd32 fails for any reason, return the error.
>>
>> With that sensors will display a "N/A" instead of 0.6V.
>
>
On 2017-09-15 — 17:11, Karol Herbst wrote:
> This function will be used to update the current clock state.
>
> This will happen for various reasons:
> * Temperature changes
> * User changes clocking state
> * Load changes
>
> v2: remove parameter name
>
> Signed-off-by: Karol Herbst
> ---
On Sun, Oct 8, 2017 at 12:16 PM, Pierre Moreau wrote:
> As you changed the return value of `temp_get()` to solely be the error code,
> or
> absence of an error, I would change all those tests that checked whether the
> returned value was strictly less, or greater than, 0 to now only compare
> aga
On 2017-09-15 — 17:11, Karol Herbst wrote:
> While my gpu was powered off, hwmon returned 0.6V as the current voltage.
> If nvkm_rd32 fails for any reason, return the error.
>
> With that sensors will display a "N/A" instead of 0.6V.
Small nitpick, add a comma between “that” and “sensors”.
Otherw
Reviewed-by: Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote:
> Otherwise hwmon interprets error codes as real values.
>
> Signed-off-by: Karol Herbst
> ---
> drm/nouveau/nouveau_hwmon.c | 33 ++---
> 1 file changed, 26 insertions(+), 7 deletions(-)
>
> dif
As you changed the return value of `temp_get()` to solely be the error code, or
absence of an error, I would change all those tests that checked whether the
returned value was strictly less, or greater than, 0 to now only compare
against 0 (no error). For example,
if (therm && therm->attr_get &&
20 matches
Mail list logo
