Re: [Nouveau] [PATCH v2 1/2] drm/nouveau: Fix ida leak

2021-05-13 Thread Leizhen (ThunderTown)
On 2021/5/12 14:39, Pierre Moreau wrote: > Why remove the const modifier on `nb`? A non-pointer local variable, I don't think it's necessary to add const modifier to make the syntax too complicated. > > On 2021-05-11 — 16:28, Zhen Lei wrote: >> When the 'nb' value allocated from 'bl_ida' is gr

[Nouveau] [PATCH v2 0/1] drm/dp_mst: Use kHz as link rate units when settig source max link caps at init

2021-05-13 Thread Nikola Cornij
Change log: v2: - Added 'Acked-by' to comment v1: - Initial Nikola Cornij (1): drm/dp_mst: Use kHz as link rate units when settig source max link caps at init .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 ++-- drivers/gpu/drm/drm_dp_mst_topology.c

[Nouveau] [PATCH v2 1/1] drm/dp_mst: Use kHz as link rate units when settig source max link caps at init

2021-05-13 Thread Nikola Cornij
[why] Link rate in kHz is what is eventually required to calculate the link bandwidth, which makes kHz a more generic unit. This should also make forward-compatibility with new DP standards easier. [how] - Replace 'link rate DPCD code' with 'link rate in kHz' when used with drm_dp_mst_topology_mgr

Re: [Nouveau] [PATCH] nouveau/gem: fix user-after-free in nouveau_gem_new

2021-05-13 Thread Jeremy Cline
On Thu, May 13, 2021 at 07:37:40PM +0200, Karol Herbst wrote: > On Thu, May 13, 2021 at 5:25 PM Jeremy Cline wrote: > > > > On Tue, May 11, 2021 at 06:35:53PM +0200, Karol Herbst wrote: > > > If ttm_bo_init fails it will already call ttm_bo_put, so we don't have to > > > do it through nouveau_bo_r

Re: [Nouveau] [PATCH] nouveau/gem: fix user-after-free in nouveau_gem_new

2021-05-13 Thread Karol Herbst
On Thu, May 13, 2021 at 5:25 PM Jeremy Cline wrote: > > On Tue, May 11, 2021 at 06:35:53PM +0200, Karol Herbst wrote: > > If ttm_bo_init fails it will already call ttm_bo_put, so we don't have to > > do it through nouveau_bo_ref. > > > >

Re: [Nouveau] [RFC PATCH v3 0/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-05-13 Thread Ralph Campbell
On 5/13/21 6:15 AM, Matthew Wilcox wrote: On Thu, Oct 01, 2020 at 11:17:13AM -0700, Ralph Campbell wrote: This is still an RFC because after looking at the pmem/dax code some more, I realized that the ZONE_DEVICE struct pages are being inserted into the process' page tables with vmf_insert_mix

Re: [Nouveau] [PATCH v2 1/1] drm/dp_mst: Use kHz as link rate units when settig source max link caps at init

2021-05-13 Thread Lyude Paul
Reviewed-by: Lyude Paul Will let this sit on the list for a few days to see if anyone's got any objections and then I'll go ahead and push it On Wed, 2021-05-12 at 17:00 -0400, Nikola Cornij wrote: > [why] > Link rate in kHz is what is eventually required to calculate the link > bandwidth, which

Re: [Nouveau] [PATCH] nouveau/gem: fix user-after-free in nouveau_gem_new

2021-05-13 Thread Jeremy Cline
On Tue, May 11, 2021 at 06:35:53PM +0200, Karol Herbst wrote: > If ttm_bo_init fails it will already call ttm_bo_put, so we don't have to > do it through nouveau_bo_ref. > > == > BUG: KFENCE: use-after-free write in ttm_bo_put+0x11/0x

Re: [Nouveau] [RFC PATCH v3 0/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-05-13 Thread Matthew Wilcox
On Thu, Oct 01, 2020 at 11:17:13AM -0700, Ralph Campbell wrote: > This is still an RFC because after looking at the pmem/dax code some > more, I realized that the ZONE_DEVICE struct pages are being inserted > into the process' page tables with vmf_insert_mixed() and a zero > refcount on the ZONE_DE