Re: [Nouveau] [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-06 Thread Donald Robson
On Fri, 2023-06-30 at 00:25 +0200, Danilo Krummrich wrote: > > +#ifdef CONFIG_LOCKDEP > +typedef struct lockdep_map *lockdep_map_p; > +#define drm_gpuva_manager_ext_assert_held(mgr) \ > + lockdep_assert(lock_is_held((mgr)->ext_lock) != LOCK_STATE_NOT_HELD) > +/** > + *

Re: [Nouveau] [PATCH drm-next v7 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-17 Thread Donald Robson
Hi Danilo, The below part of the documentation is out of date now. Thanks, Donald On Thu, 2023-07-13 at 19:03 +0200, Danilo Krummrich wrote: > > + > +/** > + * DOC: Locking > + * > + * Generally, the GPU VA manager does not take care of locking itself, it is > + * the drivers responsibility to

Re: [Nouveau] [PATCH drm-next v4 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-06-20 Thread Donald Robson
gree this reflects me being a novice on matters DRM, but I did find myself wishing for more direction, even with Boris's help. Tested-by: Donald Robson > drm: debugfs: provide infrastructure to dump a DRM GPU VA space > drm/nouveau: new VM_BIND uapi interfaces > drm/nouveau: get vmm

Re: [Nouveau] [PATCH drm-next v4 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-06-20 Thread Donald Robson
On Tue, 2023-06-13 at 16:20 +0200, Danilo Krummrich wrote: > I'm definitely up improving the existing documentation. Anything in > particular you think should be described in more detail? > > - Danilo Hi Danilo, As I said, with inexperience it's possible I missed what I was looking for in the

Re: [Nouveau] [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-21 Thread Donald Robson
Hi Danilo, One comment below, but otherwise it looks great. Thanks for adding the example! Thanks, Donald On Tue, 2023-06-20 at 02:42 +0200, Danilo Krummrich wrote: > > +/** > + * DOC: Overview > + * > + * The DRM GPU VA Manager, represented by struct drm_gpuva_manager keeps > track > + * of a