Those are already de-facto UAPI, so let's just move it into the uapi
header.
Signed-off-by: Karol Herbst
Reviewed-by: Lyude Paul
Reviewed-by: Danilo Krummrich
Link:
https://patchwork.freedesktop.org/patch/msgid/20240304183157.1587152-2-kher...@redhat.com
---
drivers/gpu/drm/nouveau
: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
Cc: Danilo Krummrich
Cc: # v6.6+
Signed-off-by: Karol Herbst
Reviewed-by: Lyude Paul
Reviewed-by: Danilo Krummrich
Link:
https://patchwork.freedesktop.org/patch/msgid/20240304183157.1587152-1-kher...@redhat.com
---
drivers/gpu/d
Those are already de-facto UAPI, so let's just move it into the uapi
header.
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_abi16.c | 20 +++-
drivers/gpu/drm/nouveau/nouveau_abi16.h | 12
include/uapi/drm/nouveau_drm.h | 22
: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
Cc: Danilo Krummrich
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c
b/drivers/gpu/drm/nouveau/nouveau_g
/255
Fixes: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX
interrupts")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/n
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts
> with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones
> ---
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc:
doc.rst
>
> Signed-off-by: Lee Jones
> ---
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: dri-de...@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/
doc.rst
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones
> ---
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude
ev/bios/init.c:611: warning: expecting
> prototype for INIT_DONE(). Prototype was for init_done() instead
> [Snipped ~140 lines for brevity]
>
> Signed-off-by: Lee Jones
> ---
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Ve
On Thu, Aug 17, 2023 at 12:11 PM Borislav Petkov wrote:
>
> On Thu, Aug 17, 2023 at 12:00:47PM +0200, Karol Herbst wrote:
> > btw, what would help is to know where `nvkm_uconn_uevent` actually
> > fails, or rather, are you running into this "/* TODO: support DP IRQ
&g
On Thu, Aug 17, 2023 at 11:58 AM Karol Herbst wrote:
>
> On Thu, Aug 17, 2023 at 10:10 AM Borislav Petkov wrote:
> >
> > On Thu, Aug 17, 2023 at 01:18:12AM +0200, Karol Herbst wrote:
> > > do you have one of these? https://en.wikipedia.org/wiki/DMS-59
> >
>
On Thu, Aug 17, 2023 at 10:10 AM Borislav Petkov wrote:
>
> On Thu, Aug 17, 2023 at 01:18:12AM +0200, Karol Herbst wrote:
> > do you have one of these? https://en.wikipedia.org/wiki/DMS-59
>
> Ah, DMS == Dual Monitor Solution :-)
>
> Yap, that's exactly what the GPU has.
On Thu, Aug 17, 2023 at 12:14 AM Borislav Petkov wrote:
>
> On Wed, Aug 16, 2023 at 11:27:05PM +0200, Karol Herbst wrote:
> > that GPU has only a `DMS-59` connector, is that right?
>
> No clue. How do I figure that out?
>
do you have one of these? https://en.wiki
On Wed, Aug 16, 2023 at 5:13 PM Borislav Petkov wrote:
>
> On Wed, Aug 16, 2023 at 04:57:28PM +0200, Karol Herbst wrote:
> > Do you have any connectors listed in "/sys/class/drm"?
>
> tree /sys/class/drm/
> /sys/class/drm/
> ├── card0 -> ../../devices/pci
On Wed, Aug 16, 2023 at 4:54 PM Borislav Petkov wrote:
>
> On Wed, Aug 16, 2023 at 11:51:50AM +0200, Karol Herbst wrote:
> > Mind sharing your kernel logs with that patch applied? I suspect your
> > system boots up but you might just not have the connector available or
>
On Wed, Aug 16, 2023 at 11:30 AM Borislav Petkov wrote:
>
> On Mon, Aug 14, 2023 at 04:49:32PM +0200, Karol Herbst wrote:
> > We can't simply free the connector after calling drm_connector_init on it.
> > We need to clean up the drm side first.
> >
> > It migh
On Mon, Aug 14, 2023 at 4:19 PM Karol Herbst wrote:
>
> On Mon, Aug 14, 2023 at 3:35 PM Takashi Iwai wrote:
> >
> > On Mon, 14 Aug 2023 15:19:11 +0200,
> > Karol Herbst wrote:
> > >
> > > On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote:
> > >
n in error handling related to that commit.
Link:
https://lore.kernel.org/lkml/20230806213107.GFZNARG6moWpFuSJ9W@fat_crate.local/
Fixes: 95983aea8003 ("drm/nouveau/disp: add connector class")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 11 +++---
On Mon, Aug 14, 2023 at 3:35 PM Takashi Iwai wrote:
>
> On Mon, 14 Aug 2023 15:19:11 +0200,
> Karol Herbst wrote:
> >
> > On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote:
> > >
> > > On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote:
> > &
On Tue, Aug 8, 2023 at 3:47 PM Borislav Petkov wrote:
>
> On Tue, Aug 08, 2023 at 12:39:32PM +0200, Karol Herbst wrote:
> > ahh, that would have been good to know :)
>
> Yeah, I didn't see it before - it would only freeze. Only after I added
> the printk you requested.
&g
On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote:
>
> On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote:
> >
> > On Mon, 14 Aug 2023 14:38:18 +0200,
> > Karol Herbst wrote:
> > >
> > > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote:
> >
On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote:
>
> On Mon, 14 Aug 2023 14:38:18 +0200,
> Karol Herbst wrote:
> >
> > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote:
> > >
> > > On Wed, 09 Aug 2023 16:46:38 +0200,
> > > Takashi Iwai wro
On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote:
>
> On Wed, 09 Aug 2023 16:46:38 +0200,
> Takashi Iwai wrote:
> >
> > On Wed, 09 Aug 2023 15:13:23 +0200,
> > Takashi Iwai wrote:
> > >
> > > On Wed, 09 Aug 2023 14:19:23 +0200,
> > > Karol
On Sat, Aug 12, 2023 at 8:12 AM Wolfram Sauerteig
wrote:
>
> Hello,
>
> since one of the last nouveau driver updates I've got a problem with my
> Thinkpad W701. A couple of seconds after having started X11/KDE Plasma
> the Desktop freezes, only the mouse pointer is still moveable. System ist
>
On Wed, Aug 9, 2023 at 8:28 PM Karol Herbst wrote:
>
> On Wed, Aug 9, 2023 at 4:04 PM Thorsten Leemhuis
> wrote:
> >
> > On 09.08.23 15:13, Takashi Iwai wrote:
> > >
> > > If this can't be fixed quickly, I suppose it's safer to revert it from
> >
On Wed, Aug 9, 2023 at 4:04 PM Thorsten Leemhuis
wrote:
>
> On 09.08.23 15:13, Takashi Iwai wrote:
> >
> > If this can't be fixed quickly, I suppose it's safer to revert it from
> > 6.4.y for now. 6.5 is still being cooked, but 6.4.x is already in
> > wide deployment, hence the regression has to
On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai wrote:
>
> On Wed, 09 Aug 2023 13:42:09 +0200,
> Karol Herbst wrote:
> >
> > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai wrote:
> > >
> > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > Karol Herbst wrote
On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai wrote:
>
> On Tue, 08 Aug 2023 12:39:32 +0200,
> Karol Herbst wrote:
> >
> > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov wrote:
> > >
> > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov wrote:
>
> On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > in what way does it stop? Just not progressing? That would be kinda
> > concerning. Mind tracing with what arguments `nvkm_uevent_add` is
> >
On Sun, Aug 6, 2023 at 11:40 PM Borislav Petkov wrote:
>
> Hi folks,
>
> the patch in $Subject breaks booting here on one of my test boxes, see
> below.
>
> Reverting it ontop of -rc4 fixes the issue.
>
> Thx.
>
> [3.580535] ACPI: \_PR_.CP04: Found 4 idle states
> [3.585694] ACPI:
uveau_fence_emit(fence, drm->dmem->migrate.chan);
> migrate_vma_pages(args);
> nouveau_dmem_fence_done();
> nouveau_pfns_map(svmm, args->vma->vm_mm, args->start, pfns, i);
>
> base-commit: 82d750e9d2f5d0594c8f7057ce59127e701af781
> --
> 2.41.0
>
Reviewed-by: Karol Herbst
Paul
Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/238
Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/245
Fixes: 20a2ce87fbaf8 ("drm/nouveau/dp: check for NULL
nv_connector->native_mode")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_co
On Fri, Aug 4, 2023 at 8:10 PM Olaf Skibbe wrote:
>
> Dear all,
>
> On Fri, 4 Aug 2023 at 14:15, Karol Herbst wrote:
>
> >>> 62aecf23f3d1 drm/nouveau: add nv_encoder pointer check for NULL
> >>> fb725beca62d drm/nouveau/dp: check for NULL nv_connector->
On Fri, Aug 4, 2023 at 2:48 PM Olaf Skibbe wrote:
>
> On Fri, 4 Aug 2023 at 14:15, Karol Herbst wrote:
>
> > mind retrying with only fb725beca62d and 62aecf23f3d1 reverted?
>
> I will do this later this day (takes some time, it is a slow machine).
>
> > Would be
On Fri, Aug 4, 2023 at 2:02 PM Thorsten Leemhuis
wrote:
>
> Hi!
>
> On 02.08.23 23:28, Olaf Skibbe wrote:
> > Dear Maintainers,
> >
> > Hereby I would like to report an apparent bug in the nouveau driver in
> > linux/6.1.38-2.
>
> Thx for your report. Maybe your problem is caused by a incomplete
return gk20a_gr_load_net(gr, "gr/", "sw_veid_bundle_init", ver,
> tu102_gr_av_to_init_veid,
> ->bundle_veid);
> -}
> -
> static const struct gf100_gr_fwif
> tu102_gr_fwif[] = {
> { 0, gm200_gr_load, _gr, _gr_fecs_acr,
> _gr_gpccs_acr },
> --
> 2.39.2
>
Reviewed-by: Karol Herbst
Will push to drm-misc in a sec
On Tue, Aug 1, 2023 at 5:15 PM Faith Ekstrand wrote:
> On Tue, Aug 1, 2023 at 4:37 AM Karol Herbst wrote:
>
>> On Mon, Jul 31, 2023 at 9:16 PM Dave Airlie wrote:
>> >
>> > From: Dave Airlie
>> >
>> > nouveau > 10 years ago had a plan for new
efine DRM_IOCTL_NOUVEAU_CHANNEL_ALLOC DRM_IOWR(DRM_COMMAND_BASE +
> DRM_NOUVEAU_CHANNEL_ALLOC, struct drm_nouveau_channel_alloc)
> +#define DRM_IOCTL_NOUVEAU_CHANNEL_FREE DRM_IOW (DRM_COMMAND_BASE +
> DRM_NOUVEAU_CHANNEL_FREE, struct drm_nouveau_channel_free)
> +
> #define DRM_IOCTL_NOUVEAU_SVM_INIT DRM_IOWR(DRM_COMMAND_BASE +
> DRM_NOUVEAU_SVM_INIT, struct drm_nouveau_svm_init)
> #define DRM_IOCTL_NOUVEAU_SVM_BIND DRM_IOWR(DRM_COMMAND_BASE +
> DRM_NOUVEAU_SVM_BIND, struct drm_nouveau_svm_bind)
>
> --
> 2.41.0
>
Reviewed-by: Karol Herbst
On Sat, Jul 29, 2023 at 9:49 PM Karol Herbst wrote:
>
> On Sat, Jul 29, 2023 at 7:54 PM Ferenc Wágner wrote:
> >
> > Karol Herbst writes:
> >
> > > On Fri, Jun 23, 2023 at 12:12 AM Ferenc Wágner wrote:
> > >
> > >> Ferenc Wágner writes
On Sat, Jul 29, 2023 at 7:54 PM Ferenc Wágner wrote:
>
> Karol Herbst writes:
>
> > On Fri, Jun 23, 2023 at 12:12 AM Ferenc Wágner wrote:
> >
> >> Ferenc Wágner writes:
> >>
> >>> Sorry if I'm reaching the wrong forum, please advise if
On Fri, Jul 28, 2023 at 1:11 AM Karol Herbst wrote:
>
> On Thu, Jul 27, 2023 at 11:57 PM Lyude Paul wrote:
> >
> > On Sun, 2023-07-09 at 01:42 +0200, Karol Herbst wrote:
> > > On Fri, Jul 7, 2023 at 11:58 PM Lyude Paul wrote:
> > > >
> > > >
On Thu, Jul 27, 2023 at 11:57 PM Lyude Paul wrote:
>
> On Sun, 2023-07-09 at 01:42 +0200, Karol Herbst wrote:
> > On Fri, Jul 7, 2023 at 11:58 PM Lyude Paul wrote:
> > >
> > > Currently we use the drm_dp_dpcd_read_caps() helper in the DRM side of
> > > no
t dcb_output *dcbe)
> nv_encoder->i2c = ddc;
> nv_encoder->aux = aux;
>
> + mutex_init(_encoder->dp.hpd_irq_lock);
> +
> encoder = to_drm_encoder(nv_encoder);
> encoder->possible_crtcs = dcbe->heads;
> encoder->possible_clones = 0;
> --
> 2.41.0
>
Reviewed-by: Karol Herbst
if (args->v0.types & NVIF_CONN_EVENT_V0_UNPLUG) bits |= NVKM_GPIO_LO;
> - if (args->v0.types & NVIF_CONN_EVENT_V0_IRQ)
> - return -EINVAL;
> + if (args->v0.types & NVIF_CONN_EVENT_V0_IRQ) {
> + /* TODO: support DP IRQ on ANX9805 and remove this hack. */
> + if (!outp->info.location)
> + return -EINVAL;
> + }
>
> return nvkm_uevent_add(uevent, >gpio->event, conn->info.hpd,
> bits,
>nvkm_uconn_uevent_gpio);
> --
> 2.41.0
>
Reviewed-by: Karol Herbst
}
>
> - return nvkm_event_init(_i2c_intr_func, >subdev, 4, i,
> >event);
> + ids = 0;
> + list_for_each_entry(aux, >aux, head)
> + ids = max(ids, aux->id + 1);
> + if (!ids)
> + return 0;
> +
> + return nvkm_event_init(_i2c_intr_func, >subdev, 4, ids,
> >event);
> }
> --
> 2.41.0
>
Reviewed-by: Karol Herbst
On Sat, Jul 15, 2023 at 1:07 AM Lyude Paul wrote:
>
> NAK - checkpatch.pl is a (strongish) guideline, but not a rule. In the cases
> corrected in the patch series here, we format the switch cases on single lines
> as it dramatically improves the readability of what is otherwise just a /long/
>
On Thu, Jul 13, 2023 at 11:13 AM Karol Herbst wrote:
>
> On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya wrote:
> >
> > On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote:
> > > Fixed error: 'do not use assignment in if condition'
> > >
>
On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya wrote:
>
> On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote:
> > Fixed error: 'do not use assignment in if condition'
> >
> > This patch fixes error: 'do not use assignment in if condition'
> > in drm/nouveau/iccsense
>
> I guess
), GFP_KERNEL)))
> +*paux = kzalloc(sizeof(**paux), GFP_KERNEL);
> +if (!*paux)
> return -ENOMEM;
> return nvkm_i2c_aux_ctor(func, pad, id, *paux);
> }
>
Reviewed-by: Karol Herbst
if (!(pad = nvkm_i2c_pad_find(i2c, id)))
> +pad = nvkm_i2c_pad_find(i2c, id);
> +if (!pad)
> ret = func->pad_s_new(i2c, id, );
> else
> ret = 0;
>
Reviewed-by: Karol Herbst
t; }
>
> static int
> -gk104_pcie_init(struct nvkm_pci * pci)
> +gk104_pcie_init(struct nvkm_pci *pci)
> {
> enum nvkm_pcie_speed lnkctl_speed, max_speed, cap_speed;
> struct nvkm_subdev *subdev = >subdev;
>
Reviewed-by: Karol Herbst
Reviewed-by: Karol Herbst
On Mon, Jul 10, 2023 at 9:23 AM wrote:
>
> Assignments in if condition are less readable and error-prone. Fixes
> also checkpatch warning:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/
On Fri, Jul 7, 2023 at 11:58 PM Lyude Paul wrote:
>
> Currently we use the drm_dp_dpcd_read_caps() helper in the DRM side of
> nouveau in order to read the DPCD of a DP connector, which makes sure we do
> the right thing and also check for extended DPCD caps. However, it turns
> out we're not
this one out a bit later.
> On Fri, 2023-06-30 at 18:06 +0200, Karol Herbst wrote:
> > Cc: Ben Skeggs
> > Cc: Lyude Paul
> > Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire +
> > infoframe methods")
> > Signed-off-by: Karol Herbst
Cc: Ben Skeggs
Cc: Lyude Paul
Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire +
infoframe methods")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/e
GPUs with a connected 4K display.
Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/199
Cc: Ben Skeggs
Cc: Lyude Paul
Cc: sta...@vger.kernel.org # v6.1+
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 19 +++
1 file changed, 19 insertions
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_dp.c| 3 +--
drivers/gpu/drm/nouveau/nouveau_encoder.h | 3 +--
4 files changed, 4 insertions(+), 6 deletions(-)
diff
Cc: Ben Skeggs
Cc: Lyude Paul
Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire +
infoframe methods")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/gt215.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
On Fri, Jun 23, 2023 at 12:12 AM Ferenc Wágner wrote:
>
> Ferenc Wágner writes:
>
> > Sorry if I'm reaching the wrong forum, please advise if so. My question
> > is not about the main focus of this community, but I had no better idea
> > about where to look for the relevant expertise.
> >
> >
@lists.freedesktop.org
Cc: sta...@vger.kernel.org
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf100.h | 1 +
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgk104.c | 4 +++-
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgk110.c | 10 ++
drivers/gpu/drm/nouveau/nvkm
_connector->edid);
> +
> + if (nv_encoder->dcb->type == DCB_OUTPUT_DP)
> + drm_dp_cec_set_edid(_connector->aux,
> nv_connector->edid);
> +
> goto out;
> } else {
> nouveau_connector_set_edid(nv_connector, NULL);
> --
> 2.40.1
>
Reviewed-by: Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote:
>
> From: Ben Skeggs
>
> DRM cleanup paths unconditionally call nvif_mmu_dtor() for clients,
> which would result in a double-free if nvif_mmu_ctor()'d previously
> failed.
>
> Signed-off-by: Ben Skeggs
> ---
>
struct nvkm_gr *base)
> +{
> + struct gf100_gr *gr = gf100_gr(base);
> +
> + if (gr->func->nonstall)
> + return gr->func->nonstall(gr);
> +
> + return -EINVAL;
> +}
> +
> static const struct nvkm_gr_func
> gf100_gr_ = {
> .dtor = gf100_gr_dtor,
> .oneinit = gf100_gr_oneinit,
> .init = gf100_gr_init_,
> .fini = gf100_gr_fini,
> + .nonstall = gf100_gr_nonstall,
> .reset = gf100_gr_reset,
> .units = gf100_gr_units,
> .chan_new = gf100_gr_chan_new,
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.h
> b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.h
> index 94ca7ac16acf..54f686ba39ac 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.h
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.h
> @@ -147,6 +147,7 @@ struct gf100_gr_func_zbc {
> };
>
> struct gf100_gr_func {
> + int (*nonstall)(struct gf100_gr *);
> struct nvkm_intr *(*oneinit_intr)(struct gf100_gr *, enum
> nvkm_intr_type *);
> void (*oneinit_tiles)(struct gf100_gr *);
> int (*oneinit_sm_id)(struct gf100_gr *);
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/priv.h
> b/drivers/gpu/drm/nouveau/nvkm/engine/gr/priv.h
> index 6ec8b94854c0..0884abc73a9d 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/priv.h
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/priv.h
> @@ -18,6 +18,7 @@ struct nvkm_gr_func {
> int (*init)(struct nvkm_gr *);
> int (*fini)(struct nvkm_gr *, bool);
> int (*reset)(struct nvkm_gr *);
> + int (*nonstall)(struct nvkm_gr *);
> void (*intr)(struct nvkm_gr *);
> void (*tile)(struct nvkm_gr *, int region, struct nvkm_fb_tile *);
> int (*tlb_flush)(struct nvkm_gr *);
> --
> 2.40.1
>
Reviewed-by: Karol Herbst
if (ret)
> - return ret;
> - }
> -
> - if (tdev->engine < 0)
> - continue;
> + if (ret) {
> + if (runl)
> + nvkm_runl_del(runl);
>
> - nvkm_runl_add(runl, tdev->engine, (tdev->type ==
> NVKM_ENGINE_CE) ?
> - fifo->func->engn_ce : fifo->func->engn,
> tdev->type, tdev->inst);
> + continue;
> + }
> + }
> }
>
> return 0;
> --
> 2.40.1
>
Reviewed-by: Karol Herbst
uot;cgid/chid: %d", ret);
> nvkm_runl_del(runl);
> - return NULL;
> + return ERR_PTR(ret);
> }
> } else {
> runl->cgid = nvkm_chid_ref(fifo->cgid);
> --
> 2.40.1
>
Reviewed-by: Karol Herbst
nv10.c
> index e79e640ae535..742c75859569 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/sw/nv10.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/sw/nv10.c
> @@ -36,7 +36,7 @@ nv10_sw_chan = {
> };
>
> static int
> -nv10_sw_chan_new(struct nvkm_sw *sw, struct nvkm_fifo_chan *fifo,
> +nv10_sw_chan_new(struct nvkm_sw *sw, struct nvkm_chan *fifo,
> const struct nvkm_oclass *oclass, struct nvkm_object
> **pobject)
> {
> struct nvkm_sw_chan *chan;
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/sw/nv50.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/sw/nv50.c
> index 9d7a9b7d5be3..99476d32c5af 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/sw/nv50.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/sw/nv50.c
> @@ -99,7 +99,7 @@ nv50_sw_chan = {
> };
>
> static int
> -nv50_sw_chan_new(struct nvkm_sw *sw, struct nvkm_fifo_chan *fifoch,
> +nv50_sw_chan_new(struct nvkm_sw *sw, struct nvkm_chan *fifoch,
> const struct nvkm_oclass *oclass, struct nvkm_object
> **pobject)
> {
> struct nvkm_disp *disp = sw->engine.subdev.device->disp;
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/sw/priv.h
> b/drivers/gpu/drm/nouveau/nvkm/engine/sw/priv.h
> index d9d83b1b8849..8015afaba947 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/sw/priv.h
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/sw/priv.h
> @@ -15,7 +15,7 @@ struct nvkm_sw_chan_sclass {
> };
>
> struct nvkm_sw_func {
> - int (*chan_new)(struct nvkm_sw *, struct nvkm_fifo_chan *,
> + int (*chan_new)(struct nvkm_sw *, struct nvkm_chan *,
> const struct nvkm_oclass *, struct nvkm_object **);
> const struct nvkm_sw_chan_sclass sclass[];
> };
> --
> 2.40.1
>
Reviewed-by: Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote:
>
> From: Ben Skeggs
>
> Also exposes this for use by upcoming GSP-RM initialisation code.
>
> Signed-off-by: Ben Skeggs
> ---
> .../gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 +
> drivers/gpu/drm/nouveau/nvkm/subdev/fb/Kbuild | 1 +
>
subdev, "intr%d:
> %08x\n",
> + leaf, intr->stat[leaf]);
> nvkm_intr_block_locked(intr, leaf,
> intr->stat[leaf]);
> }
> }
> --
> 2.40.1
>
Reviewed-by: Karol Herbst
_each_entry_reverse(child, >tree, head) {
> ret = nvkm_object_fini(child, suspend);
> if (ret && suspend)
> goto fail_child;
> --
> 2.40.1
>
Reviewed-by: Karol Herbst
, let's do that.
>
> Signed-off-by: Lyude Paul
Reviewed-by: Karol Herbst
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> b/drivers/gpu/drm/nouveau/disp
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts
> with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vette
On Fri, Jun 9, 2023 at 10:18 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no previous
> prototype for ‘tu102_gr_load’ [-Wmissing-prototypes]
>
> Cc: Ben Skeggs
> Cc: Karol
oc.rst
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: dri-de...@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> Signed-off-by: Lee Jones
Reviewed-by: Karol Herbst
> ---
> drivers/gpu/drm/nouveau
doc.rst
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David
: variable
> ‘loc’ set but not used [-Wunused-but-set-variable]
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Gourav Samaiya
> Cc: dri-de...@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> Signed-
ev/bios/init.c:611: warning: expecting
> prototype for INIT_DONE(). Prototype was for init_done() instead
> [Snipped ~140 lines for brevity]
>
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: dri-de...@lists.freede
On Fri, May 26, 2023 at 5:21 PM Ilia Mirkin wrote:
>
> On Fri, May 26, 2023 at 5:11 AM Karol Herbst wrote:
> >
> > 1ba6113a90a0 removed a lot of the kernel GPU channel, but method 0x128
> > was important as otherwise the GPU spams us with `CACHE_ERROR` messages.
> acpi_handle *dhandle_out
> int optimus_funcs;
> struct pci_dev *parent_pdev;
>
> + if (pdev->vendor != PCI_VENDOR_ID_NVIDIA)
> + return;
> +
> *has_pr3 = false;
> parent_pdev = pci_upstream_bridge(pdev);
> if (parent_p
://gitlab.freedesktop.org/drm/nouveau/-/issues/201
Fixes: 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_chan.c | 1 +
drivers/gpu/drm/nouveau/nouveau_chan.h | 1 +
drivers/gpu/drm/nouveau/nouveau_drm.c | 20 +
I wouldn't be surprised if 4a16dd9d18a0 is the culprit and that it was
always broken like this with drm fbdev. Anyway, the logs don't indicate we
are actually doing anything wrong, It's just that the tty handling is a
little bonkers as always.
On Thu, May 25, 2023 at 1:37 PM Bagas Sanjaya wrote:
On Mon, May 22, 2023 at 10:18 PM Karol Herbst wrote:
>
> This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary
> firmware files couldn't be loaded.
>
> Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/212
> Fixes: 4b569ded09fd ("drm/nou
This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary
firmware files couldn't be loaded.
Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/212
Fixes: 4b569ded09fd ("drm/nouveau/acr/ga102: initial support")
Signed-off-by: Karol Herbst
---
drivers/gpu/d
Reviewed-by: Karol Herbst
On Wed, May 17, 2023 at 3:31 PM Tom Rix wrote:
>
> smatch reports
> drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol
> 'ga102_gsps' was not declared. Should it be static?
>
> This variable is only used in its defining file, so i
Reviewed-by: Karol Herbst
will merge soon
On Mon, Apr 17, 2023 at 11:03 PM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> nv50_display_create() is declared in another header, along with
> a couple of declarations that are now outdated:
>
> drivers/gpu/drm/nouveau/d
/201
Fixes: 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nouveau_chan.c | 1 +
drivers/gpu/drm/nouveau/nouveau_chan.h | 1 +
drivers/gpu/drm/nouveau/nouveau_drm.c | 19 ---
3 files changed, 18
On Fri, Apr 28, 2023 at 1:27 AM Lyude Paul wrote:
>
> On Fri, 2023-04-28 at 00:50 +0200, Karol Herbst wrote:
> > On Fri, Apr 28, 2023 at 12:46 AM Lyude Paul wrote:
> > >
> > > Hey Linus, Kees. Responses below
> > >
> > > On Sun, 2023-04-23 at 1
On Fri, Apr 28, 2023 at 12:46 AM Lyude Paul wrote:
>
> Hey Linus, Kees. Responses below
>
> On Sun, 2023-04-23 at 13:23 -0700, Kees Cook wrote:
> > On April 23, 2023 10:36:24 AM PDT, Linus Torvalds
> > wrote:
> > > Kees,
> > > I made the mistake of upgrading my M2 Macbook Air to Fedora-38, and
On Sun, Apr 23, 2023 at 10:24 PM Kees Cook wrote:
>
> On April 23, 2023 10:36:24 AM PDT, Linus Torvalds
> wrote:
> >Kees,
> > I made the mistake of upgrading my M2 Macbook Air to Fedora-38, and
> >in the process I got gcc-13 which is not WERROR-clean because we only
> >limited the
> > ~~~^~~~~~
> >
> > Fixes: 813443721331 ("drm/nouveau/disp: move DP link config into acquire")
> > Cc: Ben Skeggs
> > Cc: Lyude Paul
> > Cc: Karol Herbst
> > Cc: David Airlie
> > C
On Sun, Apr 16, 2023 at 11:30 AM Markus Elfring wrote:
>
> Date: Sun, 16 Apr 2023 11:22:23 +0200
>
> Several update suggestions were taken into account
> from static source code analysis.
>
Reviewed-by: Karol Herbst
> Markus Elfring (9):
> debugfs: Move an express
ready using
> > dma_resv_wait_timeout() correctly.
> >
> > Fixes: 41d351f29528 ("drm/nouveau: stop using ttm_bo_wait")
> > Reported-by: Tanmay Bhushan <0070472...@gmail.com>
> > Link:
> > https://lore.kernel.org/lkml/20230119225351.71657-1-0070472...@gmail.co
Reviewed-by: Karol Herbst
On Sat, Sep 24, 2022 at 10:00 AM ruanjinjie wrote:
>
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> ./drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c:591:1: warning:
> symbol 'gv10
Reviewed-by: Karol Herbst
On Thu, Dec 29, 2022 at 4:52 PM Ben Dooks wrote:
>
> Make ga100_mc_device static as it isn't exported, to
> fix the following sparse warning:
>
> drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: warning: symbol
> 'ga100_mc_device' was no
Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/203
Fixes: 5728d064190e1 ("drm/nouveau/fb: handle sysmem flush page from common
code")
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1
On Fri, Mar 31, 2023 at 12:39 AM Karol Herbst wrote:
>
> This allows us to advertise more modes especially on HDR displays.
>
> Fixes using 4K@60 modes on my TV and main display both using a HDMI to DP
> adapter. Also fixes similiar issues for users running into th
This allows us to advertise more modes especially on HDR displays.
Fixes using 4K@60 modes on my TV and main display both using a HDMI to DP
adapter. Also fixes similiar issues for users running into this.
Cc: sta...@vger.kernel.org # 5.10+
Signed-off-by: Karol Herbst
---
drivers/gpu/drm
...@vger.kernel.org
Signed-off-by: Karol Herbst
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf100.c | 2 ++
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf100.h | 2 ++
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgk104.c | 4 +++-
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgk110.c | 10 ++
drivers
mistake not using this function.
Ben, is it safe to remove it? The code seems to be slightly different
things, but also looks like it needs to be rewritten a little anyway.
> Cc: Ben Skeggs
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc:
nouveau changes up to here are:
Reviewed-by: Karol Herbst
On Fri, Mar 17, 2023 at 9:23 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts
> with '/**', but isn't a kernel-doc
On Thu, Mar 16, 2023 at 8:57 PM Bjorn Helgaas wrote:
>
> On Thu, Mar 16, 2023 at 03:31:22PM +0100, Karol Herbst wrote:
> > Users kept complaining about those messages and it's a little spammy on
> > prime systems so turn it into a debug print.
>
> What is a "prime sy
1 - 100 of 1117 matches
Mail list logo
