Re: [PATCH 0/9] drm: Annotate structs with __counted_by

On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > >> This is a batch of patches touching drm for preparing for the coming > >> implementation by GCC and Clang of the __counted_by attribute.

Re: [Nouveau] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

On Mon, Sep 25, 2023 at 1:52 PM Kees Cook wrote: > > On Mon, Sep 25, 2023 at 08:30:30AM +0200, Christian König wrote: > > Am 22.09.23 um 19:41 schrieb Alex Deucher: > > > On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > > > > Prepare for the comin

Re: [Nouveau] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

On Mon, Sep 25, 2023 at 10:07 AM Alex Deucher wrote: > > On Mon, Sep 25, 2023 at 2:30 AM Christian König > wrote: > > > > Am 22.09.23 um 19:41 schrieb Alex Deucher: > > > On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > > >> Prepare for

Re: [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

On Mon, Sep 25, 2023 at 2:30 AM Christian König wrote: > > Am 22.09.23 um 19:41 schrieb Alex Deucher: > > On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > >> Prepare for the coming implementation by GCC and Clang of the __counted_by > >> attribute. Fl

Re: [PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by

> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct ip_hw_instance. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Alex Deuch

Re: [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct > smu10_voltage_dependency_table. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci &

Re: [Nouveau] [RFC, drm-misc-next v4 3/9] drm/radeon: Implement .be_primary() callback

On Tue, Sep 5, 2023 at 1:25 PM suijingfeng wrote: > > Hi, > > > On 2023/9/5 13:50, Christian König wrote: > > Am 04.09.23 um 21:57 schrieb Sui Jingfeng: > >> From: Sui Jingfeng > >> > >> On a machine with multiple GPUs, a Linux user has no control over > >> which one > >> is primary at boot

Re: [Nouveau] [PATCH -next 1/7] drm/amdkfd: Remove unnecessary NULL values

Applied. Thanks! On Wed, Aug 9, 2023 at 2:15 AM Christian König wrote: > > Am 09.08.23 um 05:44 schrieb Ruan Jinjie: > > The NULL initialization of the pointers assigned by kzalloc() first is > > not necessary, because if the kzalloc() failed, the pointers will be > > assigned NULL, otherwise

Re: [Nouveau] [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

Applied. Thanks. I've applied all the patches you sent out, but all of them had whitespace problems. Please double check your mailer on any future submissions. Thanks, Alex On Mon, Jul 10, 2023 at 6:03 AM wrote: > > Fix five occurrences of the checkpatch.pl error: > ERROR: "(foo*)" should

Re: [Nouveau] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

On Fri, Jun 16, 2023 at 10:22 AM Sui Jingfeng wrote: > > > On 2023/6/16 21:41, Alex Deucher wrote: > > On Fri, Jun 16, 2023 at 3:11 AM Sui Jingfeng > > wrote: > >> Hi, > >> > >> On 2023/6/16 05:11, Alex Deucher wrote: > >>> On Wed, J

Re: [Nouveau] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

On Fri, Jun 16, 2023 at 3:11 AM Sui Jingfeng wrote: > > Hi, > > On 2023/6/16 05:11, Alex Deucher wrote: > > On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng > > wrote: > >> Hi, > >> > >> On 2023/6/13 11:01, Sui Jingfeng wrote: > >>> Fro

Re: [Nouveau] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng wrote: > > Hi, > > On 2023/6/13 11:01, Sui Jingfeng wrote: > > From: Sui Jingfeng > > > > Deal only with the VGA devcie(pdev->class == 0x0300), so replace the > > pci_get_subsys() function with pci_get_class(). Filter the non-PCI display > >

Re: [Nouveau] [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

On Wed, Jan 18, 2023 at 11:50 AM Danilo Krummrich wrote: > > > > On 1/18/23 17:30, Alex Deucher wrote: > > On Wed, Jan 18, 2023 at 11:19 AM Danilo Krummrich wrote: > >> > >> On 1/18/23 16:37, Christian König wrote: > >>> Am 18.01.23 um 16:

Re: [Nouveau] [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

On Wed, Jan 18, 2023 at 11:19 AM Danilo Krummrich wrote: > > On 1/18/23 16:37, Christian König wrote: > > Am 18.01.23 um 16:34 schrieb Danilo Krummrich: > >> Hi Christian, > >> > >> On 1/18/23 09:53, Christian König wrote: > >>> Am 18.01.23 um 07:12 schrieb Danilo Krummrich: > This patch

Re: [Nouveau] [PATCH v3 0/3] drm/{amdgpu, i915, nouveau, radeon}: Fix fbdev and vga-switcheroo

of drm_lastclose() and drivers do not > need their own lastclose helpers any longer. > > I kept the r-bs from v1, but patch 1 is entirely new and patch 3 has > significantly grown in size. Series is: Reviewed-by: Alex Deucher > > v3: > * include drm_fb_helper.h in

Re: [Nouveau] [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h

though that probably doesn't add much coverage. > > FWIW, > > Acked-by: Jani Nikula Agreed. I applied 1/22 since it was an unrelated cleanup, but the rest of the series is: Acked-by: Alex Deucher > > > -- > Jani Nikula, Intel Open Source Graphics Center

Re: [Nouveau] [PATCH 01/22] drm/amdgpu: Fix coding style

Applied. Thanks! On Mon, Jan 16, 2023 at 8:13 AM Thomas Zimmermann wrote: > > Align a closing brace and remove trailing whitespaces. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [Nouveau] [PATCH] drm/nouveau: Remove file nouveau_fbcon.c

On Mon, Jan 9, 2023 at 10:27 AM Thomas Zimmermann wrote: > > Hi > > Am 09.01.23 um 15:15 schrieb Alex Deucher: > > On Mon, Jan 9, 2023 at 9:06 AM Thomas Zimmermann > > wrote: > >> > >> Commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev he

Re: [Nouveau] [PATCH] drm/nouveau: Remove file nouveau_fbcon.c

On Mon, Jan 9, 2023 at 9:06 AM Thomas Zimmermann wrote: > > Commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") > converted nouveau to generic fbdev emulation. Also remove the internal > implementation from the driver. No functional changes. Looking at 4a16dd9d18a0, it appears

Re: [Nouveau] [PATCH v2 14/29] drm/radeon: Register ACPI video backlight when skipping radeon backlight registration

backlight device should be used, it will be available > before the radeon drm_device gets registered with userspace. > > Signed-off-by: Hans de Goede Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_encoders.c | 11 ++- > 1 file changed, 10 insertions(+), 1 delet

Re: [Nouveau] [PATCH v2 13/29] drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration

ster_acpi_backlight: > + /* Try registering an ACPI video backlight device instead. */ > + acpi_video_register_backlight(); > + return; Can drop the return here. Either way, Acked-by: Alex Deucher > } > > void > diff --git a/drivers/gpu/drm/amd/display/amd

Re: [Nouveau] [PATCH v2 09/29] ACPI: video: Make backlight class device registration a separate step

On Tue, Jul 12, 2022 at 3:40 PM Hans de Goede wrote: > > On x86/ACPI boards the acpi_video driver will usually initializing before initializing -> initialize > the kms driver (except i915). This causes /sys/class/backlight/acpi_video0 > to show up and then the kms driver registers its own

Re: [Nouveau] [PATCH v2 03/29] drm/amdgpu: Don't register backlight when another backlight should be used

On Wed, Jul 20, 2022 at 12:44 PM Alex Deucher wrote: > > On Tue, Jul 12, 2022 at 3:39 PM Hans de Goede wrote: > > > > Before this commit when we want userspace to use the acpi_video backlight > > device we register both the GPU's native backlight device and acpi_video's

Re: [Nouveau] [PATCH v2 04/29] drm/radeon: Don't register backlight when another backlight should be used

linker errors when radeon is builtin and video_detect.c is in > a module, select ACPI_VIDEO and its deps if ACPI && X86 are enabled. > When these are not set, ACPI_VIDEO is disabled, ensuring the stubs > from acpi/video.h will be used. > > Signed-off-by: Hans de Goede

Re: [Nouveau] [PATCH v2 03/29] drm/amdgpu: Don't register backlight when another backlight should be used

linker errors when amdgpu is builtin and video_detect.c is in > a module, select ACPI_VIDEO and its deps if ACPI && X86 are enabled. > When these are not set, ACPI_VIDEO is disabled, ensuring the stubs > from acpi/video.h will be used. > > Signed-off-by: Hans de Goede

Re: [Nouveau] [RESEND RFC 17/18] drm/radeon: Drop legacy MST support

maintain the legacy MST > helpers (trying to move them would probably be acceptable), I'm happy to > suggestions. But my hope is that we can just drop this code and forget > about it. I've already run this idea by Harry Wentland and Alex Deucher a > few times as well. > > Signed-

Re: [Nouveau] Per file OOM badness

+ dri-devel On Tue, May 31, 2022 at 6:00 AM Christian König wrote: > > Hello everyone, > > To summarize the issue I'm trying to address here: Processes can allocate > resources through a file descriptor without being held responsible for it. > > Especially for the DRM graphics driver subsystem

Re: [Nouveau] [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

On Thu, Feb 24, 2022 at 8:23 PM Bjorn Helgaas wrote: > > On Thu, Feb 24, 2022 at 03:51:12PM -0600, Mario Limonciello wrote: > > The `is_thunderbolt` attribute originally had a well defined list of > > quirks that it existed for, but it has been overloaded with more > > meaning. > > > > Instead

Re: [Nouveau] [PATCH v4 00/10] Overhaul `is_thunderbolt`

On Wed, Feb 16, 2022 at 9:34 AM Mika Westerberg wrote: > > Hi all, > > On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote: > > On 2/15/2022 01:29, Lukas Wunner wrote: > > > On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: > > > >

Re: [Nouveau] [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

On Fri, Jan 28, 2022 at 2:58 PM Karol Herbst wrote: > > On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu &g

Re: [Nouveau] [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > Sigh-thank you for catching this - I had totally forgot about the umn.edu ban. > I pushed this already but I will go ahead and send a revert for this patch. > Will cc you on it as well. This seems short-sighted. If the patch is valid I see

Re: [Nouveau] [PATCH] drm/nouveau: fix dma_address check for CPU/GPU sync

On Tue, Jun 22, 2021 at 5:32 AM Christian König wrote: > > Ping? Does anybody wants to give me an rb or acked-by? > > AGP is basically broken on nouveu without this. Looks correct to me. Acked-by: Alex Deucher > > Christian. > > Am 14.06.21 um 13:05 schrieb Christian Kö

Re: [Nouveau] [PATCH 4/8] drm/radeon: Implement mmap as GEM object function

On Tue, Apr 6, 2021 at 5:09 AM Thomas Zimmermann wrote: > > Moving the driver-specific mmap code into a GEM object function allows > for using DRM helpers for various mmap callbacks. > > This change also allows to support prime-based mmap via DRM's helper > drm_gem_prime_mmap(). > > Permission

Re: [Nouveau] [PATCH 0/3] drm/ttm: constify static vm_operations_structs

On Wed, Feb 10, 2021 at 8:14 AM Daniel Vetter wrote: > > On Wed, Feb 10, 2021 at 08:45:56AM +0100, Christian König wrote: > > Reviewed-by: Christian König for the series. > > Smash it into -misc? @Christian Koenig did these ever land? I don't see them in drm-misc. Alex > -Daniel > > > > > Am

Re: [Nouveau] [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

t; Christian. > > > >> > >> Best regards > >> Thomas > >> > >>> > >>> Regards, > >>> Christian. > >>> > >>> Am 01.12.20 um 11:35 schrieb Thomas Zimmermann: > >>>> Adhere to ke

Re: [Nouveau] [PATCH 11/15] drm/radeon: Remove references to struct drm_device.pdev

On Tue, Nov 24, 2020 at 6:39 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert radeon to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelat

Re: [Nouveau] [PATCH 01/15] drm/amdgpu: Remove references to struct drm_device.pdev

On Tue, Nov 24, 2020 at 6:38 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert amdgpu to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelat

Re: [Nouveau] [PATCH 5/5] drm/: Constify struct drm_driver

irlie > Cc: Gerd Hoffmann > Cc: virtualizat...@lists.linux-foundation.org > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: Christian König > Cc: Eric Anholt > Cc: Maxime Ripard > Cc: Ben Skeggs > Cc: nouveau@lists.freedesktop.org > Signed-off-by:

Re: [Nouveau] [PATCH 1/4] drm: retrieve EDID via ACPI _DDC method

On Wed, Aug 12, 2020 at 10:31 PM Daniel Dadap wrote: > > Thanks, Lukas. I've incorporated your feedback into my local tree, but > will wait for additional feedback from the individual DRM driver > maintainers before sending out a series v2. > > On 8/8/20 5:11 PM, Lukas Wunner wrote: > > On Mon,

Re: [Nouveau] [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

On Fri, May 22, 2020 at 6:41 AM Christian König wrote: > > Am 20.05.20 um 18:18 schrieb Alex Deucher: > > On Wed, May 20, 2020 at 10:43 AM Christian König > > wrote: > >> Am 13.05.20 um 13:03 schrieb Christian König: > >>> Unfortunately AGP is still to wi

Re: [Nouveau] [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

On Wed, May 20, 2020 at 10:43 AM Christian König wrote: > > Am 13.05.20 um 13:03 schrieb Christian König: > > Unfortunately AGP is still to widely used as we could just drop support for > > using its GART. > > > > Not using the AGP GART also doesn't mean a loss in functionality since > >

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

On Tue, May 12, 2020 at 4:52 PM Roy Spliet wrote: > > Op 12-05-2020 om 14:36 schreef Alex Deucher: > > On Tue, May 12, 2020 at 4:16 AM Michel Dänzer wrote: > >> > >> On 2020-05-11 10:12 p.m., Alex Deucher wrote: > >>> On Mon, May 11, 20

Re: [Nouveau] [RFC] Remove AGP support from Radeon/Nouveau/TTM

On Tue, May 12, 2020 at 3:10 PM Thomas Zimmermann wrote: > > Hi Alex > > Am 12.05.20 um 20:32 schrieb Alex Deucher: > > On Tue, May 12, 2020 at 2:29 PM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 11.05.20 um 19:17 schrieb

Re: [Nouveau] [RFC] Remove AGP support from Radeon/Nouveau/TTM

On Tue, May 12, 2020 at 2:29 PM Thomas Zimmermann wrote: > > Hi > > Am 11.05.20 um 19:17 schrieb Christian König: > > Hi guys, > > > > Well let's face it AGP is a total headache to maintain and dead for at > > least 10+ years. > > > > We have a lot of x86 specific stuff in the architecture

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

On Tue, May 12, 2020 at 2:20 PM Thomas Zimmermann wrote: > > Hi Christian > > Am 11.05.20 um 19:17 schrieb Christian König: > > AGP is deprecated for 10+ years now and not used any more on modern > > hardware. > > > > Old hardware should continue to work in PCI mode. > > > > Signed-off-by:

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

On Tue, May 12, 2020 at 4:16 AM Michel Dänzer wrote: > > On 2020-05-11 10:12 p.m., Alex Deucher wrote: > > On Mon, May 11, 2020 at 1:17 PM Christian König > > wrote: > >> > >> AGP is deprecated for 10+ years now and not used any more on modern > >

Re: [Nouveau] [RFC] Remove AGP support from Radeon/Nouveau/TTM

On Mon, May 11, 2020 at 4:22 PM Al Dunsmuir wrote: > > On Monday, May 11, 2020, 1:17:19 PM, "Christian König" wrote: > > Hi guys, > > > Well let's face it AGP is a total headache to maintain and dead for at > > least 10+ years. > > > We have a lot of x86 specific stuff in the architecture

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

here is no change on PowerPC." With that updated, patches 1, 3: Reviewed-by: Alex Deucher patch 2: Acked-by: Alex Deucher > > Signed-off-by: Christian König > --- > drivers/gpu/drm/radeon/Makefile| 4 +- > drivers/gpu/drm/radeon/evergreen.c | 7 - > driv

Re: [Nouveau] [PATCH v4 05/22] drm/amdgpu: Convert to CRTC VBLANK callbacks

t; Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 > drivers/gpu

Re: [Nouveau] [PATCH v4 04/22] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

On Thu, Jan 23, 2020 at 9:00 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > amdgpu over. > > Signed-off-by: Thomas Zimmermann Reviewe

Re: [Nouveau] [PATCH v4 10/22] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

> Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/radeon/atombios_crtc.c | 1 + > drivers/gpu/drm/radeon/radeon_display.c | 13 + > drivers/gpu/drm/radeon/radeon_drv.c | 11 --- > drivers/gpu/drm/radeon/radeon

Re: [Nouveau] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > amdgpu over. > I would prefer to just change the signature of

Re: [Nouveau] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

On Wed, Jan 15, 2020 at 4:41 AM Thomas Zimmermann wrote: > > Hi > > Am 13.01.20 um 19:52 schrieb Alex Deucher: > > On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann > > wrote: > >> > >> The callback struct drm_driver.get_scanout_positi

Re: [Nouveau] [PATCH 12/23] drm/amdgpu: Convert to CRTC VBLANK callbacks

On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert amdgpu over. I think I'd prefer to just update the signatures of the relevant functions rather than wrapping them.

Re: [Nouveau] [PATCH 17/23] drm/radeon: Convert to CRTC VBLANK callbacks

On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert radeon over. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > d

Re: [Nouveau] [PATCH 05/23] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > radeon over. > I'd prefer to just change the signature of radeon_get_crtc_scanoutpos() to

Re: [Nouveau] [PATCH v2 23/27] drm/amdgpu: Iterate through DRM connectors correctly

On Fri, Sep 13, 2019 at 4:45 PM Alex Deucher wrote: > > On Tue, Sep 3, 2019 at 4:49 PM Lyude Paul wrote: > > > > Currently, every single piece of code in amdgpu that loops through > > connectors does it incorrectly and doesn't use the proper li

Re: [Nouveau] [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula wrote: > > On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote: > > drivers/gpu/drm/i915/Kconfig | 12 +- > > drivers/gpu/drm/i915/Kconfig.debug | 144 +++ > > Please split these out to a separate patch. Can't speak for

Re: [Nouveau] [PATCH v2 23/27] drm/amdgpu: Iterate through DRM connectors correctly

esh. > > So, do that. In fairness, I think the origin of this code predated the iterators. Reviewed-by: Alex Deucher > > Cc: Juston Li > Cc: Imre Deak > Cc: Ville Syrjälä > Cc: Harry Wentland > Cc: Daniel Vetter > Signed-off-by: Lyude Paul > --- > ..

Re: [Nouveau] [PATCH v2 24/27] drm/amdgpu/dm: Resume short HPD IRQs before resuming MST topology

do that. > > Cc: Juston Li > Cc: Imre Deak > Cc: Ville Syrjälä > Cc: Harry Wentland > Cc: Daniel Vetter > Signed-off-by: Lyude Paul Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

On Thu, Sep 5, 2019 at 11:51 AM Karol Herbst wrote: > > is there any update on the testing with my patches? On the hardware I > had access to those patches helped, but I can't know if it also helped > on the hardware for which those workarounds where actually added. > > On Mon, Aug 19, 2019 at

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

On Thu, Aug 15, 2019 at 12:19 PM wrote: > > > -Original Message- > > From: Takashi Iwai > > Sent: Thursday, August 15, 2019 9:57 AM > > To: Alex Deucher > > Cc: Karol Herbst; Limonciello, Mario; nouveau; Rafael J . Wysocki; LKML; > > dri-devel;

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

On Thu, Aug 15, 2019 at 10:37 AM Alex Deucher wrote: > > On Thu, Aug 15, 2019 at 10:25 AM Karol Herbst wrote: > > > > On Thu, Aug 15, 2019 at 4:20 PM wrote: > > > > > > > > There are definitely going to be regressions on machines in the field &g

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

On Thu, Aug 15, 2019 at 10:30 AM wrote: > > > On Thu, Aug 15, 2019 at 10:15 AM Karol Herbst wrote: > > > > > > On Thu, Aug 15, 2019 at 4:13 PM Alex Deucher > > wrote: > > > > > > > > On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst > &

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

On Thu, Aug 15, 2019 at 10:25 AM Karol Herbst wrote: > > On Thu, Aug 15, 2019 at 4:20 PM wrote: > > > > > > There are definitely going to be regressions on machines in the field > > > > with the > > > > in tree drivers by reverting this. I think we should have an answer > > > > for all of > >

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

On Thu, Aug 15, 2019 at 10:15 AM Karol Herbst wrote: > > On Thu, Aug 15, 2019 at 4:13 PM Alex Deucher wrote: > > > > On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst wrote: > > > > > > On Thu, Aug 15, 2019 at 3:56 PM wrote: > > > > > > >

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst wrote: > > On Thu, Aug 15, 2019 at 3:56 PM wrote: > > > > > -Original Message- > > > From: linux-acpi-ow...@vger.kernel.org > > > On > > > Behalf Of Dave Airlie > > > Sent: Wednesday, August 14, 2019 5:48 PM > > > To: Karol Herbst > > > Cc:

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote: > > On 2019-08-06 13:44, Jason Gunthorpe wrote: > > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > >> The option is just used to select HMM mirror support and has a very > >> confusing help text. Just pull in the HMM

Re: [Nouveau] [PATCH] drm: Mark expected switch fall-throughs

On Fri, Feb 15, 2019 at 11:08 AM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in some cases, the code comment is modified > in

Re: [Nouveau] [PATCH] drm: Split out drm_probe_helper.h

e there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? > > Jani, ack on this? > -Daniel amdgpu and radeon: Acked-by: Alex Deucher ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 4/7] drm: Move the legacy kms disable_all helper to crtc helpers

> Cc: Sam Bobroff > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Ben Skeggs > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: Rex Zhu >

Re: [Nouveau] [PATCH 4/7] drm: Move the legacy kms disable_all helper to crtc helpers

On Tue, Dec 11, 2018 at 10:53 AM Sean Paul wrote: > > On Mon, Dec 10, 2018 at 10:58:20AM -0500, Alex Deucher wrote: > > On Mon, Dec 10, 2018 at 5:04 AM Daniel Vetter > > wrote: > > > > > > It's not a core function, and the matching atomic functions

Re: [Nouveau] [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

gt; > >> Signed-off-by: Hans Verkuil > >> Acked-by: Alex Deucher > >> --- > >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++-- > >> .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 ++ > >> 2 files changed, 13

Re: [Nouveau] [PATCH 0/5] drm/nouveau+amdgpu: add DP CEC-Tunneling-over-AUX

e, an older less featured version (amd/amdgpu/dce*.c) and the newer more featured code (amd/display/*). Newer asics (vega and raven) are only supported by DC. Older asics are supported by both. Eventually we'd like to remove the older modesetting code. I'm not really a CEC expert, but the p

Re: [Nouveau] [PATCH v3 3/8] drm/fb_helper: Introduce hotplug_suspend/resume()

On Mon, Aug 6, 2018 at 3:34 PM, Lukas Wunner wrote: > On Mon, Aug 06, 2018 at 03:15:31PM -0400, Lyude Paul wrote: >> You did mention in the review of one of my other patches that we should avoid >> disabling polling during runtime suspend, and you're definitely right. I feel >> a bit silly for

Re: [Nouveau] [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Mon, Feb 19, 2018 at 9:54 AM, Daniel Vetter wrote: > On Mon, Feb 19, 2018 at 03:47:42PM +0100, Lukas Wunner wrote: >> On Mon, Feb 19, 2018 at 03:05:53PM +0100, Daniel Vetter wrote: >> > On Mon, Feb 19, 2018 at 12:58:17PM +0100, Lukas Wunner wrote: >> > > On Mon, Feb 19, 2018

Re: [Nouveau] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Tue, Feb 13, 2018 at 3:17 AM, Lukas Wunner <lu...@wunner.de> wrote: > On Mon, Feb 12, 2018 at 01:58:32PM -0500, Alex Deucher wrote: >> On Mon, Feb 12, 2018 at 4:45 AM, Lukas Wunner <lu...@wunner.de> wrote: >> > On Mon, Feb 12, 2018 at 09:03:26AM +, Mike Lothi

Re: [Nouveau] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

On Mon, Feb 12, 2018 at 4:45 AM, Lukas Wunner wrote: > On Mon, Feb 12, 2018 at 09:03:26AM +, Mike Lothian wrote: >> On 12 February 2018 at 03:39, Lukas Wunner wrote: >> > On Mon, Feb 12, 2018 at 12:35:51AM +, Mike Lothian wrote: >> > > I've not been able

Re: [Nouveau] swiotlb buffer is full

On Wed, Jan 31, 2018 at 9:20 PM, Ilia Mirkin wrote: > Yeah, a lot of people were getting that, as a result of some drm/ttm > hugepage usage. > > Christian, did a fix ever end up going out? If so, what kernel was it > included in? https://lkml.org/lkml/2018/1/16/106 Alex >

Re: [Nouveau] [PATCH v5 0/3] Allow ASYNC flip with atomic helpers.

gt; Rename the flag, fix typo in header. Looks good. The series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Unless there are any objections I'll push to drm-misc today. Thanks! Alex > > Andrey Grodzovsky (3): > drm/atomic: Save flip flags in drm_crtc_state

Re: [Nouveau] [PATCH v4 0/3] Allow ASYNC flip with atomic helpers.

; Andrey Grodzovsky (3): > drm/atomic: Save flip flags in drm_crtct_state > drm/nouveau/kms/nv50: Switch to using atomic helper for flip. > drm/amd/display: Switch to using atomic_helper for flip. A few comments on patch 1. WIth those addressed the series is: Reviewed-by: Ale

Re: [Nouveau] [PATCH v4 1/3] drm/atomic: Save flip flags in drm_crtct_state

On Wed, Feb 1, 2017 at 12:03 PM, Andrey Grodzovsky wrote: > Allows using atomic flip helpers for drivers > using ASYNC flip. > Remove ASYNC_FLIP restriction in helpers and > caches the page flip flags in drm_crtc_state > to be used in the low level drivers. > > v2: >

Re: [Nouveau] [PATCH v2 2/2] drm: Get atomic property value even if DRIVER_ATOMIC is not set

On Wed, Dec 21, 2016 at 3:12 PM, Dhinakaran Pandiyan wrote: > i915 does not set DRIVER_ATOMIC by default yet but uses atomic_check and > atomic_commit. drm_object_property_get_value() does not read the correct > value of atomic properties if DRIVER_ATOMIC is not

Re: [Nouveau] [PATCH v2] drm/nouveau/acpi: fix check for power resources support

On Tue, Nov 1, 2016 at 3:00 PM, Peter Wu <pe...@lekensteyn.nl> wrote: > On Tue, Nov 01, 2016 at 09:24:23AM -0400, Alex Deucher wrote: >> On Tue, Nov 1, 2016 at 12:55 AM, Dave Airlie <airl...@gmail.com> wrote: >> > On 1 November 2016 at 08:48, Peter Wu <pe...@

Re: [Nouveau] [PATCH v2] drm/nouveau/acpi: fix check for power resources support

On Tue, Nov 1, 2016 at 12:55 AM, Dave Airlie wrote: > On 1 November 2016 at 08:48, Peter Wu wrote: >> Check whether the kernel really supports power resources for a device, >> otherwise the power might not be removed when the device is runtime >> suspended

Re: [Nouveau] [PATCH v3 0/4] nouveau RPM fixes for Optimus (final)

On Fri, Jul 15, 2016 at 12:31 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Fri, Jul 15, 2016 at 12:27 PM, Alex Deucher <alexdeuc...@gmail.com> wrote: >> On Fri, Jul 15, 2016 at 12:10 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >>> On Fri, J

Re: [Nouveau] [PATCH v3 0/4] nouveau RPM fixes for Optimus (final)

On Fri, Jul 15, 2016 at 12:10 PM, Ilia Mirkin wrote: > On Fri, Jul 15, 2016 at 9:12 AM, Peter Wu wrote: >> Hi, >> >> Here are two patches to fix an issue reported on kernel bugzilla (infinite >> loop >> due to unchecked function) and a more important

Re: [Nouveau] [PATCH v2 00/15] Runtime pm ref leak bonanza

per. > > Yeah I think this makes much more sense. Please poke amd/nouveau folks for > reviews/acks, then I can merge. The amdgpu, radeon, and drm patches are: Acked-by: Alex Deucher <alexander.deuc...@amd.com> > -Daniel > >> >> To ease reviewing, I've pushed this seri

Re: [Nouveau] AGP cards in PCI mode (fake slots like AGPro, AGP Express, AGI, AGX, XGP)

On Sun, Sep 13, 2015 at 2:57 PM, Ondrej Zary wrote: > Hello, > I have a PC Chips A31G board with AGPro slot and found that nouveau does not > work properly with it. Console works but reverts to software mode, X11 hangs > with mouse cursor only. > > The slot is

Re: [Nouveau] [Mesa-dev] gallium state tracker calls calloc for 0 sizes arrays ?

On Thu, Aug 27, 2015 at 1:55 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 27-08-15 15:46, Marek Olšák wrote: On Thu, Aug 27, 2015 at 3:09 PM, Hans de Goede hdego...@redhat.com wrote: Hi All, While debugging: https://bugzilla.redhat.com/show_bug.cgi?id=1008089 I made a apitrace

Re: [Nouveau] [PATCH v2 09/17] drm/radeon: use common fence implementation for fences

On Wed, Jul 9, 2014 at 9:23 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 09-07-14 14:57, Deucher, Alexander schreef: snip +static const char *radeon_fence_get_timeline_name(struct fence *f) +{ +struct radeon_fence *fence = to_radeon_fence(f); +switch (fence-ring) {

Re: [Nouveau] [PATCH] drm/nouveau/agp: add a quirk list to limit agp modes

On Sun, Oct 27, 2013 at 11:01 PM, Robert Hancock hancock...@gmail.com wrote: On 10/27/2013 09:54 AM, Ilia Mirkin wrote: Certain combinations of hardware can't actually support the maximum detected speed. Add a quirk list that lists pairs of hostbridge/chip pci ids and the mode that they

Re: [Nouveau] [PATCH 07/10] drm: extract dp link train delay functions from radeon

, dig_connector-dpcd, DP_RECEIVER_CAP_SIZE); With that change: Reviewed-by: Alex Deucher alexander.deuc...@amd.com diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h index d569789..e5b668e 100644 --- a/drivers/gpu/drm/radeon/radeon_mode.h +++ b/drivers/gpu/drm

Re: [Nouveau] [PATCH 00/10] extract dp helper functions

On Thu, Oct 18, 2012 at 4:15 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: Hi all, I've frustrated myself the last few days yelling at our link training code. Comparing the i915 code to radeon and nouveau I've noticed the lack of a nice set of dp helper functions. So I've started to extract