Re: [Nouveau] Coverity: nouveau_dp_irq(): Null pointer dereferences

2022-11-11 Thread Karol Herbst
On Fri, Nov 11, 2022 at 9:16 PM Kees Cook wrote: > > On Fri, Nov 11, 2022 at 09:06:54PM +0100, Karol Herbst wrote: > > On Fri, Nov 11, 2022 at 8:21 PM Kees Cook wrote: > > > > > > On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote: > > > >

Re: [Nouveau] Coverity: nouveau_dp_irq(): Null pointer dereferences

2022-11-11 Thread Karol Herbst
4 insertions(+), 137 deletions(-) > > And the get_maintainers.pl rationale was: > > Ben Skeggs (supporter:DRM DRIVER FOR NVIDIA > GEFORCE/QUADRO > GPUS,commit_signer:1/1=100%,commit_signer:6/16=38%,authored:4/16=25%,added_lines:23/124=19%,removed_lines:36/152=24%) > Karol Herbs

Re: [Nouveau] Fans ramping up randomly when idle

2022-11-10 Thread Karol Herbst
On Thu, Nov 10, 2022 at 4:01 PM Timothy Madden wrote: > > On 11/7/22 13:41, Karol Herbst wrote: > > On Sat, Nov 5, 2022 at 8:36 PM Timothy Madden > > wrote: > >> > >> Hello > >> > >> My Msi Gaming X Trio 2080 Ti randomly ramps up the fa

Re: [Nouveau] Fans ramping up randomly when idle

2022-11-09 Thread Karol Herbst
On Sat, Nov 5, 2022 at 8:36 PM Timothy Madden wrote: > > Hello > > My Msi Gaming X Trio 2080 Ti randomly ramps up the fans with no way to recover > (I have to reboot) even when the card is idle or is only showing the desktop. > > This issue happens even when the card is not connected to a

Re: [Nouveau] [PATCH v3] drm/nouveau: Add support to control backlight using bl_power for nva3.

2022-11-09 Thread Karol Herbst
cklight_get_brightness(bd); > + if (val) > + val = (val * div) / 100; > + > if (div) { > nvif_wr32(device, NV50_PDISP_SOR_PWM_CTL(or), > val | > -- > 2.25.1 > Reviewed-by: Karol Herbst btw, i'll fix up the name with the one from the Email From field, so you won't have to send it out again.

Re: [Nouveau] Fans ramping up randomly when idle

2022-11-07 Thread Karol Herbst
On Sat, Nov 5, 2022 at 8:36 PM Timothy Madden wrote: > > Hello > > My Msi Gaming X Trio 2080 Ti randomly ramps up the fans with no way to recover > (I have to reboot) even when the card is idle or is only showing the desktop. > > This issue happens even when the card is not connected to a

Re: [Nouveau] [PATCH] nouveau: explicitly wait on the fence in nouveau_bo_move_m2mf

2022-11-01 Thread Karol Herbst
On Tue, Nov 1, 2022 at 7:45 AM Computer Enthusiastic wrote: > > Hello, > > Il giorno ven 19 ago 2022 alle ore 22:09 Karol Herbst > ha scritto: > > > > It is a bit unlcear to us why that's helping, but it does and unbreaks > > suspend/resume on a lot of

Re: [Nouveau] [PATCH] drm/nouveau: Add support to control backlight using bl_power for nva3.

2022-11-01 Thread Karol Herbst
On Tue, Nov 1, 2022 at 3:12 AM Bagas Sanjaya wrote: > > On 10/31/22 23:32, antoniospg wrote: > > Summary: > > > > * Add support to turn on/off backlight when changing values in bl_power > > file. This is achieved by using function backlight_get_brightness() > > in nva3_set_intensity to get

Re: [Nouveau] [PATCH] nouveau: explicitly wait on the fence in nouveau_bo_move_m2mf

2022-09-20 Thread Karol Herbst
On Tue, Sep 20, 2022 at 12:42 PM Salvatore Bonaccorso wrote: > > Hi, > > On Fri, Aug 19, 2022 at 10:09:28PM +0200, Karol Herbst wrote: > > It is a bit unlcear to us why that's helping, but it does and unbreaks > > suspend/resume on a lot of GPUs without any known dr

Re: [Nouveau] [PATCH] subdev/clk: fix repeated words in comments

2022-08-21 Thread Karol Herbst
Reviewed-by: Karol Herbst thanks, and I'll push in a moment. On Sun, Aug 21, 2022 at 4:34 PM wangjianli wrote: > > Delete the redundant word 'at'. > > Signed-off-by: wangjianli > --- > drivers/gpu/drm/nouveau/nvkm/subdev/clk/gm20b.c | 2 +- > 1 file changed, 1 ins

[Nouveau] [PATCH] nouveau: explicitly wait on the fence in nouveau_bo_move_m2mf

2022-08-19 Thread Karol Herbst
It is a bit unlcear to us why that's helping, but it does and unbreaks suspend/resume on a lot of GPUs without any known drawbacks. Cc: sta...@vger.kernel.org # v5.15+ Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/156 Signed-off-by: Karol Herbst --- drivers/gpu/drm/nouveau

Re: [Nouveau] [RFC 0/2] Stop the abuse of Linux-* _OSI strings

2022-08-19 Thread Karol Herbst
On Fri, Aug 19, 2022 at 6:43 PM Limonciello, Mario wrote: > > On 8/19/2022 11:37, Karol Herbst wrote: > > On Fri, Aug 19, 2022 at 6:00 PM Limonciello, Mario > > wrote: > >> > >> On 8/19/2022 10:44, Karol Herbst wrote: > >>> On Fri, Aug 19

Re: [Nouveau] [RFC 0/2] Stop the abuse of Linux-* _OSI strings

2022-08-19 Thread Karol Herbst
On Fri, Aug 19, 2022 at 6:00 PM Limonciello, Mario wrote: > > On 8/19/2022 10:44, Karol Herbst wrote: > > On Fri, Aug 19, 2022 at 4:25 PM Mario Limonciello > > wrote: > >> > >> 3 _OSI strings were introduced in recent years that were intended > >&g

Re: [Nouveau] [RFC 0/2] Stop the abuse of Linux-* _OSI strings

2022-08-19 Thread Karol Herbst
On Fri, Aug 19, 2022 at 4:25 PM Mario Limonciello wrote: > > 3 _OSI strings were introduced in recent years that were intended > to workaround very specific problems found on specific systems. > > The idea was supposed to be that these quirks were only used on > those systems, but this proved to

Re: [Nouveau] Advice about debugging nouveau driver suspend issue (init_on_alloc=1 and init_on_free=1)

2022-08-18 Thread Karol Herbst
On Thu, Aug 18, 2022 at 10:39 PM Lyude Paul wrote: > > So then - if we can get this patch re-submitted with the /* TODO */ added, > I'll be happy to push this > yeah, I'll send something out tomorrow then. > On Fri, 2022-08-12 at 01:07 +0200, Karol Herbst wrote: > > On Th

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv140-: Disable interlacing

2022-08-16 Thread Karol Herbst
connector->interlace_allowed = > + drm->client.device.info.family < > NV_DEVICE_INFO_V0_VOLTA; > connector->doublescan_allowed = true; > } else > if (nv_encoder->dcb->type == DCB_OUTPUT_LVDS || > -- > 2.37.1 > Reviewed-by: Karol Herbst

Re: [Nouveau] Advice about debugging nouveau driver suspend issue (init_on_alloc=1 and init_on_free=1)

2022-08-11 Thread Karol Herbst
On Thu, Aug 11, 2022 at 11:20 PM Lyude Paul wrote: > > On Thu, 2022-08-11 at 00:08 +0200, Karol Herbst wrote: > > the thing is, without this patch, the "hw path" fails with a timeout > > of... 30 seconds?, the code falls back to sw and it takes up to 2-3 >

Re: [Nouveau] Advice about debugging nouveau driver suspend issue (init_on_alloc=1 and init_on_free=1)

2022-08-10 Thread Karol Herbst
On Wed, Aug 10, 2022 at 11:35 PM Lyude Paul wrote: > > On Wed, 2022-08-10 at 13:59 +0200, Karol Herbst wrote: > > On Wed, Aug 10, 2022 at 12:42 PM Computer Enthusiastic > > wrote: > > > > > > Hello, > > > > > > The "supend to ram&quo

Re: [Nouveau] Blank screen after upgrade Fedora 34/XFCE -> Fedora 36/XFCE

2022-08-10 Thread Karol Herbst
On Wed, Aug 10, 2022 at 9:04 PM Klaus Ebbe Grue wrote: > > Hi nouveau@lists.freedesktop.org, > > > I hope someone on this list can point me in some useful direction concerning the following problem: > > > After upgrade from Fedora 34/XFCE to Fedora 36/XFCE, I experience a black screen instead of

Re: [Nouveau] Advice about debugging nouveau driver suspend issue (init_on_alloc=1 and init_on_free=1)

2022-08-10 Thread Karol Herbst
GeForce 9600M GT and > other nvidia graphic card with the same chipset [1][2][3]. > > I've been successfully using the "work in progress" patch by Karol > Herbst [4] to solve the "supend to ram" issue since it was proposed > for an apparent different issue (&quo

[Nouveau] [PATCH] drm/nouveau: recognise GA103

2022-08-03 Thread Karol Herbst
Appears to be ok with general GA10x code. Signed-off-by: Karol Herbst Cc: # v5.15+ --- .../gpu/drm/nouveau/nvkm/engine/device/base.c | 22 +++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c b/drivers/gpu/drm/nouveau/nvkm/engine

Re: [Nouveau] nVidia has freed some modules, what to expect for Nouveau

2022-05-12 Thread Karol Herbst
On Thu, May 12, 2022 at 2:08 AM Yoann LE BARS wrote: > > > Hello, everybody out there! > > It turns out nVidia has recently released some source concerning GPU > kernel module: > > https://github.com/NVIDIA/open-gpu-kernel-modules > > At first sight, it seems to me some good news.

Re: [Nouveau] [PATCH] drm/nouveau: fix another off-by-one in nvbios_addr

2022-05-11 Thread Karol Herbst
*addr; > > - if (*addr > bios->image0_size && bios->imaged_addr) { > + if (*addr >= bios->image0_size && bios->imaged_addr) { > *addr -= bios->image0_size; > *addr += bios->imaged_addr; > } > -

Re: [Nouveau] [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-05-03 Thread Karol Herbst
Actually, there is another place we have to put this, we can spam "SCHED_ERROR" things which are triggered within multiple drivers/gpu/drm/nouveau/nvkm/engine/fifo/ files. On Tue, May 3, 2022 at 9:23 PM Karol Herbst wrote: > > not able to hit any error on my machine, but regardle

Re: [Nouveau] [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-05-03 Thread Karol Herbst
not able to hit any error on my machine, but regardless: Reviewed-by: Karol Herbst I suspect there are more places where we could put it, but we can add those later. Anyway, I think it's valuable to push it through fixes, not sure how far back we want to CC stable though. On Fri, Apr 29, 2022

Re: [Nouveau] [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-04-30 Thread Karol Herbst
On Sat, Apr 30, 2022 at 1:04 AM Lyude Paul wrote: > > On Sat, 2022-04-30 at 00:56 +0200, Karol Herbst wrote: > > On Fri, Apr 29, 2022 at 9:54 PM Lyude Paul wrote: > > > > > > There's plenty of ways to fudge the GPU when developing on nouveau by > > > mista

Re: [Nouveau] [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-04-29 Thread Karol Herbst
On Fri, Apr 29, 2022 at 9:54 PM Lyude Paul wrote: > > There's plenty of ways to fudge the GPU when developing on nouveau by > mistake, some of which can result in nouveau seriously spamming dmesg with > fault errors. This can be somewhat annoying, as it can quickly overrun the > message buffer

Re: [Nouveau] [PATCH 06/23] drm/nouveau: stop using dma_resv_excl_fence

2022-04-04 Thread Karol Herbst
> > > > Signed-off-by: Christian König > > Reviewed-by: Daniel Vetter > > Cc: Ben Skeggs > > Cc: Karol Herbst > > Cc: Lyude Paul > > Cc: nouveau@lists.freedesktop.org > > --- > > drivers/gpu/drm/nouveau/nouveau_bo.c | 9 - > >

[Nouveau] [PATCH] drm/nouveau/pmu: Add missing callbacks for Tegra devices

2022-03-22 Thread Karol Herbst
Fixes a crash booting on those platforms with nouveau. Fixes: 4cdd2450bf73 ("drm/nouveau/pmu/gm200-: use alternate falcon reset sequence") Cc: Ben Skeggs Cc: Karol Herbst Cc: dri-de...@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: # v5.17+ Signed-off-by: Ka

Re: [Nouveau] [PATCH v2 13/22] drm/nouveau/kms: Remove redundant zpos initialisation

2022-02-22 Thread Karol Herbst
On Tue, Feb 22, 2022 at 3:02 PM Maxime Ripard wrote: > > Hi, > > On Mon, Feb 21, 2022 at 05:42:36PM +0100, Karol Herbst wrote: > > On Mon, Feb 21, 2022 at 11:00 AM Maxime Ripard wrote: > > > > > > The nouveau KMS driver will call drm_plane_create_zpos

Re: [Nouveau] [PATCH v2 13/22] drm/nouveau/kms: Remove redundant zpos initialisation

2022-02-21 Thread Karol Herbst
in nv50_wndw_reset(). However, the helpers have been > adjusted to set it properly at reset, so this is not needed anymore. > > Cc: nouveau@lists.freedesktop.org > Cc: Ben Skeggs > Cc: Karol Herbst > Cc: Lyude Paul > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/nou

Re: [Nouveau] [PATCH] drm/nouveau/backlight: Just set all backlight types as RAW

2022-02-08 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Feb 4, 2022 at 8:33 PM Lyude Paul wrote: > > Currently we can get a warning on systems with eDP backlights like so: > > nv_backlight: invalid backlight type > WARNING: CPU: 4 PID: 454 at drivers/video/backlight/

Re: [Nouveau] [PATCH] drm/nouveau/backlight: Fix LVDS backlight detection on some laptops

2022-02-08 Thread Karol Herbst
reaking muxed systems where we have two GPUs, but.. the systems I know of have different ways of controlling the backlight anyway. So unless there is something I missed this is Reviewed-by: Karol Herbst > Signed-off-by: Lyude Paul > Fixes: 6eca310e8924 ("drm/nouveau/kms/nv50-: Add ba

[Nouveau] [PATCH] drm/nouveau/mmu: fix reuse of nvkm_umem

2022-02-07 Thread Karol Herbst
I am not entirely sure if this fixes anything, but the code standed out while investigated problematic calls to vunmap. nvkm_umem.io is only ever set for the NVKM_OBJECT_MAP_IO case in nvkm_umem_map, but never for the NVKM_OBJECT_MAP_VA one, which could lead to taking the wrong patch inside

[Nouveau] [PATCH] Revert "drm/nouveau/pmu/gm200-: avoid touching PMU outside of DEVINIT/PREOS/ACR"

2022-02-05 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../gpu/drm/nouveau/nvkm/subdev/pmu/base.c| 37 --- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/base.c index 455e95a89259..24382875fb4f

Re: [Nouveau] [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Karol Herbst
On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > > ban. > > I pushed this already but I will go ahead and send a revert for this patch. > > Will cc you on

Re: [Nouveau] [PATCH] drm/nouveau: fix off by one in BIOS boundry checking

2022-01-24 Thread Karol Herbst
o nitpicks: provided and accessed Also, I think it makes sense to add Fixes: 4d4e9907ff572 "drm/nouveau/bios: guard against out-of-bounds accesses to image" Cc: # v4.10+ so it gets automatically backported to applicable stable kernels Anyway, whoever picks the patch can make tho

Re: [Nouveau] Piglit results for NV46 and glitches using GeForce 7500LE

2022-01-11 Thread Karol Herbst
I've fixed a really really really old bug in mesa which impacted gnome: https://gitlab.freedesktop.org/mesa/mesa/-/commit/1387d1d41103b3120d40f93f66a7cfe00304bfd7 this one is part of 21.3 and should have made it into 21.1 and 21.2 stable releases. We also have two pending merge requests which

Re: [Nouveau] Regression in 5.15 in nouveau

2021-12-07 Thread Karol Herbst
On Tue, Dec 7, 2021 at 10:52 AM Christian König wrote: > > Am 06.12.21 um 19:37 schrieb Dan Moulding: > > On 04.12.21 17:40, Stefan Fritsch wrote: > >> Hi, > >> > >> when updating from 5.14 to 5.15 on a system with NVIDIA GP108 [GeForce > >> GT 1030] (NV138) and Ryzen 9 3900XT using kde/plasma on

Re: [Nouveau] [INVALID_ARG] mthd 0414

2021-11-19 Thread Karol Herbst
On Fri, Nov 19, 2021 at 2:00 PM dmanye wrote: > > On 19/11/21 13:31, Karol Herbst wrote: > > yeah.. not quite sure yet. I tried it out with my gk208b gpus, but > > couldn't hit anything. Maybe using VGA makes the difference here. Or > > something else is different. Mig

Re: [Nouveau] [INVALID_ARG] mthd 0414

2021-11-19 Thread Karol Herbst
On Fri, Nov 19, 2021 at 9:10 AM dmanye wrote: > > On 18/11/21 16:13, Karol Herbst wrote: > > On Thu, Nov 18, 2021 at 2:59 PM dmanye wrote: > >> hello, > >> > >> i have a problem and i think that it is in the nouveau driver. i hope > >> you can he

Re: [Nouveau] [INVALID_ARG] mthd 0414

2021-11-18 Thread Karol Herbst
On Thu, Nov 18, 2021 at 2:59 PM dmanye wrote: > > hello, > > i have a problem and i think that it is in the nouveau driver. i hope > you can help me... > > i have 20 identical computers with debian bullseye (11) installed (only > "official" debian packages). sometimes some of them boot but the

Re: [Nouveau] [PATCH] drm/nouveau: recognise GA106

2021-11-18 Thread Karol Herbst
Cc: stable? On Thu, Nov 18, 2021 at 4:04 AM Ben Skeggs wrote: > > From: Ben Skeggs > > I've got HW now, appears to work as expected so far. > > Signed-off-by: Ben Skeggs > --- > .../gpu/drm/nouveau/nvkm/engine/device/base.c | 22 +++ > 1 file changed, 22 insertions(+) > > diff

Re: [Nouveau] [PATCH] drm/nouveau/core: fix the uninitialized use in nvkm_ioctl_map()

2021-11-16 Thread Karol Herbst
were also a bit broken. I just suspect that when sending it something went wrong or so. > On Sat, Nov 13, 2021 at 12:22 PM Karol Herbst wrote: > > > > something seems to have messed with the patch so it doesn't apply correctly. > > > > On Thu, Jun 17, 2021 at 9:39 AM Y

Re: [Nouveau] [PATCH] drm/nouveau/core: fix the uninitialized use in nvkm_ioctl_map()

2021-11-13 Thread Karol Herbst
something seems to have messed with the patch so it doesn't apply correctly. On Thu, Jun 17, 2021 at 9:39 AM Yizhuo Zhai wrote: > > In function nvkm_ioctl_map(), the variable "type" could be > uninitialized if "nvkm_object_map()" returns error code, > however, it does not check the return value

[Nouveau] [PATCH] MAINTAINERS: update information for nouveau

2021-11-10 Thread Karol Herbst
-by: Karol Herbst --- MAINTAINERS | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8805df335326..270dc9c0a427 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5961,10 +5961,17 @@ F: drivers/gpu/drm/panel/panel-novatek-nt36672a.c DRM DRIVER

Re: [Nouveau] [PATCH] ce/gf100: fix incorrect CE0 address calculation on some GPUs

2021-11-03 Thread Karol Herbst
On Wed, Nov 3, 2021 at 8:51 AM Karol Herbst wrote: > > On Wed, Nov 3, 2021 at 2:11 AM Ben Skeggs wrote: > > > > From: Ben Skeggs > > > > The code which constructs the modules for each engine present on the GPU > > passes -1 for 'instance' on non-instanced eng

Re: [Nouveau] [PATCH 5.10 32/77] drm/ttm: fix memleak in ttm_transfered_destroy

2021-11-03 Thread Karol Herbst
On Wed, Nov 3, 2021 at 9:47 PM Sven Joachim wrote: > > On 2021-11-03 21:32 +0100, Karol Herbst wrote: > > > On Wed, Nov 3, 2021 at 9:29 PM Karol Herbst wrote: > >> > >> On Wed, Nov 3, 2021 at 8:52 PM Sven Joachim wrote: > >> > > >>

Re: [Nouveau] [PATCH 5.10 32/77] drm/ttm: fix memleak in ttm_transfered_destroy

2021-11-03 Thread Karol Herbst
On Wed, Nov 3, 2021 at 9:29 PM Karol Herbst wrote: > > On Wed, Nov 3, 2021 at 8:52 PM Sven Joachim wrote: > > > > On 2021-11-01 10:17 +0100, Greg Kroah-Hartman wrote: > > > > > From: Christian König > > > > > > commit 0db55f9a1bafbe3dac7

Re: [Nouveau] [PATCH 5.10 32/77] drm/ttm: fix memleak in ttm_transfered_destroy

2021-11-03 Thread Karol Herbst
On Wed, Nov 3, 2021 at 8:52 PM Sven Joachim wrote: > > On 2021-11-01 10:17 +0100, Greg Kroah-Hartman wrote: > > > From: Christian König > > > > commit 0db55f9a1bafbe3dac750ea669de9134922389b5 upstream. > > > > We need to cleanup the fences for ghost objects as well. > > > > Signed-off-by:

Re: [Nouveau] [PATCH] ce/gf100: fix incorrect CE0 address calculation on some GPUs

2021-11-03 Thread Karol Herbst
j), > >ptr[j]); \ > subdev = nvkm_device_subdev(device, (type), (j)); >\ > if (ret) { >\ > nvkm_subdev_del(); >\ > -- > 2.31.1 > Reviewed-by: Karol Herbst

Re: [Nouveau] hardware donation

2021-11-01 Thread Karol Herbst
On Tue, Oct 26, 2021 at 9:56 PM Linux User #330250 wrote: > > Hello! > > I have a ThinkPad T61 with an Nvidia Quadro G86M [NVS 140M] graphics > card. Recently the nvidia binary driver, version 340.x, has been removed > from most Linux distributions, forcing the use of nouveau. > > In the past,

Re: [Nouveau] Various kernel error messages on updated Arch box

2021-11-01 Thread Karol Herbst
On Mon, Nov 1, 2021 at 10:37 PM riveravaldez wrote: > > On Monday, November 1, 2021, Karol Herbst wrote: > > Actually.. seems like somebody already filed a bug like this: > > https://gitlab.freedesktop.org/drm/nouveau/-/issues/91 > > Should I add my dmesg there? >

Re: [Nouveau] Various kernel error messages on updated Arch box

2021-11-01 Thread Karol Herbst
Actually.. seems like somebody already filed a bug like this: https://gitlab.freedesktop.org/drm/nouveau/-/issues/91 Seems to be more widespread so I will check out if I hit this as well. On Mon, Nov 1, 2021 at 8:05 PM Karol Herbst wrote: > > On Mon, Nov 1, 2021 at 7:38 PM rivera

Re: [Nouveau] Various kernel error messages on updated Arch box

2021-11-01 Thread Karol Herbst
On Mon, Nov 1, 2021 at 7:38 PM riveravaldez wrote: > > Hi, I'm having this error messages at boot: > > $ sudo journalctl -ex -p3 | grep nouveau > nov 01 14:47:39 arch kernel: nouveau :01:00.0: ce: ucode exceeds falcon > limit(s) > nov 01 14:47:39 arch kernel: nouveau :01:00.0: ce: init

Re: [Nouveau] [PATCH v4 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness

2021-10-28 Thread Karol Herbst
[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) { > NV_DEBUG(drm, "DPCD backlight controls supported on > %s\n", > nv_conn->base.name); > > -- > 2.31.1 > Reviewed-by: Karol Herbst

[Nouveau] [PATCH] drm/nouveau/mmu/gp100: remove unused variable

2021-10-12 Thread Karol Herbst
Fixes a compilation issue introduced because I forgot to test with WERROR enabled. Cc: Stephen Rothwell Cc: DRI Cc: nouveau@lists.freedesktop.org Fixes: 404046cf4805 ("drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.") Signed-off-by: Karol Herbst --- drive

Re: [Nouveau] [PATCH v2 0/3] drm/nouveau: fix a use-after-free in postclose()

2021-10-11 Thread Karol Herbst
I am currently checking the ML for such old patches, just have to make sure it's actually fine and not breaking stuff as well. But I think we will pull this in soonish, I just also work on improving our CI stuff at the same time by trying out some things. On Mon, Oct 11, 2021 at 9:06 AM

Re: [Nouveau] [PATCH] drm/nouveau/fifo: Reinstate the correct engine bit programming

2021-10-07 Thread Karol Herbst
Reviewed-by: Karol Herbst I haven't checked if other places need fixing up yet, and I still want to test this patch, but I won't get to it until Monday. But if everything is in place we can get this pushed next week so we can finally fix this annoying issue :) I was also seeing some minor

Re: [Nouveau] [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness

2021-10-06 Thread Karol Herbst
On Wed, Oct 6, 2021 at 4:41 AM Lyude Paul wrote: > > Since we don't support hybrid AUX/PWM backlights in nouveau right now, > let's add some explicit checks so that we don't break nouveau once we > enable support for these backlights in other drivers. > > Signed-off-by: Lyude Paul > --- >

Re: [Nouveau] [PATCH] drm/nouveau/svm: Fix refcount leak bug and missing check against null bug

2021-10-05 Thread Karol Herbst
I think it makes sense to add a Fixes tag to this: Fixes: 822cab6150d3 ("drm/nouveau/svm: check for SVM initialized before migrating") Reviewed-by: Karol Herbst On Tue, Sep 7, 2021 at 3:20 PM Chenyuan Mi wrote: > > The reference counting issue happens in one excepti

Re: [Nouveau] [PATCH -next] drm/nouveau/gem: remove redundant semi-colon

2021-10-05 Thread Karol Herbst
Reviewed-by: Karol Herbst sorry for the late response though. On Fri, Apr 2, 2021 at 12:28 AM Yang Yingliang wrote: > > Signed-off-by: Yang Yingliang > --- > drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dr

Re: [Nouveau] Nvidia GeForce 8200M - Image flicker

2021-10-04 Thread Karol Herbst
On Mon, Oct 4, 2021 at 4:31 PM Karol Herbst wrote: > > We actually fixed a few of those issues on those old GPUs. But I don't > think they are part of any mesa release yet: > > https://gitlab.freedesktop.org/mesa/mesa/-/commit/1387d1d41103b3120d40f93f66a7cfe00304bfd7 > act

Re: [Nouveau] Nvidia GeForce 8200M - Image flicker

2021-10-04 Thread Karol Herbst
We actually fixed a few of those issues on those old GPUs. But I don't think they are part of any mesa release yet: https://gitlab.freedesktop.org/mesa/mesa/-/commit/1387d1d41103b3120d40f93f66a7cfe00304bfd7 and we have a pending MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12154

Re: [Nouveau] [PATCH][next] nouveau/svm: Use kvcalloc() instead of kvzalloc()

2021-09-28 Thread Karol Herbst
Lack of documentation inside Linux here is a bit annoying, but do I understand it correctly, that the main (and probably only) difference is that kvcalloc checks whether the multiplication overflows and returns NULL in this case? On Wed, Sep 29, 2021 at 12:21 AM Gustavo A. R. Silva wrote: > >

Re: [Nouveau] [PATCH 2/2] drm/nouveau/debugfs: fix file release memory leak

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang wrote: > > When using single_open() for opening, single_release() should be > called, otherwise the 'op' allocated in single_open() will be leaked. > > Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add

Re: [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang wrote: > > When using single_open() for opening, single_release() should be > called, otherwise the 'op' allocated in single_open() will be leaked. > > Fixes: 12885ecbfe62 ("drm/nouveau/kms/nv

Re: [Nouveau] [PATCH linux-next] drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst but I will remove the unnecessary brackets as well On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote: > > From: Luo penghao > > In order to keep the code style consistency of the whole file, > the 'inst' assignments should be deleted. > > The cla

Re: [Nouveau] [PATCH linux-next] drm/nouveau/mmu: drop unneeded assignment in the nvkm_uvmm_mthd_page()

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote: > > From: Luo penghao > > In order to keep the code style consistency of the whole file, > the 'ret' assignments should be deleted. > > The clang_analyzer complains as follows: > > drivers/gpu/

Re: [Nouveau] [PATCH] drm/nouveau: avoid a use-after-free when BO init fails

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst and queued On Fri, Mar 26, 2021 at 10:41 PM Lyude Paul wrote: > > Reviewed-by: Lyude Paul > > On Wed, 2020-12-02 at 19:02 -0500, Jeremy Cline wrote: > > nouveau_bo_init() is backed by ttm_bo_init() and ferries its return code > > back to

Re: [Nouveau] [PATCH linux-next] drm/nouveau/nvenc: remove duplicate include in base.c

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst and picked On Mon, Aug 9, 2021 at 12:14 AM wrote: > > From: yong yiran > > 'priv.h' included in 'base.c' is duplicated. > Remove all but the first include of priv.h from base.c. > > Reported-by: Zeal Robot > Signed-off-by: yong yiran

Re: [Nouveau] nvprime

2021-09-23 Thread Karol Herbst
If you have an issue with the Nvidia driver, ask Nvidia for help. And don't CC random Mailing lists and spam them. On Thu, Sep 23, 2021 at 4:32 PM __- -__ wrote: > > Hi, > > I launch nvidia-settings; and > I launch __NV_PRIME_RENDER_OFFLOAD=1 nvidia-settings > > neither >

Re: [Nouveau] external monitor does not work

2021-09-23 Thread Karol Herbst
sorry for the late answer. I think booting with "nouveau.runpm=0" will solve this problem, but then it causes the GPU to be always powered on. I suspect that the kernel doesn't detect hotplug events later on and I am sure this is solved with newer kernel versions. We solved issues like this in the

Re: [Nouveau] [PATCH] drm/nouveau/ga102: Free resources on error in ga102_chan_new()

2021-09-21 Thread Karol Herbst
On Tue, Sep 21, 2021 at 3:22 PM Tim Gardner wrote: > > > > On 9/20/21 8:07 PM, Karol Herbst wrote: > > On Mon, Sep 20, 2021 at 8:17 PM Tim Gardner > > wrote: > >> > >> Coverity complains of a resource leak in ga102_chan_new(): > >> >

Re: [Nouveau] [PATCH] drm/nouveau/ga102: Free resources on error in ga102_chan_new()

2021-09-20 Thread Karol Herbst
ogramming style isn't the best and we should be explicit about freeing memory though. > Cc: Ben Skeggs > Cc: David Airlie > Cc: Daniel Vetter > Cc: Karol Herbst > Cc: dri-de...@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: linux-ker...@vger.kernel.org

Re: [Nouveau] [PATCH] drm/nouveau: don't detect DSM for non-NVIDIA device

2021-09-13 Thread Karol Herbst
Sorry for taking this long to take a look, it's just that I don't want this to get merged without testing, and I'd like to test it on the different kinds of hybrid GPU setups we have so that nothing unexpected happens here. I am not 100% sure how all of that works before optimus, so I have to

Re: [Nouveau] RTX 3070 / NV174 / GA104 - is there any development happening?

2021-09-01 Thread Karol Herbst
On Wed, Sep 1, 2021 at 11:19 PM Przemo Firszt wrote: > > Hi, > > Can you advise if there is any work happening on NV174 / GA104 (market > name RTX 3070)? I checked the features matrix and searched the code of > kernel, mesa, libdrm and xf86-video-nouveau. The only thig that seems > to be ready is

Re: [Nouveau] nouveau resume regression after 64f7c698bea9 ("drm/nouveau/fifo: add engine_id hook")

2021-08-18 Thread Karol Herbst
On Wed, Aug 18, 2021 at 8:52 PM Jarkko Nikula wrote: > > Hi > > My old Thinkpad T410i won't resume properly anymore after suspend or > hibernation after v5.12 including today's head 614cb2751d31 ("Merge tag > 'trace-v5.14-rc6' of >

Re: [Nouveau] Donate NVC0 GF 100 GL [Quadro 4000]

2021-08-18 Thread Karol Herbst
Hey, thanks for the offer. In which country are you located? On Fri, Aug 13, 2021 at 4:44 PM Roger Price wrote: > > I have an NVC0 GF 100 GL [Quadro 4000] I would be happy to donate if anyone is > interested. I'm in France. I'll pay the postage. > > Nouveau as included in Debian 11 freezes

Re: [Nouveau] Proposal for allowing more Nouveau contributors to merge patches

2021-08-10 Thread Karol Herbst
On Tue, Aug 10, 2021 at 12:11 PM Daniel Vetter wrote: > > On Fri, Aug 06, 2021 at 06:53:06PM +0200, Karol Herbst wrote: > > Hey everybody, > > > > so, here is a proposal of what we could change in order to allow > > patches to land faster, more reliably and to incre

[Nouveau] Proposal for allowing more Nouveau contributors to merge patches

2021-08-06 Thread Karol Herbst
Hey everybody, so, here is a proposal of what we could change in order to allow patches to land faster, more reliably and to increase the overall bus factor in terms of nouveau kernel maintenance. But let's start with the current situation: At the moment contributors have to send patches to the

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 20

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > playing around a little bit with this, I think the original "select >

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > playing around a little bit with this, I think the original "select > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix o

[Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
playing around a little bit with this, I think the original "select BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of drivers selecting and others depending on it. We could of course convert everything over to depend, and break those cycling dependency issues with this.

Re: [Nouveau] [PATCH 06/38] x86/mmiotrace: Replace deprecated CPU-hotplug functions.

2021-08-03 Thread Karol Herbst
-hotplug functions with the official version. > The behavior remains unchanged. > > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Borislav Petkov

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-27 Thread Karol Herbst
On Thu, Jul 22, 2021 at 5:10 AM Ratchanan Srirattanamet wrote: > > The call site of nouveau_dsm_pci_probe() uses single set of output > variables for all invocations. So, we must not write anything to them > until we think this is an NVIDIA device of interest. Otherwise, if we > are called with

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 4:05 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 2:52 PM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > In the past this only led to compilation issues. Also the small amount of > > extra .text shouldn't really matter compared to the entire n

[Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-23 Thread Karol Herbst
...@lists.freedesktop.org Fixes: 6eca310e8924 ("drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau") Signed-off-by: Karol Herbst --- drivers/gpu/drm/nouveau/Kbuild | 2 +- drivers/gpu/drm/nouveau/Kconfig | 13 ++- drivers/gpu/drm/nouveau/dispn

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 8:40 PM Arnd Bergmann wrote: > > On Fri, Jul 23, 2021 at 6:34 PM Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > > > On Fri, Jul 23, 2021 at 5:1

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: > >> > >> On 7/23/21 2:15 AM, Arnd Bergmann wrote: > >>> From: Arnd Bergmann > >>> &g

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: > > On 7/23/21 2:15 AM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When the backlight support is disabled, the driver fails to build: > > > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function > > 'nv50_sor_atomic_disable': > >

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 12:10 PM Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 11:24 AM Daniel Vetter wrote: > > > > On Fri, Jul 23, 2021 at 11:15 AM Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > When the ba

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 11:24 AM Daniel Vetter wrote: > > On Fri, Jul 23, 2021 at 11:15 AM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > When the backlight support is disabled, the driver fails to build: > > > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function > >

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
On Thu, Jul 22, 2021 at 9:54 PM Karol Herbst wrote: > > On Thu, Jul 22, 2021 at 9:49 PM Ratchanan Srirattanamet > wrote: > > > > Hello, > > > > เมื่อ 22/7/64 เวลา 23:36 Karol Herbst เขียนว่า: > > > hey, thanks for the patch. But I am a bit confu

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
On Thu, Jul 22, 2021 at 9:49 PM Ratchanan Srirattanamet wrote: > > Hello, > > เมื่อ 22/7/64 เวลา 23:36 Karol Herbst เขียนว่า: > > hey, thanks for the patch. But I am a bit confused on why that patch > > actually helps. It should only be called for nvidia GPUs, but are w

Re: [Nouveau] nouveau broken again on Riva TNT2 in 5.14.0-rc2

2021-07-22 Thread Karol Herbst
hey thanks for the report. This is a known issue and the fix is pending in drm-mist-fixes and should land in 5.14 soonish. On Thu, Jul 22, 2021 at 9:29 PM Ondrej Zary wrote: > > Hello, > nouveau is broken again: > > [ 58.795794] BUG: kernel NULL pointer dereference, address: 017c > [

  1   2   3   4   5   6   7   8   9   10   >