Re: [Nouveau] [INVALID_ARG] mthd 0414

2021-11-19 Thread Karol Herbst
On Fri, Nov 19, 2021 at 2:00 PM dmanye wrote: > > On 19/11/21 13:31, Karol Herbst wrote: > > yeah.. not quite sure yet. I tried it out with my gk208b gpus, but > > couldn't hit anything. Maybe using VGA makes the difference here. Or > > something else is different. Mig

Re: [Nouveau] [INVALID_ARG] mthd 0414

2021-11-19 Thread Karol Herbst
On Fri, Nov 19, 2021 at 9:10 AM dmanye wrote: > > On 18/11/21 16:13, Karol Herbst wrote: > > On Thu, Nov 18, 2021 at 2:59 PM dmanye wrote: > >> hello, > >> > >> i have a problem and i think that it is in the nouveau driver. i hope > >> you can he

Re: [Nouveau] [INVALID_ARG] mthd 0414

2021-11-18 Thread Karol Herbst
On Thu, Nov 18, 2021 at 2:59 PM dmanye wrote: > > hello, > > i have a problem and i think that it is in the nouveau driver. i hope > you can help me... > > i have 20 identical computers with debian bullseye (11) installed (only > "official" debian packages). sometimes some of them boot but the

Re: [Nouveau] [PATCH] drm/nouveau: recognise GA106

2021-11-18 Thread Karol Herbst
Cc: stable? On Thu, Nov 18, 2021 at 4:04 AM Ben Skeggs wrote: > > From: Ben Skeggs > > I've got HW now, appears to work as expected so far. > > Signed-off-by: Ben Skeggs > --- > .../gpu/drm/nouveau/nvkm/engine/device/base.c | 22 +++ > 1 file changed, 22 insertions(+) > > diff

Re: [Nouveau] [PATCH] drm/nouveau/core: fix the uninitialized use in nvkm_ioctl_map()

2021-11-16 Thread Karol Herbst
were also a bit broken. I just suspect that when sending it something went wrong or so. > On Sat, Nov 13, 2021 at 12:22 PM Karol Herbst wrote: > > > > something seems to have messed with the patch so it doesn't apply correctly. > > > > On Thu, Jun 17, 2021 at 9:39 AM Y

Re: [Nouveau] [PATCH] drm/nouveau/core: fix the uninitialized use in nvkm_ioctl_map()

2021-11-13 Thread Karol Herbst
something seems to have messed with the patch so it doesn't apply correctly. On Thu, Jun 17, 2021 at 9:39 AM Yizhuo Zhai wrote: > > In function nvkm_ioctl_map(), the variable "type" could be > uninitialized if "nvkm_object_map()" returns error code, > however, it does not check the return value

[Nouveau] [PATCH] MAINTAINERS: update information for nouveau

2021-11-10 Thread Karol Herbst
-by: Karol Herbst --- MAINTAINERS | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8805df335326..270dc9c0a427 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5961,10 +5961,17 @@ F: drivers/gpu/drm/panel/panel-novatek-nt36672a.c DRM DRIVER

Re: [Nouveau] [PATCH] ce/gf100: fix incorrect CE0 address calculation on some GPUs

2021-11-03 Thread Karol Herbst
On Wed, Nov 3, 2021 at 8:51 AM Karol Herbst wrote: > > On Wed, Nov 3, 2021 at 2:11 AM Ben Skeggs wrote: > > > > From: Ben Skeggs > > > > The code which constructs the modules for each engine present on the GPU > > passes -1 for 'instance' on non-instanced eng

Re: [Nouveau] [PATCH 5.10 32/77] drm/ttm: fix memleak in ttm_transfered_destroy

2021-11-03 Thread Karol Herbst
On Wed, Nov 3, 2021 at 9:47 PM Sven Joachim wrote: > > On 2021-11-03 21:32 +0100, Karol Herbst wrote: > > > On Wed, Nov 3, 2021 at 9:29 PM Karol Herbst wrote: > >> > >> On Wed, Nov 3, 2021 at 8:52 PM Sven Joachim wrote: > >> > > >>

Re: [Nouveau] [PATCH 5.10 32/77] drm/ttm: fix memleak in ttm_transfered_destroy

2021-11-03 Thread Karol Herbst
On Wed, Nov 3, 2021 at 9:29 PM Karol Herbst wrote: > > On Wed, Nov 3, 2021 at 8:52 PM Sven Joachim wrote: > > > > On 2021-11-01 10:17 +0100, Greg Kroah-Hartman wrote: > > > > > From: Christian König > > > > > > commit 0db55f9a1bafbe3dac7

Re: [Nouveau] [PATCH 5.10 32/77] drm/ttm: fix memleak in ttm_transfered_destroy

2021-11-03 Thread Karol Herbst
On Wed, Nov 3, 2021 at 8:52 PM Sven Joachim wrote: > > On 2021-11-01 10:17 +0100, Greg Kroah-Hartman wrote: > > > From: Christian König > > > > commit 0db55f9a1bafbe3dac750ea669de9134922389b5 upstream. > > > > We need to cleanup the fences for ghost objects as well. > > > > Signed-off-by:

Re: [Nouveau] [PATCH] ce/gf100: fix incorrect CE0 address calculation on some GPUs

2021-11-03 Thread Karol Herbst
j), > >ptr[j]); \ > subdev = nvkm_device_subdev(device, (type), (j)); >\ > if (ret) { >\ > nvkm_subdev_del(); >\ > -- > 2.31.1 > Reviewed-by: Karol Herbst

Re: [Nouveau] hardware donation

2021-11-01 Thread Karol Herbst
On Tue, Oct 26, 2021 at 9:56 PM Linux User #330250 wrote: > > Hello! > > I have a ThinkPad T61 with an Nvidia Quadro G86M [NVS 140M] graphics > card. Recently the nvidia binary driver, version 340.x, has been removed > from most Linux distributions, forcing the use of nouveau. > > In the past,

Re: [Nouveau] Various kernel error messages on updated Arch box

2021-11-01 Thread Karol Herbst
On Mon, Nov 1, 2021 at 10:37 PM riveravaldez wrote: > > On Monday, November 1, 2021, Karol Herbst wrote: > > Actually.. seems like somebody already filed a bug like this: > > https://gitlab.freedesktop.org/drm/nouveau/-/issues/91 > > Should I add my dmesg there? >

Re: [Nouveau] Various kernel error messages on updated Arch box

2021-11-01 Thread Karol Herbst
Actually.. seems like somebody already filed a bug like this: https://gitlab.freedesktop.org/drm/nouveau/-/issues/91 Seems to be more widespread so I will check out if I hit this as well. On Mon, Nov 1, 2021 at 8:05 PM Karol Herbst wrote: > > On Mon, Nov 1, 2021 at 7:38 PM rivera

Re: [Nouveau] Various kernel error messages on updated Arch box

2021-11-01 Thread Karol Herbst
On Mon, Nov 1, 2021 at 7:38 PM riveravaldez wrote: > > Hi, I'm having this error messages at boot: > > $ sudo journalctl -ex -p3 | grep nouveau > nov 01 14:47:39 arch kernel: nouveau :01:00.0: ce: ucode exceeds falcon > limit(s) > nov 01 14:47:39 arch kernel: nouveau :01:00.0: ce: init

Re: [Nouveau] [PATCH v4 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness

2021-10-28 Thread Karol Herbst
[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) { > NV_DEBUG(drm, "DPCD backlight controls supported on > %s\n", > nv_conn->base.name); > > -- > 2.31.1 > Reviewed-by: Karol Herbst

[Nouveau] [PATCH] drm/nouveau/mmu/gp100: remove unused variable

2021-10-12 Thread Karol Herbst
Fixes a compilation issue introduced because I forgot to test with WERROR enabled. Cc: Stephen Rothwell Cc: DRI Cc: nouveau@lists.freedesktop.org Fixes: 404046cf4805 ("drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.") Signed-off-by: Karol Herbst --- drive

Re: [Nouveau] [PATCH v2 0/3] drm/nouveau: fix a use-after-free in postclose()

2021-10-11 Thread Karol Herbst
I am currently checking the ML for such old patches, just have to make sure it's actually fine and not breaking stuff as well. But I think we will pull this in soonish, I just also work on improving our CI stuff at the same time by trying out some things. On Mon, Oct 11, 2021 at 9:06 AM

Re: [Nouveau] [PATCH] drm/nouveau/fifo: Reinstate the correct engine bit programming

2021-10-07 Thread Karol Herbst
Reviewed-by: Karol Herbst I haven't checked if other places need fixing up yet, and I still want to test this patch, but I won't get to it until Monday. But if everything is in place we can get this pushed next week so we can finally fix this annoying issue :) I was also seeing some minor

Re: [Nouveau] [PATCH v3 2/5] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness

2021-10-06 Thread Karol Herbst
On Wed, Oct 6, 2021 at 4:41 AM Lyude Paul wrote: > > Since we don't support hybrid AUX/PWM backlights in nouveau right now, > let's add some explicit checks so that we don't break nouveau once we > enable support for these backlights in other drivers. > > Signed-off-by: Lyude Paul > --- >

Re: [Nouveau] [PATCH] drm/nouveau/svm: Fix refcount leak bug and missing check against null bug

2021-10-05 Thread Karol Herbst
I think it makes sense to add a Fixes tag to this: Fixes: 822cab6150d3 ("drm/nouveau/svm: check for SVM initialized before migrating") Reviewed-by: Karol Herbst On Tue, Sep 7, 2021 at 3:20 PM Chenyuan Mi wrote: > > The reference counting issue happens in one excepti

Re: [Nouveau] [PATCH -next] drm/nouveau/gem: remove redundant semi-colon

2021-10-05 Thread Karol Herbst
Reviewed-by: Karol Herbst sorry for the late response though. On Fri, Apr 2, 2021 at 12:28 AM Yang Yingliang wrote: > > Signed-off-by: Yang Yingliang > --- > drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dr

Re: [Nouveau] Nvidia GeForce 8200M - Image flicker

2021-10-04 Thread Karol Herbst
On Mon, Oct 4, 2021 at 4:31 PM Karol Herbst wrote: > > We actually fixed a few of those issues on those old GPUs. But I don't > think they are part of any mesa release yet: > > https://gitlab.freedesktop.org/mesa/mesa/-/commit/1387d1d41103b3120d40f93f66a7cfe00304bfd7 > act

Re: [Nouveau] Nvidia GeForce 8200M - Image flicker

2021-10-04 Thread Karol Herbst
We actually fixed a few of those issues on those old GPUs. But I don't think they are part of any mesa release yet: https://gitlab.freedesktop.org/mesa/mesa/-/commit/1387d1d41103b3120d40f93f66a7cfe00304bfd7 and we have a pending MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12154

Re: [Nouveau] [PATCH][next] nouveau/svm: Use kvcalloc() instead of kvzalloc()

2021-09-28 Thread Karol Herbst
Lack of documentation inside Linux here is a bit annoying, but do I understand it correctly, that the main (and probably only) difference is that kvcalloc checks whether the multiplication overflows and returns NULL in this case? On Wed, Sep 29, 2021 at 12:21 AM Gustavo A. R. Silva wrote: > >

Re: [Nouveau] [PATCH 2/2] drm/nouveau/debugfs: fix file release memory leak

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang wrote: > > When using single_open() for opening, single_release() should be > called, otherwise the 'op' allocated in single_open() will be leaked. > > Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add

Re: [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang wrote: > > When using single_open() for opening, single_release() should be > called, otherwise the 'op' allocated in single_open() will be leaked. > > Fixes: 12885ecbfe62 ("drm/nouveau/kms/nv

Re: [Nouveau] [PATCH linux-next] drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst but I will remove the unnecessary brackets as well On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote: > > From: Luo penghao > > In order to keep the code style consistency of the whole file, > the 'inst' assignments should be deleted. > > The cla

Re: [Nouveau] [PATCH linux-next] drm/nouveau/mmu: drop unneeded assignment in the nvkm_uvmm_mthd_page()

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote: > > From: Luo penghao > > In order to keep the code style consistency of the whole file, > the 'ret' assignments should be deleted. > > The clang_analyzer complains as follows: > > drivers/gpu/

Re: [Nouveau] [PATCH] drm/nouveau: avoid a use-after-free when BO init fails

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst and queued On Fri, Mar 26, 2021 at 10:41 PM Lyude Paul wrote: > > Reviewed-by: Lyude Paul > > On Wed, 2020-12-02 at 19:02 -0500, Jeremy Cline wrote: > > nouveau_bo_init() is backed by ttm_bo_init() and ferries its return code > > back to

Re: [Nouveau] [PATCH linux-next] drm/nouveau/nvenc: remove duplicate include in base.c

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst and picked On Mon, Aug 9, 2021 at 12:14 AM wrote: > > From: yong yiran > > 'priv.h' included in 'base.c' is duplicated. > Remove all but the first include of priv.h from base.c. > > Reported-by: Zeal Robot > Signed-off-by: yong yiran

Re: [Nouveau] nvprime

2021-09-23 Thread Karol Herbst
If you have an issue with the Nvidia driver, ask Nvidia for help. And don't CC random Mailing lists and spam them. On Thu, Sep 23, 2021 at 4:32 PM __- -__ wrote: > > Hi, > > I launch nvidia-settings; and > I launch __NV_PRIME_RENDER_OFFLOAD=1 nvidia-settings > > neither >

Re: [Nouveau] external monitor does not work

2021-09-23 Thread Karol Herbst
sorry for the late answer. I think booting with "nouveau.runpm=0" will solve this problem, but then it causes the GPU to be always powered on. I suspect that the kernel doesn't detect hotplug events later on and I am sure this is solved with newer kernel versions. We solved issues like this in the

Re: [Nouveau] [PATCH] drm/nouveau/ga102: Free resources on error in ga102_chan_new()

2021-09-21 Thread Karol Herbst
On Tue, Sep 21, 2021 at 3:22 PM Tim Gardner wrote: > > > > On 9/20/21 8:07 PM, Karol Herbst wrote: > > On Mon, Sep 20, 2021 at 8:17 PM Tim Gardner > > wrote: > >> > >> Coverity complains of a resource leak in ga102_chan_new(): > >> >

Re: [Nouveau] [PATCH] drm/nouveau/ga102: Free resources on error in ga102_chan_new()

2021-09-20 Thread Karol Herbst
ogramming style isn't the best and we should be explicit about freeing memory though. > Cc: Ben Skeggs > Cc: David Airlie > Cc: Daniel Vetter > Cc: Karol Herbst > Cc: dri-de...@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: linux-ker...@vger.kernel.org

Re: [Nouveau] [PATCH] drm/nouveau: don't detect DSM for non-NVIDIA device

2021-09-13 Thread Karol Herbst
Sorry for taking this long to take a look, it's just that I don't want this to get merged without testing, and I'd like to test it on the different kinds of hybrid GPU setups we have so that nothing unexpected happens here. I am not 100% sure how all of that works before optimus, so I have to

Re: [Nouveau] RTX 3070 / NV174 / GA104 - is there any development happening?

2021-09-01 Thread Karol Herbst
On Wed, Sep 1, 2021 at 11:19 PM Przemo Firszt wrote: > > Hi, > > Can you advise if there is any work happening on NV174 / GA104 (market > name RTX 3070)? I checked the features matrix and searched the code of > kernel, mesa, libdrm and xf86-video-nouveau. The only thig that seems > to be ready is

Re: [Nouveau] nouveau resume regression after 64f7c698bea9 ("drm/nouveau/fifo: add engine_id hook")

2021-08-18 Thread Karol Herbst
On Wed, Aug 18, 2021 at 8:52 PM Jarkko Nikula wrote: > > Hi > > My old Thinkpad T410i won't resume properly anymore after suspend or > hibernation after v5.12 including today's head 614cb2751d31 ("Merge tag > 'trace-v5.14-rc6' of >

Re: [Nouveau] Donate NVC0 GF 100 GL [Quadro 4000]

2021-08-18 Thread Karol Herbst
Hey, thanks for the offer. In which country are you located? On Fri, Aug 13, 2021 at 4:44 PM Roger Price wrote: > > I have an NVC0 GF 100 GL [Quadro 4000] I would be happy to donate if anyone is > interested. I'm in France. I'll pay the postage. > > Nouveau as included in Debian 11 freezes

Re: [Nouveau] Proposal for allowing more Nouveau contributors to merge patches

2021-08-10 Thread Karol Herbst
On Tue, Aug 10, 2021 at 12:11 PM Daniel Vetter wrote: > > On Fri, Aug 06, 2021 at 06:53:06PM +0200, Karol Herbst wrote: > > Hey everybody, > > > > so, here is a proposal of what we could change in order to allow > > patches to land faster, more reliably and to incre

[Nouveau] Proposal for allowing more Nouveau contributors to merge patches

2021-08-06 Thread Karol Herbst
Hey everybody, so, here is a proposal of what we could change in order to allow patches to land faster, more reliably and to increase the overall bus factor in terms of nouveau kernel maintenance. But let's start with the current situation: At the moment contributors have to send patches to the

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 20

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > playing around a little bit with this, I think the original "select >

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > playing around a little bit with this, I think the original "select > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix o

[Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-04 Thread Karol Herbst
playing around a little bit with this, I think the original "select BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of drivers selecting and others depending on it. We could of course convert everything over to depend, and break those cycling dependency issues with this.

Re: [Nouveau] [PATCH 06/38] x86/mmiotrace: Replace deprecated CPU-hotplug functions.

2021-08-03 Thread Karol Herbst
-hotplug functions with the official version. > The behavior remains unchanged. > > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Borislav Petkov

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-27 Thread Karol Herbst
On Thu, Jul 22, 2021 at 5:10 AM Ratchanan Srirattanamet wrote: > > The call site of nouveau_dsm_pci_probe() uses single set of output > variables for all invocations. So, we must not write anything to them > until we think this is an NVIDIA device of interest. Otherwise, if we > are called with

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 4:05 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 2:52 PM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > In the past this only led to compilation issues. Also the small amount of > > extra .text shouldn't really matter compared to the entire n

[Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-23 Thread Karol Herbst
...@lists.freedesktop.org Fixes: 6eca310e8924 ("drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau") Signed-off-by: Karol Herbst --- drivers/gpu/drm/nouveau/Kbuild | 2 +- drivers/gpu/drm/nouveau/Kconfig | 13 ++- drivers/gpu/drm/nouveau/dispn

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 8:40 PM Arnd Bergmann wrote: > > On Fri, Jul 23, 2021 at 6:34 PM Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > > > On Fri, Jul 23, 2021 at 5:1

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: > >> > >> On 7/23/21 2:15 AM, Arnd Bergmann wrote: > >>> From: Arnd Bergmann > >>> &g

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: > > On 7/23/21 2:15 AM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When the backlight support is disabled, the driver fails to build: > > > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function > > 'nv50_sor_atomic_disable': > >

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 12:10 PM Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 11:24 AM Daniel Vetter wrote: > > > > On Fri, Jul 23, 2021 at 11:15 AM Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > When the ba

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Karol Herbst
On Fri, Jul 23, 2021 at 11:24 AM Daniel Vetter wrote: > > On Fri, Jul 23, 2021 at 11:15 AM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > When the backlight support is disabled, the driver fails to build: > > > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function > >

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
On Thu, Jul 22, 2021 at 9:54 PM Karol Herbst wrote: > > On Thu, Jul 22, 2021 at 9:49 PM Ratchanan Srirattanamet > wrote: > > > > Hello, > > > > เมื่อ 22/7/64 เวลา 23:36 Karol Herbst เขียนว่า: > > > hey, thanks for the patch. But I am a bit confu

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
On Thu, Jul 22, 2021 at 9:49 PM Ratchanan Srirattanamet wrote: > > Hello, > > เมื่อ 22/7/64 เวลา 23:36 Karol Herbst เขียนว่า: > > hey, thanks for the patch. But I am a bit confused on why that patch > > actually helps. It should only be called for nvidia GPUs, but are w

Re: [Nouveau] nouveau broken again on Riva TNT2 in 5.14.0-rc2

2021-07-22 Thread Karol Herbst
hey thanks for the report. This is a known issue and the fix is pending in drm-mist-fixes and should land in 5.14 soonish. On Thu, Jul 22, 2021 at 9:29 PM Ondrej Zary wrote: > > Hello, > nouveau is broken again: > > [ 58.795794] BUG: kernel NULL pointer dereference, address: 017c > [

Re: [Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-22 Thread Karol Herbst
hey, thanks for the patch. But I am a bit confused on why that patch actually helps. It should only be called for nvidia GPUs, but are we ending up checking it for AMD GPUs as well? Mind posting the output of lspci -tvnn? On Thu, Jul 22, 2021 at 5:10 AM Ratchanan Srirattanamet wrote: > > The

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

2021-07-21 Thread Karol Herbst
actually.. it was already found in this thread: https://lore.kernel.org/lkml/YOC4uekpD7iA3xPi@Red/T/ fixes incoming. On Wed, Jul 21, 2021 at 3:13 PM Karol Herbst wrote: > > fyi: I am able to reproduce it on my machine and will figure out > what's wrong. Thanks! > > On Mon, Jul 19

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

2021-07-21 Thread Karol Herbst
fyi: I am able to reproduce it on my machine and will figure out what's wrong. Thanks! On Mon, Jul 19, 2021 at 10:53 PM Sid Boyce wrote: > > Also sent this to kernel mailing list. > > I saw an earlier kernel mailing list post (week 8 - 15 July) that so far > hasn't made it into 5.14-rc. > > >

Re: [Nouveau] [PATCH] include/uapi/drm: fix spelling mistakes in header files

2021-07-12 Thread Karol Herbst
> As long as it doesn't touch code I don't see why not. Just in case: Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH] remove unused varialble "struct device *dev"

2021-06-23 Thread Karol Herbst
On Tue, Jun 22, 2021 at 5:14 PM Cai Huoqing wrote: > > fix the warning- variable 'dev' set but not used > the patch title needs a prefix to indicate which subsystem it belongs to. Check git log for examples. With that fixed: Reviewed-by: Karol Herbst > Signed-off-by:

Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang

2021-06-01 Thread Karol Herbst
all three nouveau patches are Reviewed-by: Karol Herbst and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva wrote: > &

Re: [Nouveau] [PATCH 11/34] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static

2021-05-26 Thread Karol Herbst
t; spin_unlock_irqrestore(>lock, flags); > } > > -void > +static void > tu102_mc_intr_mask(struct nvkm_mc *base, u32 mask, u32 intr) > { > struct tu102_mc *mc = tu102_mc(base); > -- > 2.31.1 > > _______ > Nouveau mailin

Re: [Nouveau] [PATCH] nouveau/gem: fix user-after-free in nouveau_gem_new

2021-05-17 Thread Karol Herbst
On Mon, May 17, 2021 at 11:17 AM Thierry Reding wrote: > > On Mon, May 17, 2021 at 10:56:29AM +0200, Thierry Reding wrote: > > On Tue, May 11, 2021 at 06:35:53PM +0200, Karol Herbst wrote: > > > If ttm_bo_init fails it will already call ttm_bo_put, so we don't have t

Re: [Nouveau] [PATCH] nouveau/gem: fix user-after-free in nouveau_gem_new

2021-05-13 Thread Karol Herbst
On Thu, May 13, 2021 at 5:25 PM Jeremy Cline wrote: > > On Tue, May 11, 2021 at 06:35:53PM +0200, Karol Herbst wrote: > > If ttm_bo_init fails it will already call ttm_bo_put, so we don't have to > > do it thro

[Nouveau] [PATCH] nouveau/gem: fix user-after-free in nouveau_gem_new

2021-05-11 Thread Karol Herbst
uveau: Initialize GEM object before TTM object" Cc: Thierry Reding Signed-off-by: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index c88cbb85f101..11

Re: [Nouveau] Bug system problems

2021-04-22 Thread Karol Herbst
I've notified the gitlab admins, but maybe you can use the social login (google, github, twitter, etc..) for the moment or would that require the confirmation email as well? On Thu, Apr 22, 2021 at 3:44 PM o1bigtenor wrote: > > Greetings > > In the process of setting up an account at the

Re: [Nouveau] [bug report] drm/nouveau/hwmon: Remove old code, add .write/.read operations

2021-04-21 Thread Karol Herbst
On Wed, Apr 21, 2021 at 3:57 PM Dan Carpenter wrote: > > Hello Oscar Salvador, > > The patch bfb96e4c344e: "drm/nouveau/hwmon: Remove old code, add > .write/.read operations" from May 18, 2017, leads to the following > static checker warning: > > drivers/gpu/drm/nouveau/nouveau_hwmon.c:507

Re: [Nouveau] [PATCH 13/40] drm/nouveau/dispnv50/disp: Include header containing our prototypes

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/disp.c:2599:1: warning: no previous > prototype for ‘nv50_display_create’ [-Wmissing-prototypes] > > Cc: Be

Re: [Nouveau] [PATCH 14/40] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * > file mga_ioc32.c > > Cc: Ben Skeggs > Cc: David Airlie &

Re: [Nouveau] [PATCH 16/40] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or > member 'filp' not described in 'nouveau_compat_ioctl' > drive

Re: [Nouveau] [PATCH 15/40] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function

2021-04-19 Thread Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_svm.c: In function ‘nouveau_pfns_map’: > drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ‘ret’ set but > not used [-Wunused-but-set-variable]

Re: [Nouveau] [PATCH 12/40] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following build error: > > drivers/gpu/drm/nouveau/dispnv50/disp.c:2530:1: error: conflicting types for > ‘nv50_display_fini’ > In file included from drivers/gpu/drm/nouveau/

Re: [Nouveau] [PATCH 11/40] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous > prototype for ‘headc57d_olut’ [-Wmissing-prototypes] > > Cc: Be

Re: [Nouveau] [PATCH 10/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void

2021-04-19 Thread Karol Herbst
On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_cleanup’: > drivers/gpu/drm/nouveau/dispnv50/disp.c:1357:6: warning: variable ‘ret’ set > but not used

Re: [Nouveau] [PATCH 09/40] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or > member 'crtc' not described in 'nv_crtc_mode_set_regs' > drive

Re: [Nouveau] [PATCH 07/40] drm/nouveau/nouveau_bo: Remove unused variables 'dev'

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’: > drivers/gpu/drm/nouveau/nouveau_bo.c:1228:17: warning: var

Re: [Nouveau] [PATCH 05/40] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function > parameter or member 'speedo' not described in 'gk20a_volt_get_cvb_volt

Re: [Nouveau] [PATCH 06/40] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:992: warning: Function > parameter or member 'gr' not described in 'gf100_gr_wait_idle' > >

Re: [Nouveau] [PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret'

2021-04-19 Thread Karol Herbst
On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/disp.c:1381:6: warning: variable ‘ret’ set > but not used [-Wunused-but-set-variable] > not a big fan of just ignoring return codes, I'd rather see it

Re: [Nouveau] [PATCH 01/40] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

2021-04-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function > parameter or member 'init' not described in 'init_reserved' > drive

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Karol Herbst
On Tue, Apr 13, 2021 at 1:17 PM Roy Spliet wrote: > > Op 13-04-2021 om 10:48 schreef Karol Herbst: > > On Tue, Apr 13, 2021 at 10:24 AM Roy Spliet wrote: > >> > >> Op 13-04-2021 om 01:10 schreef Karol Herbst: > >>> On Mon, Apr 12, 2021 at 9:36 PM Ro

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Karol Herbst
On Tue, Apr 13, 2021 at 10:24 AM Roy Spliet wrote: > > Op 13-04-2021 om 01:10 schreef Karol Herbst: > > On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: > >> > >> Hello Aaron, > >> > >> Thanks for your insights. A follow-up query and some observ

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Karol Herbst
On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: > > Hello Aaron, > > Thanks for your insights. A follow-up query and some observations in-line. > > Op 12-04-2021 om 20:06 schreef Aaron Plattner: > > On 4/10/21 1:48 PM, Roy Spliet wrote: > >> Op 10-04-2021 om 20:23 schreef Lukas Wunner: > >>> On

Re: [Nouveau] SLI support for nv44

2021-03-30 Thread Karol Herbst
On Tue, Mar 30, 2021 at 8:28 AM wrote: > > Hi, > I am currently the happy owner of a nforce 4 - SLI with two 7100gs graphics > cards setup. > Since I've read on your features matrix that such a setup is rather uncommon > among developers, I would like to help you implementing SLI for old

Re: [Nouveau] [PATCH 14/19] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-03-19 Thread Karol Herbst
ize != 1024) > -- > 2.27.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 17/19] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-03-19 Thread Karol Herbst
; * > * 32-bit ioctl compatibility routines for the MGA DRM. > -- > 2.27.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > Reviewed-by: Karol Herbst

Re: [Nouveau] [PATCH 12/19] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers

2021-03-19 Thread Karol Herbst
* The clocks, CRTCs and outputs attached to this CRTC must be off. > -- > 2.27.0 > > _______ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 19/19] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-03-19 Thread Karol Herbst
* Called whenever a 32-bit process running under a 64-bit kernel > * performs an ioctl on /dev/dri/card. > * > -- > 2.27.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/m

Re: [Nouveau] [PATCH 10/19] drm/nouveau/nouveau_bo: Remove unused variables 'dev'

2021-03-19 Thread Karol Herbst
> > if (slave) > return; > > drm = nouveau_bdev(bdev); > - dev = drm->dev->dev; > > return ttm_pool_free(>ttm.bdev.pool, ttm); > } > -- > 2.27.0 > > ___ > dri-de

Re: [Nouveau] [PATCH 15/19] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions

2021-03-19 Thread Karol Herbst
gt; _______ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 09/19] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header

2021-03-19 Thread Karol Herbst
___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > Reviewed-by: Karol Herbst ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 05/19] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers

2021-03-19 Thread Karol Herbst
return mv; > } > > -/** > +/* > * cvb_t_mv = > * ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) + > * ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale) > -- > 2.27.0 > > ____

Re: [Nouveau] [PATCH 01/19] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

2021-03-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Mar 19, 2021 at 9:24 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function > parameter or member 'init' not described in 'init_reserved' > drive

Re: [Nouveau] That dispnv50 patch blew up my laptop AGAIN as now it's in the LTS kernel

2021-03-15 Thread Karol Herbst
On Sun, Mar 14, 2021 at 11:04 PM wrote: > > https://forum.artixlinux.org/index.php/topic,2083.msg14006.html#msg14006 > https://forum.artixlinux.org/index.php/topic,2383.new.html#new > > It is going to blow up many more now, the freeze bug may take days, weeks or > months to appear, now with this

  1   2   3   4   5   6   7   8   9   10   >