[Nouveau] [PATCH 1/2] glamor: fix build without glamor.h

2014-06-21 Thread Marcin Slusarz
xorg-server can be built without glamor, which leads to: CC nouveau_xv.lo In file included from nouveau_xv.c:41:0: nouveau_glamor.h:12:20: fatal error: glamor.h: No such file or directory compilation terminated. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- configure.ac | 8

[Nouveau] [PATCH 2/2] present: build only when glamor is enabled

2014-06-21 Thread Marcin Slusarz
nouveau_present_flip_exec references glamor_fd_from_pixmap, which do not exist when glamor is disabled Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- src/nouveau_present.c | 2 +- src/nouveau_present.h | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src

Re: [Nouveau] [PATCH] drm/nouveau: Ack interrupts for some fuc engines

2013-03-26 Thread Marcin Slusarz
On Tue, Mar 26, 2013 at 07:29:24AM +0100, Maarten Lankhorst wrote: Op 25-03-13 19:14, Marcin Slusarz schreef: On Mon, Mar 25, 2013 at 10:22:37AM +0100, Maarten Lankhorst wrote: Fixes 100% cpu usage when the exit interrupt never got acked. Signed-off-by: Maarten Lankhorst m.b.lankho

Re: [Nouveau] [PATCH] drm/nouveau: Ack interrupts for some fuc engines

2013-03-25 Thread Marcin Slusarz
On Mon, Mar 25, 2013 at 10:22:37AM +0100, Maarten Lankhorst wrote: Fixes 100% cpu usage when the exit interrupt never got acked. Signed-off-by: Maarten Lankhorst m.b.lankho...@gmail.com --- diff --git a/drivers/gpu/drm/nouveau/core/core/falcon.c b/drivers/gpu/drm/nouveau/core/core/falcon.c

Re: [Nouveau] [libdrm PATCH 1/2] nouveau: return error from pushbuf_validate

2013-03-19 Thread Marcin Slusarz
On Tue, Mar 05, 2013 at 09:14:53PM +0100, Marcin Slusarz wrote: Without it, libdrm_nouveau user cannot know when validation failed. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- If there are no objections, I'll push both patches soon. Marcin

Re: [Nouveau] [RFC PATCH] drm/nouveau: use vmalloc for pgt allocation

2013-03-19 Thread Marcin Slusarz
On Tue, Mar 05, 2013 at 07:57:08PM +0100, Marcin Slusarz wrote: Page tables on nv50 take 48kB, which can be hard to allocate in one piece. Let's use vmalloc. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Cc: sta...@vger.kernel.org [3.7+] --- drivers/gpu/drm/nouveau/core/subdev/vm

Re: [Nouveau] Fwd: [bisected] nouveau failure with 3.9-rc1 and ongoing

2013-03-14 Thread Marcin Slusarz
On Thu, Mar 14, 2013 at 07:56:03PM +0100, Sune Mølgaard wrote: Marcin Slusarz wrote: I think it may be already fixed by commit 94f54f5336aac6801f2a14dcb12467e41b35456a drm/nv50: encoder creation failure doesn't mean full init failure (post 3.9-rc2) With the latest 3.9-rc2+ git, I got

Re: [Nouveau] Fwd: [bisected] nouveau failure with 3.9-rc1 and ongoing

2013-03-13 Thread Marcin Slusarz
On Wed, Mar 13, 2013 at 06:22:38PM +0100, Sune Mølgaard wrote: Hiya, I sent the enclosed email to linux-kernel before realizing that it would, perhaps, be more proper to send it here, which I hereby do. I shall be happy to try out any and all patches. Best regards, Sune Mølgaard

Re: [Nouveau] Fix unaligned accesses for SPARC

2013-03-13 Thread Marcin Slusarz
On Tue, Mar 12, 2013 at 10:18:41PM -0500, Patrick Baggett wrote: The nouveau driver makes a number of unaligned accesses via the ROM16(), ROM32() and ROM64() macros which fault on SPARC (but would be transparently handled by x86 hardware). Making use of get_unaligned() macro fixes

Re: [Nouveau] nouveau lockdep splat

2013-03-06 Thread Marcin Slusarz
On Wed, Mar 06, 2013 at 01:04:29AM +0100, Borislav Petkov wrote: On Tue, Mar 05, 2013 at 05:30:52PM +0100, Lucas Stach wrote: Dropping Tegra ML, it's not the place where Nouveau mails should go. $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/nouveau/nv50_display.c ...

Re: [Nouveau] [PATCH] drm/nouveau: fix regression in vblanking

2013-03-05 Thread Marcin Slusarz
. Tested-by: Marcin Slusarz marcin.slus...@gmail.com ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [RFC PATCH] drm/nouveau: use vmalloc for pgt allocation

2013-03-05 Thread Marcin Slusarz
Page tables on nv50 take 48kB, which can be hard to allocate in one piece. Let's use vmalloc. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Cc: sta...@vger.kernel.org [3.7+] --- drivers/gpu/drm/nouveau/core/subdev/vm/base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[Nouveau] [PATCH] drm/nouveau: fix crash in vram manager debug callback

2013-03-05 Thread Marcin Slusarz
It's probably impossible to hit it now on mainline kernel. I only noticed it because one of my debugging patches uses it. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[Nouveau] [PATCH] drm/nouveau: drop redundant channel handle and owner info from nv_channel_idle

2013-03-05 Thread Marcin Slusarz
before: nouveau E[X[3162]] failed to idle channel 0x [X[3162]] after: nouveau E[X[3162]] failed to idle channel: -16 Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_chan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Nouveau] [PATCH] drm/nouveau/nv50: use correct tiling methods for m2mf buffer moves

2013-03-05 Thread Marcin Slusarz
Currently used only on original nv50, nvaa and nvac. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- Note: it would be catched much faster (probably even by author, and not after 2 years) if this code would use (known!) register names... --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4

[Nouveau] [PATCH] drm/nouveau: idle channel before releasing notify object

2013-03-05 Thread Marcin Slusarz
Unmapping it while it's still in use (e.g. by M2MF) can lead to page faults and a lot of TRAP_M2MF spam in dmesg. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/nouveau

[Nouveau] [PATCH] drm/nv50/disp: ignore encoder initialization failures

2013-03-05 Thread Marcin Slusarz
eb6313add6dddf07ea3e50c4caa33a9c3b2379f1 (drm/nv50: initial kms support for off-chip TMDS/DP encoders). Reported-by: Richard Yao r...@gentoo.org Tested-by: Richard Yao r...@gentoo.org Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nv50_display.c | 1 + 1 file changed, 1

[Nouveau] [libdrm PATCH 1/2] nouveau: return error from pushbuf_validate

2013-03-05 Thread Marcin Slusarz
Without it, libdrm_nouveau user cannot know when validation failed. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- nouveau/pushbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nouveau/pushbuf.c b/nouveau/pushbuf.c index ff8e125..e720a08 100644 --- a/nouveau

[Nouveau] [libdrm PATCH 2/2] nouveau: add a way to override single pushbuffer vram/gart limits

2013-03-05 Thread Marcin Slusarz
Add environment variables: NOUVEAU_LIBDRM_VRAM_LIMIT_PERCENT NOUVEAU_LIBDRM_GART_LIMIT_PERCENT which will allow override how much VRAM/GART single pushbuffer can take. Default to 80. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- nouveau/nouveau.c | 18 -- nouveau

Re: [Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Marcin Slusarz
fix https://bugs.freedesktop.org/show_bug.cgi?id=59168. (note: it doesn't apply on top of nouveau/master) Reviewed-by: Marcin Slusarz marcin.slus...@gmail.com --- diff --git a/drivers/gpu/drm/nouveau/nvc0_fence.c b/drivers/gpu/drm/nouveau/nvc0_fence.c index 85a0e78..4f46d8b 100644

Re: [Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 10:09:12PM +0100, Michael Weirauch wrote: 2013/2/19 Marcin Slusarz marcin.slus...@gmail.com: Yay. It will probably fix https://bugs.freedesktop.org/show_bug.cgi?id=59168. (note: it doesn't apply on top of nouveau/master) Please correct me if I am wrong

Re: [Nouveau] Monitor with corrupted EDID

2013-02-07 Thread Marcin Slusarz
On Thu, Feb 07, 2013 at 04:16:54PM +0100, Flavio Castelli wrote: For an unknown reason both my monitors ended up with a corrupted EDID. They both provide VGA and DVI input. The VGA input works fine, while DVI is broken because of the EDID issue. Using these [1] instructions I have been able

[Nouveau] [PATCH] drm/nouveau: add lockdep annotations

2013-02-04 Thread Marcin Slusarz
class. Reported-by: Arend van Spriel ar...@broadcom.com Reported-by: Peter Hurley pe...@hurleysoftware.com Reported-by: Maarten Lankhorst maarten.lankho...@canonical.com Reported-by: Daniel J Blueman dan...@quora.org Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Cc: sta...@vger.kernel.org

[Nouveau] [PATCH 1/3] drm/nouveau/therm: turn on a fan only when crossing threshold in positive direction

2013-02-03 Thread Marcin Slusarz
+ the same for shutdown threshold - seems impossible, but shutdown can fail. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/subdev/therm/temp.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core

[Nouveau] [PATCH 2/3] drm/nv40/therm: reset temperature sensor on init

2013-02-03 Thread Marcin Slusarz
Current uninitialized sensor detection does not work for me on nv4b and sensor returns crazy values (190°C). It stabilises later, but it's too late - therm code shutdowns the machine... Let's just reset it on init. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm

[Nouveau] [PATCH 3/3] drm/nouveau/therm: use workqueue to shutdown the machine

2013-02-03 Thread Marcin Slusarz
orderly_poweroff cannot be called from atomic context. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/subdev/therm/temp.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/subdev/therm

[Nouveau] [PATCH] nv30/exa: fix shaders on big-endian machines

2013-02-03 Thread Marcin Slusarz
Direct port of commit d1bc38b6673c54af61196056c489383fba8dced8 nv40/exa: fix shaders on big-endian machines to nv30. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=60050 --- src/nv30_exa.c | 272 - 1 file changed, 136 insertions(+), 136

Re: [Nouveau] [PATCH 2/3] drm/nv40/therm: reset temperature sensor on init

2013-02-03 Thread Marcin Slusarz
On Sun, Feb 03, 2013 at 09:07:56PM +0100, Marcin Slusarz wrote: Current uninitialized sensor detection does not work for me on nv4b and sensor returns crazy values (190°C). It stabilises later, but it's too late - therm code shutdowns the machine... Let's just reset it on init. Signed-off

Re: [Nouveau] Resume regression with nouveau 3.8rc1 (bisected)

2013-01-05 Thread Marcin Slusarz
On Sat, Jan 05, 2013 at 10:10:06AM +0100, Pontus Fuchs wrote: On 01/03/2013 08:12 PM, Marcin Slusarz wrote: On Thu, Jan 03, 2013 at 01:58:10PM +0100, Marcin Slusarz wrote: I bisected the problem down to this commit: 186ecad21: drm/nv50/disp: move remaining interrupt handling into core

Re: [Nouveau] Resume regression with nouveau 3.8rc1 (bisected)

2013-01-03 Thread Marcin Slusarz
On Wed, Jan 02, 2013 at 04:19:35PM +0100, Pontus Fuchs wrote: Hi, Starting with 3.8rc1 I get a black screen when resuming after suspend. The kernel is alive because I can switch to VT1 and reboot with ctrl-alt-delete. I bisected the problem down to this commit: 186ecad21:

Re: [Nouveau] Resume regression with nouveau 3.8rc1 (bisected)

2013-01-03 Thread Marcin Slusarz
On Thu, Jan 03, 2013 at 01:58:10PM +0100, Marcin Slusarz wrote: On Wed, Jan 02, 2013 at 04:19:35PM +0100, Pontus Fuchs wrote: Hi, Starting with 3.8rc1 I get a black screen when resuming after suspend. The kernel is alive because I can switch to VT1 and reboot with ctrl-alt-delete

[Nouveau] [PATCH] drm/nv17-50: restore fence buffer on resume

2012-12-26 Thread Marcin Slusarz
is stored) are not saved+restored across suspend/resume, we need to do it manually. nvc0+ was fixed by commit d6ba6d215a538a58f0f0026f0961b0b9125e8042 drm/nvc0/fence: restore pre-suspend fence buffer context on resume. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=50121 Signed-off-by: Marcin

[Nouveau] [PATCH] drm/nouveau: share fence structures between nv10+ and nv50 implementations

2012-12-26 Thread Marcin Slusarz
We already rely on them having the same fields and layout. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nv10_fence.c | 13 + drivers/gpu/drm/nouveau/nv10_fence.h | 19 +++ drivers/gpu/drm/nouveau/nv50_fence.c | 19

Re: [Nouveau] G4 Snowball DPMS 1 fix

2012-12-22 Thread Marcin Slusarz
-by: Marcin Slusarz marcin.slus...@gmail.com ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH] drm/nouveau: fix ramht wraparound

2012-12-21 Thread Marcin Slusarz
On Fri, Dec 21, 2012 at 10:15:48AM +1000, Ben Skeggs wrote: On Thu, Dec 20, 2012 at 11:37:12PM +0100, Marcin Slusarz wrote: When hash collision occurs and it's near ramht object boundary, we could read and possibly overwrite some memory after ramht object. Signed-off-by: Marcin Slusarz

[Nouveau] [PATCH RESEND] drm/nouveau: add locking around instobj list operations

2012-12-20 Thread Marcin Slusarz
Fixes memory corruptions, oopses, etc. when multiple gpuobjs are simultaneously created or destroyed. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Cc: sta...@vger.kernel.org --- drivers/gpu/drm/nouveau/core/subdev/instmem/base.c | 35 +- 1 file changed, 27

[Nouveau] [PATCH] drm/nouveau/vm: fix memory corruption when pgt allocation fails

2012-12-20 Thread Marcin Slusarz
If we return freed vm, nouveau_drm_open will happily call nouveau_cli_destroy, which will try to free it again. Reported-by: Peter Hurley pe...@hurleysoftware.com Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/subdev/vm/base.c | 4 +++- 1 file changed, 3

[Nouveau] [PATCH] drm/nouveau: don't return freed object from nouveau_handle_create

2012-12-20 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/handle.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/core/handle.c b/drivers/gpu/drm/nouveau/core/core/handle.c index b8d2cbf..264c2b3 100644

[Nouveau] [PATCH] drm/nouveau: fix nouveau_client allocation failure path

2012-12-20 Thread Marcin Slusarz
Depending on the point of failure, freed object would be returned or memory leak would happen. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/client.c | 4 +--- drivers/gpu/drm/nouveau/core/include/core/client.h | 3 +++ drivers/gpu/drm

[Nouveau] [PATCH] drm/nouveau: fix ramht wraparound

2012-12-20 Thread Marcin Slusarz
When hash collision occurs and it's near ramht object boundary, we could read and possibly overwrite some memory after ramht object. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Cc: sta...@vger.kernel.org --- drivers/gpu/drm/nouveau/core/core/ramht.c | 2 +- 1 file changed, 1 insertion

[Nouveau] [PATCH] drm/nouveau: fix blank LVDS screen regression on pre-nv50 cards

2012-12-20 Thread Marcin Slusarz
it skips calling some crucial lvds scripts. Reported-by: Chris Paulson-Ellis ch...@edesix.com Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Cc: sta...@vger.kernel.org --- drivers/gpu/drm/nouveau/nv04_dfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[Nouveau] [PATCH] drm/nouveau: improve reporting of fifo errors

2012-12-20 Thread Marcin Slusarz
Note: bar faults and semaphore errors were previously silently acked. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/engine/fifo/nv04.c | 142 ++-- drivers/gpu/drm/nouveau/core/engine/fifo/nv04.h | 5 +- 2 files changed, 139

[Nouveau] reproducible CACHE_ERRORS

2012-12-20 Thread Marcin Slusarz
Hi I found a way to reliably reproduce PFIFO CACHE_ERRORS, but I don't see why. How to reproduce them: 1) Run a couple of glxinfo loops - 3 is usually enough. while [ true ]; do nvgl glxinfo /dev/null 2/dev/null; done 2) Run glxgears. 3) If you can't see it now, resize glxgears window or add

[Nouveau] [PATCH] libdrm_nouveau.pc: don't include I${includedir}/nouveau

2012-12-20 Thread Marcin Slusarz
Nouveau related headers are installed in I${includedir}/libdrm now. --- nouveau/libdrm_nouveau.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nouveau/libdrm_nouveau.pc.in b/nouveau/libdrm_nouveau.pc.in index 6170613..454fc87 100644 --- a/nouveau/libdrm_nouveau.pc.in +++

Re: [Nouveau] [RFC PATCH] drm/nouveau: report channel owner in error messages

2012-12-10 Thread Marcin Slusarz
On Mon, Dec 10, 2012 at 06:47:41PM +1000, Ben Skeggs wrote: On Sun, Dec 09, 2012 at 12:04:54PM +0100, Marcin Slusarz wrote: On Sun, Dec 09, 2012 at 02:48:49PM +1000, Ben Skeggs wrote: diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/nv50.c b/drivers/gpu/drm/nouveau/core/subdev

Re: [Nouveau] [RFC PATCH] drm/nouveau: report channel owner in error messages

2012-12-09 Thread Marcin Slusarz
On Sun, Dec 09, 2012 at 02:48:49PM +1000, Ben Skeggs wrote: diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/nv50.c b/drivers/gpu/drm/nouveau/core/subdev/fb/nv50.c index 487cb8c..d1120fc 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/fb/nv50.c +++

[Nouveau] [PATCH 1/4] drm/nouveau: split fifo interrupt handler

2012-12-09 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/engine/fifo/nv04.c | 174 1 file changed, 88 insertions(+), 86 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/engine/fifo/nv04.c b/drivers/gpu/drm/nouveau/core/engine/fifo

[Nouveau] [PATCH 2/4] drm/nouveau: use pr_cont

2012-12-09 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/enum.c | 8 drivers/gpu/drm/nouveau/core/engine/copy/nva3.c | 2 +- drivers/gpu/drm/nouveau/core/engine/crypt/nv84.c | 2 +- drivers/gpu/drm/nouveau/core/engine/crypt/nv98.c | 2

[Nouveau] [PATCH 3/4] drm/nouveau: prepare for reporting channel owner

2012-12-09 Thread Marcin Slusarz
- record channel owner process name - add some helpers for accessing this information - let nouveau_enum hold additional value (will be needed in the next patch) Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/client.c | 10 ++ drivers

[Nouveau] [PATCHv2 4/4] drm/nouveau: report channel owner in error messages

2012-12-09 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/engine/copy/nva3.c | 6 ++-- drivers/gpu/drm/nouveau/core/engine/crypt/nv84.c | 6 ++-- drivers/gpu/drm/nouveau/core/engine/crypt/nv98.c | 6 ++-- drivers/gpu/drm/nouveau/core/engine/fifo/nv04.c | 22

[Nouveau] [PATCHv3 4/4] drm/nouveau: report channel owner in error messages

2012-12-09 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- v2: finish, fixes after initial review v3: fix reporting of vm_engine when client already went away --- drivers/gpu/drm/nouveau/core/engine/copy/nva3.c | 6 ++-- drivers/gpu/drm/nouveau/core/engine/crypt/nv84.c | 6 ++-- drivers/gpu

Re: [Nouveau] [RFC PATCH] drm/nouveau: report channel owner in error messages

2012-12-08 Thread Marcin Slusarz
On Fri, Dec 07, 2012 at 02:46:53PM +1000, Ben Skeggs wrote: On Wed, Dec 05, 2012 at 11:56:22PM +0100, Marcin Slusarz wrote: Full piglit run with this patch: http://people.freedesktop.org/~mslusarz/chan_owners.txt This patch covers only a small subset of all error messages, so: Not-yet

[Nouveau] [RFC PATCH] drm/nouveau: report channel owner in error messages

2012-12-06 Thread Marcin Slusarz
Full piglit run with this patch: http://people.freedesktop.org/~mslusarz/chan_owners.txt This patch covers only a small subset of all error messages, so: Not-yet-signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Comments? Ideas? (This commit depends on this one: http

Re: [Nouveau] [PATCH] drm/nouveau: unpin pushbuffer bo before destroying it

2012-12-02 Thread Marcin Slusarz
On Sun, Nov 25, 2012 at 11:02:28PM +0100, Marcin Slusarz wrote: Fixes GART leak (as accounted by nouveau_drm.gem.gart_available). Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- Running glxinfo in a loop is enough to trigger it - after several thousand runs (depending on GART

[Nouveau] [PATCH] drm/nouveau: add locking around instobj list operations

2012-12-02 Thread Marcin Slusarz
Fixes memory corruptions (unrelated to nouveau!), oopses, gpu lockups and xserver crashes when multiple gpuobjs are simultaneously created / destroyed. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- Piglit, with concurrency enabled, can finally finish without crashes or lockups (most

Re: [Nouveau] [PATCH] drm/nouveau: add locking around instobj list operations

2012-12-02 Thread Marcin Slusarz
On Sun, Dec 02, 2012 at 02:53:01PM +0100, Marcin Slusarz wrote: Fixes memory corruptions (unrelated to nouveau!), oopses, gpu lockups and xserver crashes when multiple gpuobjs are simultaneously created / destroyed. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- Piglit

Re: [Nouveau] GTX-560 in v3.6

2012-12-01 Thread Marcin Slusarz
On Thu, Nov 29, 2012 at 11:56:54AM +0100, Javier Domingo wrote: Hi, I am running a GTX-560 with nouveau driver, or at least I try to, and I dont get it working... I have seen that in the Xorg.log.0 appears the chipset family, but I don't know why it isn't working. I attach the Xorg.log.0

[Nouveau] [ddx PATCH] add some missing newlines in error messages

2012-11-26 Thread Marcin Slusarz
--- src/drmmode_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 803785d..4d2d09d 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -357,7 +357,7 @@ drmmode_set_mode_major(xf86CrtcPtr crtc,

[Nouveau] [PATCH] drm/nouveau: raise reporting levels of some messages

2012-11-26 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/engine/fifo/nv04.c | 10 +- drivers/gpu/drm/nouveau/core/engine/fifo/nvc0.c | 2 +- drivers/gpu/drm/nouveau/core/engine/graph/nv20.c | 4 ++-- drivers/gpu/drm/nouveau/core/engine/graph/nv40.c | 2

[Nouveau] [PATCH] drm/nouveau: remove misleading comment from nouveau_prime_new

2012-11-26 Thread Marcin Slusarz
Copy/pasted from nouveau_gem_new. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_prime.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c index 366462c..3543fec

[Nouveau] [PATCH] drm/nouveau: unpin pushbuffer bo before destroying it

2012-11-26 Thread Marcin Slusarz
Fixes GART leak (as accounted by nouveau_drm.gem.gart_available). Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- Running glxinfo in a loop is enough to trigger it - after several thousand runs (depending on GART size), X server crashes and does not come back in a correct state

[Nouveau] [PATCH] drm/nouveau: unpin various bo's before destroying

2012-11-26 Thread Marcin Slusarz
These objects leak VRAM - but only on module unload. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nv04_crtc.c| 6 +- drivers/gpu/drm/nouveau/nv10_fence.c | 7 ++- drivers/gpu/drm/nouveau/nv50_display.c | 21 ++--- drivers/gpu

Re: [Nouveau] Reproducible PGRAPH TLB flush timeout hang on NV96

2012-11-26 Thread Marcin Slusarz
On Sun, Nov 25, 2012 at 11:50:50PM +0100, Maarten Maathuis wrote: Hi everyone, I was wondering what to do to dig into this problem further.The kernel is several weeks old (nouveau tree), it's at commit 000463f13fba6b2f94a5bfcb0d615751ae9c34a0. As you can see from the mesages below the

Re: [Nouveau] Reproducible PGRAPH TLB flush timeout hang on NV96

2012-11-26 Thread Marcin Slusarz
On Mon, Nov 26, 2012 at 08:16:17PM +0100, Maarten Maathuis wrote: On Mon, Nov 26, 2012 at 7:04 PM, Marcin Slusarz marcin.slus...@gmail.com wrote: On Sun, Nov 25, 2012 at 11:50:50PM +0100, Maarten Maathuis wrote: Hi everyone, I was wondering what to do to dig into this problem further.The

Re: [Nouveau] [PATCH] drm/nouveau/bios: fix DCB v1.5 parsing

2012-11-17 Thread Marcin Slusarz
On Fri, Nov 16, 2012 at 09:36:56PM +1000, Dave Airlie wrote: On Fri, Nov 16, 2012 at 7:09 AM, Marcin Slusarz marcin.slus...@gmail.com wrote: memcmp-nv_strncmp conversion should have inverted the return value. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- See http

[Nouveau] [PATCH] drm/nouveau/bios: fix DCB v1.5 parsing

2012-11-15 Thread Marcin Slusarz
memcmp-nv_strncmp conversion should have inverted the return value. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- See http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/gpu/drm/nouveau/nouveau_bios.c;h=a0a3fe3c016be86665db1369c44bef832f829a1a;hb

Re: [Nouveau] Fix for vblank on nvc0

2012-11-12 Thread Marcin Slusarz
On Mon, Nov 12, 2012 at 06:14:05AM -0600, Kelly Doran wrote: Okay I have added two patches, one of them should fix the problem... vblank-fix1.patch works, thanks. Marcin ___ Nouveau mailing list Nouveau@lists.freedesktop.org

Re: [Nouveau] Fix for vblank on nvc0

2012-11-11 Thread Marcin Slusarz
On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: Op 06-11-12 15:48, Kelly Doran schreef: The vblank on nvc0 was not working correctly and would freeze X, I managed to track it down and fix it with some help from m.b.lankhorst, see

Re: [Nouveau] Fix for vblank on nvc0

2012-11-11 Thread Marcin Slusarz
On Sun, Nov 11, 2012 at 07:26:17PM +0100, Marcin Slusarz wrote: On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: Op 06-11-12 15:48, Kelly Doran schreef: The vblank on nvc0 was not working correctly and would freeze X, I managed to track it down and fix it with some

Re: [Nouveau] [PATCH] drm/nv50: decode PGRAPH status registers on TLB flush fail

2012-11-11 Thread Marcin Slusarz
On Wed, Nov 07, 2012 at 08:04:41PM +0100, Marcin Slusarz wrote: On Wed, Nov 07, 2012 at 10:08:47AM +1000, Ben Skeggs wrote: On Tue, Nov 06, 2012 at 10:48:52PM +0100, Marcin Slusarz wrote: Now it outputs: nouveau E[ PGRAPH][:02:00.0] PGRAPH TLB flush idle timeout fail nouveau E

[Nouveau] [PATCH] drm/nouveau: remove unused variable from nouveau_bios_shadow_of

2012-11-11 Thread Marcin Slusarz
drivers/gpu/drm/nouveau/core/subdev/bios/base.c: warning: unused variable 'i' Reported-by: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- It's powerpc only code, so this wasn't compile tested. --- drivers/gpu/drm/nouveau/core/subdev/bios

Re: [Nouveau] [PATCH] kms: Let the server know if we got more than 1 EDID block

2012-11-11 Thread Marcin Slusarz
On Sun, Nov 11, 2012 at 08:09:08PM +, Emil Velikov wrote: On 04/11/12 18:06, Emil Velikov wrote: Verbatim copy from xf86-video-radeon commit 809cacb s/radeon/ati/ Here's direct link: http://cgit.freedesktop.org/xorg/driver/xf86-video-ati/commit/?id=809cacb Bugzilla:

Re: [Nouveau] [PATCH] nouveau: Fix crash after D3

2012-11-07 Thread Marcin Slusarz
On Tue, Nov 06, 2012 at 10:03:40PM +0800, Daniel J Blueman wrote: In 3.7-rc4, when starting X with the integrated GPU and suspending the discrete GPU, after one or more 32-bit applications are used (eg Skype) and X is stopped, we hit a panic. Prevent this by testing if the fini function is

Re: [Nouveau] [PATCH] drm/nv50: decode PGRAPH status registers on TLB flush fail

2012-11-07 Thread Marcin Slusarz
On Wed, Nov 07, 2012 at 10:08:47AM +1000, Ben Skeggs wrote: On Tue, Nov 06, 2012 at 10:48:52PM +0100, Marcin Slusarz wrote: Now it outputs: nouveau E[ PGRAPH][:02:00.0] PGRAPH TLB flush idle timeout fail nouveau E[ PGRAPH][:02:00.0] PGRAPH_STATUS: BUSY DISPATCH VFETCH

[Nouveau] [PATCH v2] drm/nv41/vm: fix typo in type name

2012-11-06 Thread Marcin Slusarz
It's a miracle it compiles at all - nv04_vm_priv does not exist anywhere in the tree. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- v2: rebased on top of nouveau/master --- drivers/gpu/drm/nouveau/core/subdev/vm/nv41.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Nouveau] [PATCH] drm/nv40/graph: fix typo in type names

2012-11-06 Thread Marcin Slusarz
nv04_graph_priv / nv04_graph_chan are not defined in this context... Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/engine/graph/nv40.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/engine/graph/nv40

[Nouveau] [PATCH] drm/nv40/mpeg: fix context handling

2012-11-06 Thread Marcin Slusarz
It slipped in thanks to typeless API. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/engine/mpeg/nv40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/engine/mpeg/nv40.c b/drivers/gpu/drm/nouveau/core

[Nouveau] [PATCH] drm/nv50: decode PGRAPH status registers on TLB flush fail

2012-11-06 Thread Marcin Slusarz
] PGRAPH_VSTATUS: CCACHE (0x00145b4d) (0x002d) ENG2D ROP (0x0034db40) instead of: [drm] nouveau :02:00.0: PGRAPH TLB flush idle timeout fail: 0x011fde03 0x00145b4d 0x002d 0x0034db40 Based on envytools docs. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm

[Nouveau] [PATCH] drm/nv50/evo: store iomem pointer in properly typed field

2012-11-06 Thread Marcin Slusarz
Abuse of function pointer was noticed by sparse. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nv50_evo.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_evo.c b/drivers/gpu/drm/nouveau

Re: [Nouveau] Nouveau soft lockup after switcheroo'd...

2012-11-01 Thread Marcin Slusarz
On Mon, Oct 29, 2012 at 10:09:07PM +0800, Daniel J Blueman wrote: On 25 October 2012 02:07, Marcin Slusarz marcin.slus...@gmail.com wrote: On Wed, Oct 24, 2012 at 01:54:43PM +0800, Daniel J Blueman wrote: On 13 October 2012 15:12, Daniel J Blueman dan...@quora.org wrote: [...] echo IGD

Re: [Nouveau] Virtualbox 3D accel broken in xf86-video-nouveau 1.0.3

2012-11-01 Thread Marcin Slusarz
On Thu, Nov 01, 2012 at 11:13:03AM -0500, Pouar wrote: On 2012/10/31 17:27, Marcin Slusarz wrote: On Tue, Oct 30, 2012 at 01:30:53PM -0500, Pouar wrote: On 10/30/2012 01:28 PM, Pouar wrote: On 10/28/2012 01:21 PM, Pouar wrote: On 10/28/2012 01:18 PM, Emil Velikov wrote

Re: [Nouveau] Virtualbox 3D accel broken in xf86-video-nouveau 1.0.3

2012-10-31 Thread Marcin Slusarz
On Tue, Oct 30, 2012 at 01:30:53PM -0500, Pouar wrote: On 10/30/2012 01:28 PM, Pouar wrote: On 10/28/2012 01:21 PM, Pouar wrote: On 10/28/2012 01:18 PM, Emil Velikov wrote: On Sun, 28 Oct 2012 01:15:54 -, Pouar wrote: there's a regression in the

Re: [Nouveau] Nouveau soft lockup after switcheroo'd...

2012-10-24 Thread Marcin Slusarz
On Wed, Oct 24, 2012 at 01:54:43PM +0800, Daniel J Blueman wrote: On 13 October 2012 15:12, Daniel J Blueman dan...@quora.org wrote: On my Macbook Retina, when switching to the integrated GPU, we see a ioread32 issued to the discrete GPU, which hangs as it is in D3 [1] (drm.debug is set to

[Nouveau] [PATCH] drm/nv41/vm: fix typo in struct name

2012-10-22 Thread Marcin Slusarz
It's a miracle it compiles at all - nv04_vm_priv does not exist anywhere in the tree. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- Noticed when adding types to Nouveau APIs. --- drivers/gpu/drm/nouveau/core/subdev/vm/nv41.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Nouveau] [PATCH] drm/nouveau/bios: use size provided by _ROM method

2012-10-21 Thread Marcin Slusarz
On Sun, Oct 21, 2012 at 12:53:15PM +0200, Lekensteyn wrote: From: Peter Wu lekenst...@gmail.com Since commit drm/nouveau/bios: attempt to fetch entire acpi rom image in one shot, the ACPI spec is broken in order to gain speed. In theory, since the _ROM method is supposed to return 4 KiB

Re: [Nouveau] [PATCH] drm/nouveau: fix nouveau_mm/nouveau_mm_node leak

2012-10-21 Thread Marcin Slusarz
On Fri, Oct 19, 2012 at 04:05:14PM +1000, Ben Skeggs wrote: On Thu, Oct 11, 2012 at 11:53:09PM +0200, Marcin Slusarz wrote: Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/gpuobj.c | 6 +- drivers/gpu/drm/nouveau/core/include/core

[Nouveau] [PATCH v2] drm/nouveau: fix nouveau_mm/nouveau_mm_node leak

2012-10-21 Thread Marcin Slusarz
v2: use already existing parent Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/gpuobj.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/nouveau/core/core/gpuobj.c b/drivers/gpu/drm/nouveau/core/core/gpuobj.c index c2a7608

[Nouveau] [PATCH] drm/nouveau: warn when trying to free mm which is still in use

2012-10-21 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/core/mm.c b/drivers/gpu/drm/nouveau/core/core/mm.c index bfddf87..4d62064 100644 --- a/drivers/gpu

Re: [Nouveau] [PATCH 01/10] drm/nv50: decode PGRAPH status registers on TLB flush fail

2012-10-16 Thread Marcin Slusarz
On Thu, Oct 04, 2012 at 01:43:15PM +0200, Marcin Slusarz wrote: On Thu, Sep 13, 2012 at 12:47:53AM +0200, Marcin Slusarz wrote: On Tue, Aug 21, 2012 at 12:08:32AM +0200, Marcin Slusarz wrote: On Mon, Aug 20, 2012 at 07:02:46PM +0200, Marcin Slusarz wrote: On Mon, Aug 20, 2012 at 04:27

Re: [Nouveau] [PATCH] drm/nouveau: handle same-fb page flips

2012-10-16 Thread Marcin Slusarz
On Fri, Oct 05, 2012 at 09:37:59PM +0200, Marcin Slusarz wrote: It's questionable use case, but weston/wayland already relies on this behaviour, and other drivers don't care about it, so it's a matter of compatibility. Without it, process invoking such page flip hangs in unkillable state

Re: [Nouveau] [PATCH] drm/nouveau: fix nouveau_mm/nouveau_mm_node leak

2012-10-16 Thread Marcin Slusarz
On Thu, Oct 11, 2012 at 11:53:09PM +0200, Marcin Slusarz wrote: Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/gpuobj.c | 6 +- drivers/gpu/drm/nouveau/core/include/core/gpuobj.h | 3 +++ 2 files changed, 8 insertions(+), 1 deletion

[Nouveau] [PATCH] drm/nouveau: remove redundant comments listing classes

2012-10-16 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/include/core/class.h | 31 +++ 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/include/core/class.h b/drivers/gpu/drm/nouveau/core/include/core

Re: [Nouveau] [PATCH] drm/nv50: wire up pll_calc hook

2012-10-11 Thread Marcin Slusarz
On Mon, Oct 08, 2012 at 12:49:27AM +0200, Marcin Slusarz wrote: Fixes crash during reclocking. Call Trace: pll_calc == NULL calc_pll calc_mclk nv50_pm_clocks_pre nouveau_pm_perflvl_set nouveau_pm_trigger nouveau_pm_profile_set nouveau_pm_set_perflvl dev_attr_store

[Nouveau] [PATCH] drm/nv50/fb: fix double free of vram mm

2012-10-11 Thread Marcin Slusarz
nouveau_fb_destroy already calls nouveau_mm_fini on vram mm. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/subdev/fb/nv50.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/nv50.c b/drivers/gpu/drm/nouveau/core

[Nouveau] [PATCH] drm/nouveau: fix nouveau_mm/nouveau_mm_node leak

2012-10-11 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/gpuobj.c | 6 +- drivers/gpu/drm/nouveau/core/include/core/gpuobj.h | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/core/gpuobj.c b/drivers

Re: [Nouveau] [PATCH] drm/nouveau: comment out unused _nouveau_parent_ctor

2012-10-08 Thread Marcin Slusarz
On Mon, Oct 08, 2012 at 11:07:34AM +1000, Ben Skeggs wrote: On Mon, Oct 08, 2012 at 12:49:28AM +0200, Marcin Slusarz wrote: Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/parent.c | 2 ++ drivers/gpu/drm/nouveau/core/include/core

Re: [Nouveau] [PATCH] drm/nouveau: remove 1 sclass support from nouveau_parent_create_

2012-10-08 Thread Marcin Slusarz
On Mon, Oct 08, 2012 at 11:06:46AM +1000, Ben Skeggs wrote: On Mon, Oct 08, 2012 at 12:49:30AM +0200, Marcin Slusarz wrote: It's unused (only one codepath passes sclass at all and it's always one), broken (overwrites the same field, leaking previous one) and confusing. It's only *currently

[Nouveau] [PATCH] drm/nv50: wire up pll_calc hook

2012-10-07 Thread Marcin Slusarz
Fixes crash during reclocking. Call Trace: pll_calc == NULL calc_pll calc_mclk nv50_pm_clocks_pre nouveau_pm_perflvl_set nouveau_pm_trigger nouveau_pm_profile_set nouveau_pm_set_perflvl dev_attr_store sysfs_write_file vfs_write sys_write system_call_fastpath Signed-off-by: Marcin

[Nouveau] [PATCH] drm/nouveau: comment out unused _nouveau_parent_ctor

2012-10-07 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/parent.c | 2 ++ drivers/gpu/drm/nouveau/core/include/core/parent.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/nouveau/core/core/parent.c b/drivers/gpu/drm/nouveau

[Nouveau] [PATCH] drm/nouveau: add some comments about class fields

2012-10-07 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/include/core/engine.h | 4 drivers/gpu/drm/nouveau/core/include/core/parent.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/nouveau/core/include/core/engine.h b/drivers/gpu/drm

  1   2   3   4   >