Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies

2016-10-24 Thread Baoyou Xie
On 24 October 2016 at 23:43, Karol Herbst wrote: > 2016-10-24 9:13 GMT+02:00 Baoyou Xie : > > > > > > On 23 October 2016 at 01:32, Karol Herbst wrote: > >> > >> I think it would be better to squash those commits: > >> 1. for

Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies

2016-10-24 Thread Karol Herbst
2016-10-24 9:13 GMT+02:00 Baoyou Xie : > > > On 23 October 2016 at 01:32, Karol Herbst wrote: >> >> I think it would be better to squash those commits: >> 1. for the includes >> 2. for static declerations >> > OK, I have resent new patch that squash

Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies

2016-10-24 Thread Baoyou Xie
On 23 October 2016 at 01:32, Karol Herbst wrote: > I think it would be better to squash those commits: > 1. for the includes > 2. for static declerations > > OK, I have resent new patch that squash those commits. > 2016-10-22 11:41 GMT+02:00 Baoyou Xie

Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies

2016-10-22 Thread Karol Herbst
I think it would be better to squash those commits: 1. for the includes 2. for static declerations 2016-10-22 11:41 GMT+02:00 Baoyou Xie : > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous >

[Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies

2016-10-22 Thread Baoyou Xie
We get 2 warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put'