Re: [Nouveau] [PATCH] avoid build fail without COMPOSITE

2015-07-18 Thread Emil Velikov
On 15 July 2015 at 14:12, Emil Velikov emil.l.veli...@gmail.com wrote: Upon closer look it seem that I was a bit off - the ati/intel ddx does not set off_x/y to zero when built without composite*. ... in copy_region2, they do so when working with video -

Re: [Nouveau] [PATCH] avoid build fail without COMPOSITE

2015-07-15 Thread Emil Velikov
Upon closer look it seem that I was a bit off - the ati/intel ddx does not set off_x/y to zero when built without composite*. ... in copy_region2, they do so when working with video - XvAdaptorPtr::ddPutImage/XF86VideoAdaptorPtr::PutImage. Does this mean that they need a similar update ? What

Re: [Nouveau] [PATCH] avoid build fail without COMPOSITE

2015-07-14 Thread Emil Velikov
On 14 July 2015 at 22:17, Ilia Mirkin imir...@alum.mit.edu wrote: --- src/nouveau_dri2.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c index f22e319..4398559 100644 --- a/src/nouveau_dri2.c +++

Re: [Nouveau] [PATCH] avoid build fail without COMPOSITE

2015-07-14 Thread Tobias Klausmann
Lgtm! You can add my R-b if you want! On 14.07.2015 23:17, Ilia Mirkin wrote: --- src/nouveau_dri2.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c index f22e319..4398559 100644 --- a/src/nouveau_dri2.c +++

[Nouveau] [PATCH] avoid build fail without COMPOSITE

2015-07-14 Thread Ilia Mirkin
--- src/nouveau_dri2.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c index f22e319..4398559 100644 --- a/src/nouveau_dri2.c +++ b/src/nouveau_dri2.c @@ -142,6 +142,7 @@ nouveau_dri2_copy_region2(ScreenPtr pScreen,

Re: [Nouveau] [PATCH] avoid build fail without COMPOSITE

2015-07-14 Thread Ilia Mirkin
Well, I don't pretend to know anything about X, but this is the commit that added the code in question: commit 297fd0d0755bda698be1d0b30cc60a41d7673c0b Author: Dave Airlie airl...@redhat.com Date: Tue Oct 16 16:15:16 2012 +1000 nouveau/dri2: fix pixmap/window offset calcs. This should