Re: [Nouveau] [PATCH] drm/nouveau: add a LED driver for the NVIDIA logo

2016-05-08 Thread Martin Peres
On 07/05/16 23:44, karol herbst wrote: looks good, just a minor thing: You need to check for CONFIG_LEDS_CLASS, otherwise the compile throws out "warnings": WARNING: "led_classdev_register" [/home/karol/Dokumente/repos/nouveau/drm/nouveau/nouveau.ko] undefined! WARNING: "led_classdev_resume" [/h

Re: [Nouveau] [PATCH] drm/nouveau: add a LED driver for the NVIDIA logo

2016-05-08 Thread karol herbst
looks good, just a minor thing: You need to check for CONFIG_LEDS_CLASS, otherwise the compile throws out "warnings": WARNING: "led_classdev_register" [/home/karol/Dokumente/repos/nouveau/drm/nouveau/nouveau.ko] undefined! WARNING: "led_classdev_resume" [/home/karol/Dokumente/repos/nouveau/drm/nou

Re: [Nouveau] [PATCH] drm/nouveau: add a LED driver for the NVIDIA logo

2016-05-03 Thread Martin Peres
On 04/05/16 02:57, Ilia Mirkin wrote: On Tue, May 3, 2016 at 7:51 PM, Martin Peres wrote: We received a donation of a Titan which has this useless feature allowing users to control the brightness of the LED behind the logo of NVIDIA. In the true spirit of open source, let's expose that to the u

Re: [Nouveau] [PATCH] drm/nouveau: add a LED driver for the NVIDIA logo

2016-05-03 Thread Ilia Mirkin
On Tue, May 3, 2016 at 7:51 PM, Martin Peres wrote: > We received a donation of a Titan which has this useless feature > allowing users to control the brightness of the LED behind the > logo of NVIDIA. In the true spirit of open source, let's expose > that to the users of very expensive cards! > >

[Nouveau] [PATCH] drm/nouveau: add a LED driver for the NVIDIA logo

2016-05-03 Thread Martin Peres
We received a donation of a Titan which has this useless feature allowing users to control the brightness of the LED behind the logo of NVIDIA. In the true spirit of open source, let's expose that to the users of very expensive cards! This patch hooks up this LED/PWM to the LED subsystem which all