[Nouveau] [PATCH 1/1] drm/nouveau: fix error return code in nouveau_backlight_init()

2021-05-08 Thread Zhen Lei
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: db1a0ae21461 ("drm/nouveau/bl: Assign different names to interfaces") Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 1 +

Re: [Nouveau] [PATCH 1/1] drm/nouveau: fix error return code in nouveau_backlight_init()

2021-05-08 Thread Leizhen (ThunderTown)
On 2021/5/8 15:34, Pierre Moreau wrote: > Hello Zhen, > > There was a similar patch sent in last month, though which does not seem to > have been merged yet; see > https://lists.freedesktop.org/archives/nouveau/2021-April/038451.html. > > Whether `ret` should be `-ENOSPC` or `-ENOMEM` is hard

Re: [Nouveau] [PATCH 1/1] drm/nouveau: fix error return code in nouveau_backlight_init()

2021-05-08 Thread Pierre Moreau
Hello Zhen, There was a similar patch sent in last month, though which does not seem to have been merged yet; see https://lists.freedesktop.org/archives/nouveau/2021-April/038451.html. Whether `ret` should be `-ENOSPC` or `-ENOMEM` is hard to say as `nouveau_get_backlight_name()` could fail due