Re: [Nouveau] [PATCH v2] nv110/exa: update sched codes

2017-06-09 Thread Samuel Pitoiset
On 06/08/2017 05:19 PM, Aaryaman Vasishta wrote: On Thu, Jun 8, 2017 at 5:01 AM, Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: On 06/07/2017 06:58 PM, Aaryaman Vasishta wrote: On Tue, Jun 6, 2017 at 7:15 AM, Samuel Pitoiset mailto:samuel.pitoi...@gmail.

Re: [Nouveau] [PATCH v2] nv110/exa: update sched codes

2017-06-08 Thread Aaryaman Vasishta
On Thu, Jun 8, 2017 at 5:01 AM, Samuel Pitoiset wrote: > > > On 06/07/2017 06:58 PM, Aaryaman Vasishta wrote: > >> >> >> On Tue, Jun 6, 2017 at 7:15 AM, Samuel Pitoiset < >> samuel.pitoi...@gmail.com > wrote: >> >> Nice work! >> >> See my comments below,

Re: [Nouveau] [PATCH v2] nv110/exa: update sched codes

2017-06-07 Thread Samuel Pitoiset
On 06/07/2017 06:58 PM, Aaryaman Vasishta wrote: On Tue, Jun 6, 2017 at 7:15 AM, Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: Nice work! See my comments below, and double-check if some of them can be applied to the shaders I didn't review yet. I recommend you

Re: [Nouveau] [PATCH v2] nv110/exa: update sched codes

2017-06-07 Thread Aaryaman Vasishta
On Tue, Jun 6, 2017 at 7:15 AM, Samuel Pitoiset wrote: > Nice work! > > See my comments below, and double-check if some of them can be applied to > the shaders I didn't review yet. > > I recommend you to test your work because if one sched code is wrong, you > are likely going to kill your card a

Re: [Nouveau] [PATCH v2] nv110/exa: update sched codes

2017-06-05 Thread Samuel Pitoiset
Nice work! See my comments below, and double-check if some of them can be applied to the shaders I didn't review yet. I recommend you to test your work because if one sched code is wrong, you are likely going to kill your card and reboot your box. :-) On 06/03/2017 04:16 PM, Aaryaman Vasish

[Nouveau] [PATCH v2] nv110/exa: update sched codes

2017-06-03 Thread Aaryaman Vasishta
v2: Add missing delays This patch adds proper delays to maxwell exa shaders. rendercheck tests seem consistent with/without this patch. I haven't extensively tested them though. Trello: https://trello.com/c/6LPB2EIS/174-update-maxwell-shaders-with-proper-delays Signed-off-by: Aaryaman Vasishta