Re: [Nouveau] [PATCH v2 00/22] Deprecate struct drm_device.irq_enabled

2021-06-26 Thread Thomas Zimmermann
Am 22.06.21 um 18:11 schrieb Laurent Pinchart: Hi Thomas, Thank you for the patches. On Tue, Jun 22, 2021 at 04:09:40PM +0200, Thomas Zimmermann wrote: Remove references to struct drm_device.irq_enabled from modern DRM drivers and core. KMS drivers enable IRQs for their devices internally.

Re: [Nouveau] [PATCH v2 00/22] Deprecate struct drm_device.irq_enabled

2021-06-26 Thread Laurent Pinchart
On Tue, Jun 22, 2021 at 07:11:33PM +0300, Laurent Pinchart wrote: > Hi Thomas, > > Thank you for the patches. > > On Tue, Jun 22, 2021 at 04:09:40PM +0200, Thomas Zimmermann wrote: > > Remove references to struct drm_device.irq_enabled from modern > > DRM drivers and core. > > > > KMS drivers

Re: [Nouveau] [PATCH v2 00/22] Deprecate struct drm_device.irq_enabled

2021-06-26 Thread Laurent Pinchart
Hi Thomas, Thank you for the patches. On Tue, Jun 22, 2021 at 04:09:40PM +0200, Thomas Zimmermann wrote: > Remove references to struct drm_device.irq_enabled from modern > DRM drivers and core. > > KMS drivers enable IRQs for their devices internally. They don't > have to keep track of the IRQ

Re: [Nouveau] [PATCH v2 00/22] Deprecate struct drm_device.irq_enabled

2021-06-26 Thread Daniel Vetter
On Tue, Jun 22, 2021 at 04:09:40PM +0200, Thomas Zimmermann wrote: > Remove references to struct drm_device.irq_enabled from modern > DRM drivers and core. > > KMS drivers enable IRQs for their devices internally. They don't > have to keep track of the IRQ state via irq_enabled. For vblanking, >

[Nouveau] [PATCH v2 00/22] Deprecate struct drm_device.irq_enabled

2021-06-26 Thread Thomas Zimmermann
Remove references to struct drm_device.irq_enabled from modern DRM drivers and core. KMS drivers enable IRQs for their devices internally. They don't have to keep track of the IRQ state via irq_enabled. For vblanking, it's cleaner to test for vblanking support directly than to test for enabled